* [patch 1/2] ACPI / debugger: remove some unneeded conditions
@ 2015-12-24 7:23 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2015-12-24 7:23 UTC (permalink / raw)
To: Rafael J. Wysocki, Lv Zheng
Cc: Len Brown, linux-acpi, linux-kernel, kernel-janitors
"count" is unsigned so checking for less than zero here causes a static
checker warning. And really it's better to let the access_ok() check
fail if the user passes in a NULL "buf" pointer because -EFAULT is the
correct error code.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/acpi/acpi_dbg.c b/drivers/acpi/acpi_dbg.c
index 381beb2..f2c92ab 100644
--- a/drivers/acpi/acpi_dbg.c
+++ b/drivers/acpi/acpi_dbg.c
@@ -610,8 +610,6 @@ static ssize_t acpi_aml_read(struct file *file, char __user *buf,
int ret = 0;
int size = 0;
- if (!buf || count < 0)
- return -EINVAL;
if (!count)
return 0;
if (!access_ok(VERIFY_WRITE, buf, count))
@@ -681,8 +679,6 @@ static ssize_t acpi_aml_write(struct file *file, const char __user *buf,
int ret = 0;
int size = 0;
- if (!buf || count < 0)
- return -EINVAL;
if (!count)
return 0;
if (!access_ok(VERIFY_READ, buf, count))
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [patch 1/2] ACPI / debugger: remove some unneeded conditions
@ 2015-12-24 7:23 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2015-12-24 7:23 UTC (permalink / raw)
To: Rafael J. Wysocki, Lv Zheng
Cc: Len Brown, linux-acpi, linux-kernel, kernel-janitors
"count" is unsigned so checking for less than zero here causes a static
checker warning. And really it's better to let the access_ok() check
fail if the user passes in a NULL "buf" pointer because -EFAULT is the
correct error code.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/acpi/acpi_dbg.c b/drivers/acpi/acpi_dbg.c
index 381beb2..f2c92ab 100644
--- a/drivers/acpi/acpi_dbg.c
+++ b/drivers/acpi/acpi_dbg.c
@@ -610,8 +610,6 @@ static ssize_t acpi_aml_read(struct file *file, char __user *buf,
int ret = 0;
int size = 0;
- if (!buf || count < 0)
- return -EINVAL;
if (!count)
return 0;
if (!access_ok(VERIFY_WRITE, buf, count))
@@ -681,8 +679,6 @@ static ssize_t acpi_aml_write(struct file *file, const char __user *buf,
int ret = 0;
int size = 0;
- if (!buf || count < 0)
- return -EINVAL;
if (!count)
return 0;
if (!access_ok(VERIFY_READ, buf, count))
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-24 7:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-24 7:23 [patch 1/2] ACPI / debugger: remove some unneeded conditions Dan Carpenter
2015-12-24 7:23 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.