[PATCH v2] um: Fix build error and kconfig for i386

[PATCH v2] um: Fix build error and kconfig for i386

[Mickaël Salaün]

Fix build error by selecting COREDUMP when X86_32 is selected:

arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
(.text+0x3e62): undefined reference to `dump_emit'
arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
(.text+0x3eef): undefined reference to `dump_emit'

Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
Signed-off-by: Mickaël Salaün <mic@digikod.net>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Michal Marek <mmarek@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
---
 arch/x86/um/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig
index ed56a1c4ae73..bb7cd8b38043 100644
--- a/arch/x86/um/Kconfig
+++ b/arch/x86/um/Kconfig
@@ -26,6 +26,7 @@ config X86_32
 	select CLONE_BACKWARDS
 	select OLD_SIGSUSPEND3
 	select OLD_SIGACTION
+	select COREDUMP
 
 config X86_64
 	def_bool 64BIT
-- 
2.6.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH v2] um: Fix build error and kconfig for i386

[Mickaël Salaün]

Fix build error by selecting COREDUMP when X86_32 is selected:

arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
(.text+0x3e62): undefined reference to `dump_emit'
arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
(.text+0x3eef): undefined reference to `dump_emit'

Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
Signed-off-by: Mickaël Salaün <mic@digikod.net>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Richard Weinberger <richard@nod.at>
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Michal Marek <mmarek@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
---
 arch/x86/um/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig
index ed56a1c4ae73..bb7cd8b38043 100644
--- a/arch/x86/um/Kconfig
+++ b/arch/x86/um/Kconfig
@@ -26,6 +26,7 @@ config X86_32
 	select CLONE_BACKWARDS
 	select OLD_SIGSUSPEND3
 	select OLD_SIGACTION
+	select COREDUMP
 
 config X86_64
 	def_bool 64BIT
-- 
2.6.4

Re: [PATCH v2] um: Fix build error and kconfig for i386

[Josh Triplett]

On Wed, Dec 23, 2015 at 01:59:13PM +0100, Mickaël Salaün wrote:
> Fix build error by selecting COREDUMP when X86_32 is selected:
> 
> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
> (.text+0x3e62): undefined reference to `dump_emit'
> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
> (.text+0x3eef): undefined reference to `dump_emit'
> 
> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Michal Marek <mmarek@suse.cz>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>

I suppose um doesn't care deeply about binary size, but ideally I would
suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.

>  arch/x86/um/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig
> index ed56a1c4ae73..bb7cd8b38043 100644
> --- a/arch/x86/um/Kconfig
> +++ b/arch/x86/um/Kconfig
> @@ -26,6 +26,7 @@ config X86_32
>  	select CLONE_BACKWARDS
>  	select OLD_SIGSUSPEND3
>  	select OLD_SIGACTION
> +	select COREDUMP
>  
>  config X86_64
>  	def_bool 64BIT
> -- 
> 2.6.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] um: Fix build error and kconfig for i386

[Josh Triplett]

On Wed, Dec 23, 2015 at 01:59:13PM +0100, Micka�l Sala�n wrote:
> Fix build error by selecting COREDUMP when X86_32 is selected:
> 
> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
> (.text+0x3e62): undefined reference to `dump_emit'
> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
> (.text+0x3eef): undefined reference to `dump_emit'
> 
> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> Signed-off-by: Micka�l Sala�n <mic@digikod.net>
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Michal Marek <mmarek@suse.cz>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>

I suppose um doesn't care deeply about binary size, but ideally I would
suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.

>  arch/x86/um/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig
> index ed56a1c4ae73..bb7cd8b38043 100644
> --- a/arch/x86/um/Kconfig
> +++ b/arch/x86/um/Kconfig
> @@ -26,6 +26,7 @@ config X86_32
>  	select CLONE_BACKWARDS
>  	select OLD_SIGSUSPEND3
>  	select OLD_SIGACTION
> +	select COREDUMP
>  
>  config X86_64
>  	def_bool 64BIT
> -- 
> 2.6.4
> 

Re: [PATCH v2] um: Fix build error and kconfig for i386

[Josh Triplett]

On Wed, Dec 23, 2015 at 01:59:13PM +0100, Mickaël Salaün wrote:
> Fix build error by selecting COREDUMP when X86_32 is selected:
> 
> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
> (.text+0x3e62): undefined reference to `dump_emit'
> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
> (.text+0x3eef): undefined reference to `dump_emit'
> 
> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> Cc: Jeff Dike <jdike@addtoit.com>
> Cc: Richard Weinberger <richard@nod.at>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Cc: Michal Marek <mmarek@suse.cz>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>

I suppose um doesn't care deeply about binary size, but ideally I would
suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.

>  arch/x86/um/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/um/Kconfig b/arch/x86/um/Kconfig
> index ed56a1c4ae73..bb7cd8b38043 100644
> --- a/arch/x86/um/Kconfig
> +++ b/arch/x86/um/Kconfig
> @@ -26,6 +26,7 @@ config X86_32
>  	select CLONE_BACKWARDS
>  	select OLD_SIGSUSPEND3
>  	select OLD_SIGACTION
> +	select COREDUMP
>  
>  config X86_64
>  	def_bool 64BIT
> -- 
> 2.6.4
> 

Re: [PATCH v2] um: Fix build error and kconfig for i386

[Mickaël Salaün]

[-- Attachment #1: Type: text/plain, Size: 1325 bytes --]


On 23/12/2015 22:42, Josh Triplett wrote:
> On Wed, Dec 23, 2015 at 01:59:13PM +0100, Mickaël Salaün wrote:
>> Fix build error by selecting COREDUMP when X86_32 is selected:
>>
>> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
>> (.text+0x3e62): undefined reference to `dump_emit'
>> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
>> (.text+0x3eef): undefined reference to `dump_emit'
>>
>> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
>> Signed-off-by: Mickaël Salaün <mic@digikod.net>
>> Cc: Jeff Dike <jdike@addtoit.com>
>> Cc: Richard Weinberger <richard@nod.at>
>> Cc: Josh Triplett <josh@joshtriplett.org>
>> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>> Cc: Michal Marek <mmarek@suse.cz>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> 
> I suppose um doesn't care deeply about binary size, but ideally I would
> suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
> CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.

That looks better! Since the first patch has been added to the mmots tree (but not yet in mmotm) I'll send a patch update instead of a new one reverting the first. I hope this is OK.

Regards,
 Mickaël


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: [PATCH v2] um: Fix build error and kconfig for i386

[Josh Triplett]

On Thu, Dec 24, 2015 at 01:09:45PM +0100, Mickaël Salaün wrote:
> 
> On 23/12/2015 22:42, Josh Triplett wrote:
> > On Wed, Dec 23, 2015 at 01:59:13PM +0100, Mickaël Salaün wrote:
> >> Fix build error by selecting COREDUMP when X86_32 is selected:
> >>
> >> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
> >> (.text+0x3e62): undefined reference to `dump_emit'
> >> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
> >> (.text+0x3eef): undefined reference to `dump_emit'
> >>
> >> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> >> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> >> Cc: Jeff Dike <jdike@addtoit.com>
> >> Cc: Richard Weinberger <richard@nod.at>
> >> Cc: Josh Triplett <josh@joshtriplett.org>
> >> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> >> Cc: Michal Marek <mmarek@suse.cz>
> >> Cc: Andrew Morton <akpm@linux-foundation.org>
> >> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > 
> > I suppose um doesn't care deeply about binary size, but ideally I would
> > suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
> > CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.
> 
> That looks better! Since the first patch has been added to the mmots tree (but not yet in mmotm) I'll send a patch update instead of a new one reverting the first. I hope this is OK.

-mm regularly replaces patches with newer versions, so that ought to be
fine.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] um: Fix build error and kconfig for i386

[Josh Triplett]

On Thu, Dec 24, 2015 at 01:09:45PM +0100, Micka�l Sala�n wrote:
> 
> On 23/12/2015 22:42, Josh Triplett wrote:
> > On Wed, Dec 23, 2015 at 01:59:13PM +0100, Micka�l Sala�n wrote:
> >> Fix build error by selecting COREDUMP when X86_32 is selected:
> >>
> >> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
> >> (.text+0x3e62): undefined reference to `dump_emit'
> >> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
> >> (.text+0x3eef): undefined reference to `dump_emit'
> >>
> >> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> >> Signed-off-by: Micka�l Sala�n <mic@digikod.net>
> >> Cc: Jeff Dike <jdike@addtoit.com>
> >> Cc: Richard Weinberger <richard@nod.at>
> >> Cc: Josh Triplett <josh@joshtriplett.org>
> >> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> >> Cc: Michal Marek <mmarek@suse.cz>
> >> Cc: Andrew Morton <akpm@linux-foundation.org>
> >> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > 
> > I suppose um doesn't care deeply about binary size, but ideally I would
> > suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
> > CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.
> 
> That looks better! Since the first patch has been added to the mmots tree (but not yet in mmotm) I'll send a patch update instead of a new one reverting the first. I hope this is OK.

-mm regularly replaces patches with newer versions, so that ought to be
fine.

Re: [PATCH v2] um: Fix build error and kconfig for i386

[Josh Triplett]

On Thu, Dec 24, 2015 at 01:09:45PM +0100, Mickaël Salaün wrote:
> 
> On 23/12/2015 22:42, Josh Triplett wrote:
> > On Wed, Dec 23, 2015 at 01:59:13PM +0100, Mickaël Salaün wrote:
> >> Fix build error by selecting COREDUMP when X86_32 is selected:
> >>
> >> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
> >> (.text+0x3e62): undefined reference to `dump_emit'
> >> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
> >> (.text+0x3eef): undefined reference to `dump_emit'
> >>
> >> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
> >> Signed-off-by: Mickaël Salaün <mic@digikod.net>
> >> Cc: Jeff Dike <jdike@addtoit.com>
> >> Cc: Richard Weinberger <richard@nod.at>
> >> Cc: Josh Triplett <josh@joshtriplett.org>
> >> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> >> Cc: Michal Marek <mmarek@suse.cz>
> >> Cc: Andrew Morton <akpm@linux-foundation.org>
> >> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> > 
> > I suppose um doesn't care deeply about binary size, but ideally I would
> > suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
> > CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.
> 
> That looks better! Since the first patch has been added to the mmots tree (but not yet in mmotm) I'll send a patch update instead of a new one reverting the first. I hope this is OK.

-mm regularly replaces patches with newer versions, so that ought to be
fine.

Re: [PATCH v2] um: Fix build error and kconfig for i386

[Richard Weinberger]

Am 25.12.2015 um 02:26 schrieb Josh Triplett:
> On Thu, Dec 24, 2015 at 01:09:45PM +0100, Mickaël Salaün wrote:
>>
>> On 23/12/2015 22:42, Josh Triplett wrote:
>>> On Wed, Dec 23, 2015 at 01:59:13PM +0100, Mickaël Salaün wrote:
>>>> Fix build error by selecting COREDUMP when X86_32 is selected:
>>>>
>>>> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
>>>> (.text+0x3e62): undefined reference to `dump_emit'
>>>> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
>>>> (.text+0x3eef): undefined reference to `dump_emit'
>>>>
>>>> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
>>>> Signed-off-by: Mickaël Salaün <mic@digikod.net>
>>>> Cc: Jeff Dike <jdike@addtoit.com>
>>>> Cc: Richard Weinberger <richard@nod.at>
>>>> Cc: Josh Triplett <josh@joshtriplett.org>
>>>> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>>>> Cc: Michal Marek <mmarek@suse.cz>
>>>> Cc: Andrew Morton <akpm@linux-foundation.org>
>>>> Cc: Linus Torvalds <torvalds@linux-foundation.org>
>>>
>>> I suppose um doesn't care deeply about binary size, but ideally I would
>>> suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
>>> CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.
>>
>> That looks better! Since the first patch has been added to the mmots tree (but not yet in mmotm) I'll send a patch update instead of a new one reverting the first. I hope this is OK.
> 
> -mm regularly replaces patches with newer versions, so that ought to be
> fine.

Usually non-trivial UML stuff goes thought me.
As Josh noted, just post an updated version of the patch.
Either me or Andrew will pick it up.

Thanks,
//richard

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH v2] um: Fix build error and kconfig for i386

[Richard Weinberger]

Am 25.12.2015 um 02:26 schrieb Josh Triplett:
> On Thu, Dec 24, 2015 at 01:09:45PM +0100, Micka�l Sala�n wrote:
>>
>> On 23/12/2015 22:42, Josh Triplett wrote:
>>> On Wed, Dec 23, 2015 at 01:59:13PM +0100, Micka�l Sala�n wrote:
>>>> Fix build error by selecting COREDUMP when X86_32 is selected:
>>>>
>>>> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
>>>> (.text+0x3e62): undefined reference to `dump_emit'
>>>> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
>>>> (.text+0x3eef): undefined reference to `dump_emit'
>>>>
>>>> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
>>>> Signed-off-by: Micka�l Sala�n <mic@digikod.net>
>>>> Cc: Jeff Dike <jdike@addtoit.com>
>>>> Cc: Richard Weinberger <richard@nod.at>
>>>> Cc: Josh Triplett <josh@joshtriplett.org>
>>>> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>>>> Cc: Michal Marek <mmarek@suse.cz>
>>>> Cc: Andrew Morton <akpm@linux-foundation.org>
>>>> Cc: Linus Torvalds <torvalds@linux-foundation.org>
>>>
>>> I suppose um doesn't care deeply about binary size, but ideally I would
>>> suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
>>> CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.
>>
>> That looks better! Since the first patch has been added to the mmots tree (but not yet in mmotm) I'll send a patch update instead of a new one reverting the first. I hope this is OK.
> 
> -mm regularly replaces patches with newer versions, so that ought to be
> fine.

Usually non-trivial UML stuff goes thought me.
As Josh noted, just post an updated version of the patch.
Either me or Andrew will pick it up.

Thanks,
//richard

Re: [PATCH v2] um: Fix build error and kconfig for i386

[Richard Weinberger]

Am 25.12.2015 um 02:26 schrieb Josh Triplett:
> On Thu, Dec 24, 2015 at 01:09:45PM +0100, Mickaël Salaün wrote:
>>
>> On 23/12/2015 22:42, Josh Triplett wrote:
>>> On Wed, Dec 23, 2015 at 01:59:13PM +0100, Mickaël Salaün wrote:
>>>> Fix build error by selecting COREDUMP when X86_32 is selected:
>>>>
>>>> arch/x86/um/built-in.o: In function `elf_core_write_extra_phdrs':
>>>> (.text+0x3e62): undefined reference to `dump_emit'
>>>> arch/x86/um/built-in.o: In function `elf_core_write_extra_data':
>>>> (.text+0x3eef): undefined reference to `dump_emit'
>>>>
>>>> Fixes: 5d2acfc7b974 ("kconfig: make allnoconfig disable options behind EMBEDDED and EXPERT")
>>>> Signed-off-by: Mickaël Salaün <mic@digikod.net>
>>>> Cc: Jeff Dike <jdike@addtoit.com>
>>>> Cc: Richard Weinberger <richard@nod.at>
>>>> Cc: Josh Triplett <josh@joshtriplett.org>
>>>> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>>>> Cc: Michal Marek <mmarek@suse.cz>
>>>> Cc: Andrew Morton <akpm@linux-foundation.org>
>>>> Cc: Linus Torvalds <torvalds@linux-foundation.org>
>>>
>>> I suppose um doesn't care deeply about binary size, but ideally I would
>>> suggest changing arch/x86/um/Makefile to make elfcore.c compiled in when
>>> CONFIG_ELF_CORE rather than CONFIG_BINFMT_ELF.
>>
>> That looks better! Since the first patch has been added to the mmots tree (but not yet in mmotm) I'll send a patch update instead of a new one reverting the first. I hope this is OK.
> 
> -mm regularly replaces patches with newer versions, so that ought to be
> fine.

Usually non-trivial UML stuff goes thought me.
As Josh noted, just post an updated version of the patch.
Either me or Andrew will pick it up.

Thanks,
//richard