From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Suravee Suthikulpanit
<Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
Cc: peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org
Subject: Re: [PATCH 3/6] iommu/amd: Introduce amd_iommu_get_num_iommus()
Date: Mon, 28 Dec 2015 16:43:00 +0100 [thread overview]
Message-ID: <20151228154300.GK18805@8bytes.org> (raw)
In-Reply-To: <1450811957-1511-4-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
On Tue, Dec 22, 2015 at 01:19:14PM -0600, Suthikulpanit, Suravee wrote:
> This patch introduces amd_iommu_get_num_iommus(). Initially, this is
> intended to be used by Perf AMD IOMMU driver.
>
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
> ---
> drivers/iommu/amd_iommu_init.c | 16 ++++++++++++++++
> include/linux/perf/perf_event_amd_iommu.h | 2 ++
> 2 files changed, 18 insertions(+)
>
> diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
> index 275c0f5..9c62613 100644
> --- a/drivers/iommu/amd_iommu_init.c
> +++ b/drivers/iommu/amd_iommu_init.c
> @@ -2244,6 +2244,22 @@ bool amd_iommu_v2_supported(void)
> }
> EXPORT_SYMBOL(amd_iommu_v2_supported);
>
> +static int amd_iommu_cnt;
> +
> +int amd_iommu_get_num_iommus(void)
> +{
> + struct amd_iommu *iommu;
> +
> + if (amd_iommu_cnt)
> + return amd_iommu_cnt;
> +
> + for_each_iommu(iommu)
> + amd_iommu_cnt++;
It is better to set amd_iommu_cnt during IOMMU initialization. You can
just increment this value after an IOMMU has been set up.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
Cc: bp@alien8.de, peterz@infradead.org, mingo@redhat.com,
acme@kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH 3/6] iommu/amd: Introduce amd_iommu_get_num_iommus()
Date: Mon, 28 Dec 2015 16:43:00 +0100 [thread overview]
Message-ID: <20151228154300.GK18805@8bytes.org> (raw)
In-Reply-To: <1450811957-1511-4-git-send-email-Suravee.Suthikulpanit@amd.com>
On Tue, Dec 22, 2015 at 01:19:14PM -0600, Suthikulpanit, Suravee wrote:
> This patch introduces amd_iommu_get_num_iommus(). Initially, this is
> intended to be used by Perf AMD IOMMU driver.
>
> Signed-off-by: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
> ---
> drivers/iommu/amd_iommu_init.c | 16 ++++++++++++++++
> include/linux/perf/perf_event_amd_iommu.h | 2 ++
> 2 files changed, 18 insertions(+)
>
> diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
> index 275c0f5..9c62613 100644
> --- a/drivers/iommu/amd_iommu_init.c
> +++ b/drivers/iommu/amd_iommu_init.c
> @@ -2244,6 +2244,22 @@ bool amd_iommu_v2_supported(void)
> }
> EXPORT_SYMBOL(amd_iommu_v2_supported);
>
> +static int amd_iommu_cnt;
> +
> +int amd_iommu_get_num_iommus(void)
> +{
> + struct amd_iommu *iommu;
> +
> + if (amd_iommu_cnt)
> + return amd_iommu_cnt;
> +
> + for_each_iommu(iommu)
> + amd_iommu_cnt++;
It is better to set amd_iommu_cnt during IOMMU initialization. You can
just increment this value after an IOMMU has been set up.
Joerg
next prev parent reply other threads:[~2015-12-28 15:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-22 19:19 [PATCH 0/6] perf/amd/iommu: Enable multi-IOMMU support Suravee Suthikulpanit
2015-12-22 19:19 ` Suravee Suthikulpanit
[not found] ` <1450811957-1511-1-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2015-12-22 19:19 ` [PATCH 1/6] perf/amd/iommu: Consolidate and move perf_event_amd_iommu header Suravee Suthikulpanit
2015-12-22 19:19 ` Suravee Suthikulpanit
2015-12-22 19:19 ` [PATCH 2/6] perf/amd/iommu: Modify functions to query max banks and counters Suravee Suthikulpanit
2015-12-22 19:19 ` Suravee Suthikulpanit
2015-12-22 19:19 ` [PATCH 3/6] iommu/amd: Introduce amd_iommu_get_num_iommus() Suravee Suthikulpanit
2015-12-22 19:19 ` Suravee Suthikulpanit
[not found] ` <1450811957-1511-4-git-send-email-Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
2015-12-28 15:43 ` Joerg Roedel [this message]
2015-12-28 15:43 ` Joerg Roedel
[not found] ` <20151228154300.GK18805-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2015-12-29 21:20 ` Suravee Suthikulpanit
2015-12-29 21:20 ` Suravee Suthikulpanit
2015-12-22 19:19 ` [PATCH 4/6] perf/amd/iommu: Introduce data structure for tracking prev count Suravee Suthikulpanit
2015-12-22 19:19 ` Suravee Suthikulpanit
2015-12-22 19:19 ` [PATCH 5/6] perf/amd/iommu: Introduce get_iommu_bnk_cnt_evt_idx Suravee Suthikulpanit
2015-12-22 19:19 ` Suravee Suthikulpanit
2015-12-22 19:19 ` [PATCH 6/6] perf/amd/iommu: Enable support for multiple IOMMUs Suravee Suthikulpanit
2015-12-22 19:19 ` Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151228154300.GK18805@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org \
--cc=acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=bp-Gina5bIWoIWzQB+pC5nmwQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.