From: Greg Kroah-Hartman <greg@kroah.com>
To: Rajat Jain <rajatxjain@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-newbie@vger.kernel.org
Subject: Re: debugfs_remove_recursive() while a file is in use by userspace
Date: Mon, 28 Dec 2015 13:17:53 -0800 [thread overview]
Message-ID: <20151228211753.GB24118@kroah.com> (raw)
In-Reply-To: <CAA93t1o9We6EFgvJ+7dPndptcurp=ZTw=jfb0ek_hhmB21tRkA@mail.gmail.com>
On Mon, Dec 28, 2015 at 01:11:53PM -0800, Rajat Jain wrote:
> On Mon, Dec 28, 2015 at 12:58 PM, Greg Kroah-Hartman <greg@kroah.com> wrote:
> > On Mon, Dec 28, 2015 at 12:51:32PM -0800, Rajat Jain wrote:
> >> Thanks Greg and Al for the quick turnaround.
> >>
> >> Essentially I have a device that supports something called "contexts"
> >> that can be "created" and "destroyed" during the life of the device. I
> >> want to expose some debug files for the context when it is created,
> >> and destroy the files when the context is destroyed. However, I'm not
> >> sure how do I ensure that the user is not in the middle of reading /
> >> writing / mmaping to those files. Also how do I know that user is
> >> still not holding a reference to the file structure.
> >
> > You don't.
> >
> >> It seems like debugfs is currently not a good choice for this? Would
> >> you recommend me to any other fs or subsystem that I should use for
> >> this?
> >
> > What exactly do you need to export to userspace and for what purpose?
> > For debugging-only stuff, sure, use debugfs, but don't rely on it for
> > any "real" tools, only your own debugging.
>
> I'm actually writing a driver that would expose a "dummy device" to a
> real driver. The dummy driver relies on user space to feed in the
> device attributes (no of supported contexts etc).
That sounds "odd".
Why not configfs?
> I am now thinking that a character device interface to user space may
> actually be a better choice.
Not really, you would now have to parse things in a character driver
write() callback, not very good or robust.
> Question: Does cdev_del() ensure that all references to the file are
> dropped before it returns?
No, but when the reference is dropped, everything cleans up properly.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-newbie" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.linux-learn.org/faqs
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <greg@kroah.com>
To: Rajat Jain <rajatxjain@gmail.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-newbie@vger.kernel.org
Subject: Re: debugfs_remove_recursive() while a file is in use by userspace
Date: Mon, 28 Dec 2015 13:17:53 -0800 [thread overview]
Message-ID: <20151228211753.GB24118@kroah.com> (raw)
In-Reply-To: <CAA93t1o9We6EFgvJ+7dPndptcurp=ZTw=jfb0ek_hhmB21tRkA@mail.gmail.com>
On Mon, Dec 28, 2015 at 01:11:53PM -0800, Rajat Jain wrote:
> On Mon, Dec 28, 2015 at 12:58 PM, Greg Kroah-Hartman <greg@kroah.com> wrote:
> > On Mon, Dec 28, 2015 at 12:51:32PM -0800, Rajat Jain wrote:
> >> Thanks Greg and Al for the quick turnaround.
> >>
> >> Essentially I have a device that supports something called "contexts"
> >> that can be "created" and "destroyed" during the life of the device. I
> >> want to expose some debug files for the context when it is created,
> >> and destroy the files when the context is destroyed. However, I'm not
> >> sure how do I ensure that the user is not in the middle of reading /
> >> writing / mmaping to those files. Also how do I know that user is
> >> still not holding a reference to the file structure.
> >
> > You don't.
> >
> >> It seems like debugfs is currently not a good choice for this? Would
> >> you recommend me to any other fs or subsystem that I should use for
> >> this?
> >
> > What exactly do you need to export to userspace and for what purpose?
> > For debugging-only stuff, sure, use debugfs, but don't rely on it for
> > any "real" tools, only your own debugging.
>
> I'm actually writing a driver that would expose a "dummy device" to a
> real driver. The dummy driver relies on user space to feed in the
> device attributes (no of supported contexts etc).
That sounds "odd".
Why not configfs?
> I am now thinking that a character device interface to user space may
> actually be a better choice.
Not really, you would now have to parse things in a character driver
write() callback, not very good or robust.
> Question: Does cdev_del() ensure that all references to the file are
> dropped before it returns?
No, but when the reference is dropped, everything cleans up properly.
thanks,
greg k-h
next prev parent reply other threads:[~2015-12-28 21:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-28 20:27 debugfs_remove_recursive() while a file is in use by userspace Rajat Jain
2015-12-28 20:30 ` Al Viro
2015-12-28 20:30 ` Al Viro
2015-12-28 20:31 ` Greg Kroah-Hartman
2015-12-28 20:51 ` Rajat Jain
2015-12-28 20:51 ` Rajat Jain
2015-12-28 20:58 ` Greg Kroah-Hartman
2015-12-28 21:11 ` Rajat Jain
2015-12-28 21:17 ` Greg Kroah-Hartman [this message]
2015-12-28 21:17 ` Greg Kroah-Hartman
2015-12-28 20:42 ` Nicolai Stange
2015-12-28 20:42 ` Nicolai Stange
2015-12-28 20:56 ` Rajat Jain
2015-12-28 20:56 ` Rajat Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151228211753.GB24118@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-newbie@vger.kernel.org \
--cc=rajatxjain@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.