All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	"Milo Kim" <milo.kim-l0cyMroinI0@public.gmane.org>,
	"Russell King" <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
	"Pawel Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
	"Ian Campbell"
	<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
	"Tony Lindgren" <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
	"Mark Brown" <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Liam Girdwood"
	<lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Benoît Cousson"
	<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	"Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support
Date: Tue, 29 Dec 2015 14:02:44 -0600	[thread overview]
Message-ID: <20151229200244.GA27426@rob-hp-laptop> (raw)
In-Reply-To: <1450868319-20513-5-git-send-email-contact-W9ppeneeCTY@public.gmane.org>

On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote:
> LP872x regulators are made active via the EN pin, which might be hooked to a
> GPIO. This adds support for driving the GPIO high when the driver is in use.
> 
> Signed-off-by: Paul Kocialkowski <contact-W9ppeneeCTY@public.gmane.org>
> ---
>  .../devicetree/bindings/regulator/lp872x.txt       |  1 +
>  drivers/regulator/lp872x.c                         | 33 ++++++++++++++++++++--
>  include/linux/regulator/lp872x.h                   |  2 ++
>  3 files changed, 33 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/lp872x.txt b/Documentation/devicetree/bindings/regulator/lp872x.txt
> index 7818318..0559c25 100644
> --- a/Documentation/devicetree/bindings/regulator/lp872x.txt
> +++ b/Documentation/devicetree/bindings/regulator/lp872x.txt
> @@ -28,6 +28,7 @@ Optional properties:
>    - ti,dvs-gpio: GPIO specifier for external DVS pin control of LP872x devices.
>    - ti,dvs-vsel: DVS selector. 0 = SEL_V1, 1 = SEL_V2.
>    - ti,dvs-state: initial DVS pin state. 0 = DVS_LOW, 1 = DVS_HIGH.
> +  - ti,enable-gpio: GPIO specifier for EN pin control of LP872x devices.

Should be "-gpios" instead of "-gpio".

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support
Date: Tue, 29 Dec 2015 14:02:44 -0600	[thread overview]
Message-ID: <20151229200244.GA27426@rob-hp-laptop> (raw)
In-Reply-To: <1450868319-20513-5-git-send-email-contact@paulk.fr>

On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote:
> LP872x regulators are made active via the EN pin, which might be hooked to a
> GPIO. This adds support for driving the GPIO high when the driver is in use.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  .../devicetree/bindings/regulator/lp872x.txt       |  1 +
>  drivers/regulator/lp872x.c                         | 33 ++++++++++++++++++++--
>  include/linux/regulator/lp872x.h                   |  2 ++
>  3 files changed, 33 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/lp872x.txt b/Documentation/devicetree/bindings/regulator/lp872x.txt
> index 7818318..0559c25 100644
> --- a/Documentation/devicetree/bindings/regulator/lp872x.txt
> +++ b/Documentation/devicetree/bindings/regulator/lp872x.txt
> @@ -28,6 +28,7 @@ Optional properties:
>    - ti,dvs-gpio: GPIO specifier for external DVS pin control of LP872x devices.
>    - ti,dvs-vsel: DVS selector. 0 = SEL_V1, 1 = SEL_V2.
>    - ti,dvs-state: initial DVS pin state. 0 = DVS_LOW, 1 = DVS_HIGH.
> +  - ti,enable-gpio: GPIO specifier for EN pin control of LP872x devices.

Should be "-gpios" instead of "-gpio".

Rob

WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Paul Kocialkowski <contact@paulk.fr>
Cc: linux-kernel@vger.kernel.org,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Milo Kim" <milo.kim@ti.com>,
	"Russell King" <linux@arm.linux.org.uk>,
	"Pawel Moll" <pawel.moll@arm.com>,
	"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
	"Tony Lindgren" <tony@atomide.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	devicetree@vger.kernel.org,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Kumar Gala" <galak@codeaurora.org>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support
Date: Tue, 29 Dec 2015 14:02:44 -0600	[thread overview]
Message-ID: <20151229200244.GA27426@rob-hp-laptop> (raw)
In-Reply-To: <1450868319-20513-5-git-send-email-contact@paulk.fr>

On Wed, Dec 23, 2015 at 11:58:37AM +0100, Paul Kocialkowski wrote:
> LP872x regulators are made active via the EN pin, which might be hooked to a
> GPIO. This adds support for driving the GPIO high when the driver is in use.
> 
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  .../devicetree/bindings/regulator/lp872x.txt       |  1 +
>  drivers/regulator/lp872x.c                         | 33 ++++++++++++++++++++--
>  include/linux/regulator/lp872x.h                   |  2 ++
>  3 files changed, 33 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/lp872x.txt b/Documentation/devicetree/bindings/regulator/lp872x.txt
> index 7818318..0559c25 100644
> --- a/Documentation/devicetree/bindings/regulator/lp872x.txt
> +++ b/Documentation/devicetree/bindings/regulator/lp872x.txt
> @@ -28,6 +28,7 @@ Optional properties:
>    - ti,dvs-gpio: GPIO specifier for external DVS pin control of LP872x devices.
>    - ti,dvs-vsel: DVS selector. 0 = SEL_V1, 1 = SEL_V2.
>    - ti,dvs-state: initial DVS pin state. 0 = DVS_LOW, 1 = DVS_HIGH.
> +  - ti,enable-gpio: GPIO specifier for EN pin control of LP872x devices.

Should be "-gpios" instead of "-gpio".

Rob

  parent reply	other threads:[~2015-12-29 20:02 UTC|newest]

Thread overview: 115+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-23 10:58 [PATCH 0/6] LG Optimus Black (P970) codename sniper support and lp872x improvements Paul Kocialkowski
2015-12-23 10:58 ` Paul Kocialkowski
2015-12-23 10:58 ` Paul Kocialkowski
2015-12-23 10:58 ` [PATCH 1/6] regulator: lp872x: Add missing of_match in regulators descriptions Paul Kocialkowski
2015-12-23 10:58   ` Paul Kocialkowski
2015-12-23 10:58   ` Paul Kocialkowski
2015-12-23 12:13   ` Applied "regulator: lp872x: Add missing of_match in regulators descriptions" to the regulator tree Mark Brown
2015-12-28  1:04   ` [PATCH 1/6] regulator: lp872x: Add missing of_match in regulators descriptions Milo Kim
2015-12-28  1:04     ` Milo Kim
2015-12-23 10:58 ` [PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to DVS GPIO Paul Kocialkowski
2015-12-23 10:58   ` Paul Kocialkowski
2015-12-23 10:58   ` Paul Kocialkowski
2015-12-23 12:13   ` Applied "regulator: lp872x: Get rid of duplicate reference to DVS GPIO" to the regulator tree Mark Brown
2015-12-28  1:05   ` [PATCH 2/6] regulator: lp872x: Get rid of duplicate reference to DVS GPIO Milo Kim
2015-12-28  1:05     ` Milo Kim
2015-12-28  1:05     ` Milo Kim
2015-12-23 10:58 ` [PATCH 3/6] regulator: lp872x: Remove warning about invalid " Paul Kocialkowski
2015-12-23 10:58   ` Paul Kocialkowski
2015-12-23 10:58   ` Paul Kocialkowski
2015-12-23 11:41   ` Mark Brown
2015-12-23 11:41     ` Mark Brown
2015-12-23 11:50     ` Paul Kocialkowski
2015-12-23 11:50       ` Paul Kocialkowski
2015-12-23 11:58       ` Mark Brown
2015-12-23 11:58         ` Mark Brown
2015-12-23 11:58         ` Mark Brown
2015-12-23 10:58 ` [PATCH 4/6] regulator: lp872x: Add enable GPIO pin support Paul Kocialkowski
2015-12-23 10:58   ` Paul Kocialkowski
2015-12-23 10:58   ` Paul Kocialkowski
     [not found]   ` <1450868319-20513-5-git-send-email-contact-W9ppeneeCTY@public.gmane.org>
2015-12-23 11:56     ` Mark Brown
2015-12-23 11:56       ` Mark Brown
2015-12-23 11:56       ` Mark Brown
2015-12-23 12:52       ` Paul Kocialkowski
2015-12-23 12:52         ` Paul Kocialkowski
     [not found]       ` <20151223115632.GS16023-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-12-24 18:12         ` Paul Kocialkowski
2015-12-24 18:12           ` Paul Kocialkowski
2015-12-24 18:12           ` Paul Kocialkowski
2015-12-24 19:35           ` Mark Brown
2015-12-24 19:35             ` Mark Brown
2015-12-24 19:35             ` Mark Brown
2015-12-24 20:05             ` Paul Kocialkowski
2015-12-24 20:05               ` Paul Kocialkowski
2015-12-28  0:56       ` Milo Kim
2015-12-28  0:56         ` Milo Kim
2015-12-28  0:56         ` Milo Kim
     [not found]         ` <568088B4.6090207-l0cyMroinI0@public.gmane.org>
2015-12-28 22:49           ` Paul Kocialkowski
2015-12-28 22:49             ` Paul Kocialkowski
2015-12-28 22:49             ` Paul Kocialkowski
2015-12-29  0:45             ` Milo Kim
2015-12-29  0:45               ` Milo Kim
2015-12-29  0:45               ` Milo Kim
2015-12-29 11:13               ` Paul Kocialkowski
2015-12-29 11:13                 ` Paul Kocialkowski
2015-12-30  0:22                 ` Milo Kim
2015-12-30  0:22                   ` Milo Kim
2015-12-30  0:22                   ` Milo Kim
2015-12-30  8:35                   ` Paul Kocialkowski
2015-12-30  8:35                     ` Paul Kocialkowski
2015-12-30 16:33                     ` Mark Brown
2015-12-30 16:33                       ` Mark Brown
2015-12-30 16:33                       ` Mark Brown
2015-12-30 18:37                       ` Paul Kocialkowski
2015-12-30 18:37                         ` Paul Kocialkowski
2015-12-31 21:40                         ` Mark Brown
2015-12-31 21:40                           ` Mark Brown
2015-12-31 21:40                           ` Mark Brown
     [not found]                           ` <20151231214007.GC16023-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-12-31 21:59                             ` Paul Kocialkowski
2015-12-31 21:59                               ` Paul Kocialkowski
2015-12-31 21:59                               ` Paul Kocialkowski
2015-12-31 22:14                               ` Mark Brown
2015-12-31 22:14                                 ` Mark Brown
2015-12-31 22:14                                 ` Mark Brown
     [not found]                                 ` <20151231221407.GF16023-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2016-01-03 10:19                                   ` Paul Kocialkowski
2016-01-03 10:19                                     ` Paul Kocialkowski
2016-01-03 10:19                                     ` Paul Kocialkowski
2016-01-16  7:32                                   ` Paul Kocialkowski
2016-01-16  7:32                                     ` Paul Kocialkowski
2016-01-16  7:32                                     ` Paul Kocialkowski
2016-01-18 16:32                                     ` Mark Brown
2016-01-18 16:32                                       ` Mark Brown
2016-01-18 16:32                                       ` Mark Brown
2016-02-05 18:48                                       ` Paul Kocialkowski
2016-02-05 18:48                                         ` Paul Kocialkowski
2015-12-28  0:34     ` Milo Kim
2015-12-28  0:34       ` Milo Kim
2015-12-28  0:34       ` Milo Kim
2016-02-05 18:49       ` Paul Kocialkowski
2016-02-05 18:49         ` Paul Kocialkowski
2015-12-29 20:02     ` Rob Herring [this message]
2015-12-29 20:02       ` Rob Herring
2015-12-29 20:02       ` Rob Herring
2015-12-29 21:26       ` Paul Kocialkowski
2015-12-29 21:26         ` Paul Kocialkowski
2015-12-29 21:26         ` Paul Kocialkowski
2015-12-29 21:55         ` Rob Herring
2015-12-29 21:55           ` Rob Herring
2015-12-29 21:55           ` Rob Herring
2016-02-05 18:48           ` Paul Kocialkowski
2016-02-05 18:48             ` Paul Kocialkowski
2015-12-23 10:58 ` [PATCH 5/6] ARM: LG Optimus Black (P970) codename sniper support, with basic features Paul Kocialkowski
2015-12-23 10:58   ` Paul Kocialkowski
2015-12-23 10:58   ` Paul Kocialkowski
     [not found]   ` <1450868319-20513-6-git-send-email-contact-W9ppeneeCTY@public.gmane.org>
2015-12-23 15:44     ` Tony Lindgren
2015-12-23 15:44       ` Tony Lindgren
2015-12-23 15:44       ` Tony Lindgren
2015-12-24 19:38       ` Paul Kocialkowski
2015-12-24 19:38         ` Paul Kocialkowski
2015-12-23 16:03   ` Javier Martinez Canillas
2015-12-23 16:03     ` Javier Martinez Canillas
     [not found]     ` <CABxcv=moAUEPo8sq5KhuLZChrQtwjF1aBeNvV1i8HvUnwDXMZA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-12-24 19:38       ` Paul Kocialkowski
2015-12-24 19:38         ` Paul Kocialkowski
2015-12-24 19:38         ` Paul Kocialkowski
2015-12-23 10:58 ` [PATCH 6/6] ARM: multi_v7_defconfig: Enable LP872x regulator support Paul Kocialkowski
2015-12-23 10:58   ` Paul Kocialkowski
2015-12-23 10:58   ` Paul Kocialkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151229200244.GA27426@rob-hp-laptop \
    --to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=contact-W9ppeneeCTY@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
    --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
    --cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=milo.kim-l0cyMroinI0@public.gmane.org \
    --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.