From: Sergey Senozhatsky <sergey.senozhatsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Serge E. Hallyn" <serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
Cc: Stephen Rothwell <sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org>,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sergey Senozhatsky
<sergey.senozhatsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
lxc-devel-cunTk1MwBs9qMoObBWhMNEqPaTDuhLve2LY78lusg7I@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org
Subject: Re: [PATCH 6/8] cgroup: mount cgroupns-root when inside non-init cgroupns
Date: Fri, 1 Jan 2016 10:17:03 +0900 [thread overview]
Message-ID: <20160101011703.GA532@swordfish> (raw)
In-Reply-To: <20160101005843.GA26243-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
On (12/31/15 18:58), Serge E. Hallyn wrote:
[..]
> Thanks! Following trivial patch should fix this:
confirmed, thanks!
Tested-by: Sergey Senozhatsky <sergey.senozhatsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
-ss
> From fc54592077533ff2ff90ed54b72bf03b4378ca9f Mon Sep 17 00:00:00 2001
> From: Serge Hallyn <serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
> Date: Thu, 31 Dec 2015 16:55:19 -0800
> Subject: [PATCH 1/1] cgroup_release_agent: grab css_set_lock around
> cgroup_path()
>
> Reported-by: Sergey Senozhatsky <sergey.senozhatsky-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Serge Hallyn <serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
> ---
> kernel/cgroup.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index 4812f59..d10f127 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -5769,7 +5769,9 @@ static void cgroup_release_agent(struct work_struct *work)
> if (!pathbuf || !agentbuf)
> goto out;
>
> + spin_lock_bh(&css_set_lock);
> path = cgroup_path(cgrp, pathbuf, PATH_MAX);
> + spin_unlock_bh(&css_set_lock);
> if (!path)
> goto out;
>
> --
> 2.5.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: "Serge E. Hallyn" <serge.hallyn@ubuntu.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-api@vger.kernel.org, containers@lists.linux-foundation.org,
hannes@cmpxchg.org, linux-kernel@vger.kernel.org,
linux-next@vger.kernel.org, ebiederm@xmission.com,
lxc-devel@lists.linuxcontainers.org, gregkh@linuxfoundation.org,
tj@kernel.org, cgroups@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH 6/8] cgroup: mount cgroupns-root when inside non-init cgroupns
Date: Fri, 1 Jan 2016 10:17:03 +0900 [thread overview]
Message-ID: <20160101011703.GA532@swordfish> (raw)
In-Reply-To: <20160101005843.GA26243@mail.hallyn.com>
On (12/31/15 18:58), Serge E. Hallyn wrote:
[..]
> Thanks! Following trivial patch should fix this:
confirmed, thanks!
Tested-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
> From fc54592077533ff2ff90ed54b72bf03b4378ca9f Mon Sep 17 00:00:00 2001
> From: Serge Hallyn <serge.hallyn@ubuntu.com>
> Date: Thu, 31 Dec 2015 16:55:19 -0800
> Subject: [PATCH 1/1] cgroup_release_agent: grab css_set_lock around
> cgroup_path()
>
> Reported-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
> Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
> ---
> kernel/cgroup.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> index 4812f59..d10f127 100644
> --- a/kernel/cgroup.c
> +++ b/kernel/cgroup.c
> @@ -5769,7 +5769,9 @@ static void cgroup_release_agent(struct work_struct *work)
> if (!pathbuf || !agentbuf)
> goto out;
>
> + spin_lock_bh(&css_set_lock);
> path = cgroup_path(cgrp, pathbuf, PATH_MAX);
> + spin_unlock_bh(&css_set_lock);
> if (!path)
> goto out;
>
> --
> 2.5.0
>
next prev parent reply other threads:[~2016-01-01 1:17 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 4:23 CGroup Namespaces (v8) serge.hallyn
[not found] ` <1450844609-9194-1-git-send-email-serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2015-12-23 4:23 ` [PATCH 1/8] kernfs: Add API to generate relative kernfs path serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2015-12-23 4:23 ` serge.hallyn
[not found] ` <1450844609-9194-2-git-send-email-serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2015-12-23 16:08 ` Tejun Heo
2015-12-23 16:08 ` Tejun Heo
2015-12-23 16:08 ` Tejun Heo
[not found] ` <20151223160854.GF5003-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-12-23 16:36 ` Serge E. Hallyn
2015-12-23 16:36 ` Serge E. Hallyn
2015-12-23 16:36 ` Serge E. Hallyn
2015-12-23 19:33 ` [PATCH 1/8 v8.2] " Serge E. Hallyn
2015-12-23 19:33 ` Serge E. Hallyn
2015-12-23 19:33 ` Serge E. Hallyn
2015-12-23 16:24 ` [PATCH 1/8] " Tejun Heo
2015-12-23 16:24 ` Tejun Heo
2015-12-23 16:24 ` Tejun Heo
[not found] ` <20151223162433.GH5003-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-12-23 16:51 ` Greg KH
2015-12-23 16:51 ` Greg KH
2015-12-23 16:51 ` Greg KH
2015-12-23 4:23 ` [PATCH 2/8] sched: new clone flag CLONE_NEWCGROUP for cgroup namespace serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2015-12-23 4:23 ` serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2015-12-23 4:23 ` serge.hallyn
2015-12-23 4:23 ` [PATCH 3/8] cgroup: introduce cgroup namespaces serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2015-12-23 4:23 ` serge.hallyn
[not found] ` <1450844609-9194-4-git-send-email-serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2015-12-23 16:15 ` Tejun Heo
2015-12-23 16:15 ` Tejun Heo
2015-12-23 16:15 ` Tejun Heo
[not found] ` <20151223161526.GG5003-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-12-23 19:34 ` [PATCH 3/8 v8.2] " Serge E. Hallyn
2015-12-23 19:34 ` Serge E. Hallyn
2015-12-23 19:34 ` Serge E. Hallyn
2015-12-23 4:23 ` [PATCH 4/8] cgroup: cgroup namespace setns support serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2015-12-23 4:23 ` serge.hallyn
2015-12-23 4:23 ` serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2015-12-23 4:23 ` [PATCH 5/8] kernfs: define kernfs_node_dentry serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2015-12-23 4:23 ` serge.hallyn
[not found] ` <1450844609-9194-6-git-send-email-serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2015-12-23 16:25 ` Tejun Heo
2015-12-23 16:25 ` Tejun Heo
[not found] ` <20151223162515.GI5003-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-12-23 16:51 ` Greg KH
2015-12-23 16:51 ` Greg KH
2015-12-23 16:25 ` Tejun Heo
2015-12-23 4:23 ` [PATCH 6/8] cgroup: mount cgroupns-root when inside non-init cgroupns serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2015-12-23 4:23 ` serge.hallyn
[not found] ` <1450844609-9194-7-git-send-email-serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2015-12-31 13:38 ` Sergey Senozhatsky
2015-12-31 13:38 ` Sergey Senozhatsky
2016-01-01 0:58 ` Serge E. Hallyn
2016-01-01 0:58 ` Serge E. Hallyn
2016-01-01 0:58 ` Serge E. Hallyn
[not found] ` <20160101005843.GA26243-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2016-01-01 1:17 ` Sergey Senozhatsky [this message]
2016-01-01 1:17 ` Sergey Senozhatsky
2016-01-01 1:56 ` Tejun Heo
2016-01-01 1:56 ` Tejun Heo
2015-12-23 4:23 ` [PATCH 7/8] cgroup: Add documentation for cgroup namespaces serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2015-12-23 4:23 ` serge.hallyn
[not found] ` <1450844609-9194-8-git-send-email-serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2015-12-28 17:47 ` Tejun Heo
2015-12-28 17:47 ` Tejun Heo
[not found] ` <20151228174735.GB30165-qYNAdHglDFBN0TnZuCh8vA@public.gmane.org>
2015-12-28 21:13 ` Serge Hallyn
2015-12-28 21:13 ` Serge Hallyn
2015-12-28 21:13 ` Serge Hallyn
2015-12-28 21:48 ` [PATCH] " Tejun Heo
2015-12-28 21:48 ` Tejun Heo
2015-12-28 21:48 ` Tejun Heo
2015-12-28 21:48 ` Tejun Heo
2015-12-28 17:47 ` [PATCH 7/8] " Tejun Heo
2015-12-23 4:23 ` [PATCH 8/8] Add FS_USERNS_FLAG to cgroup fs serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2015-12-23 4:23 ` serge.hallyn
2015-12-28 17:46 ` CGroup Namespaces (v8) Tejun Heo
2015-12-28 17:46 ` Tejun Heo
2015-12-28 17:46 ` Tejun Heo
2016-01-01 8:19 ` Dan Williams
2016-01-01 8:19 ` Dan Williams
[not found] ` <CAA9_cmcNeg4vR7Ft8YcPGZtacftDWjC=5mHs2ZRzu9yXoOAJiA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-01 8:59 ` Serge E. Hallyn
2016-01-01 8:59 ` Serge E. Hallyn
2016-01-01 8:59 ` Serge E. Hallyn
[not found] ` <20160101085911.GA28407-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2016-01-01 9:42 ` Dan Williams
2016-01-01 9:42 ` Dan Williams
2016-01-01 9:42 ` Dan Williams
[not found] ` <CAPcyv4iig_sujK=p0TbNjTmtv39N7a0HSqpVe8mLnfX9Es7zNA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-01 18:06 ` Serge E. Hallyn
2016-01-01 18:06 ` Serge E. Hallyn
[not found] ` <20160101180633.GA30941-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2016-01-01 19:14 ` Dan Williams
2016-01-01 19:14 ` Dan Williams
[not found] ` <CAPcyv4iEdP+jMVSFquqCgMiXFgzOSaW40NdG6y2tHRgSKxaOcQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-01-02 11:52 ` Tejun Heo
2016-01-02 11:52 ` Tejun Heo
2016-01-02 11:52 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2016-01-29 8:54 CGroup Namespaces (v10) serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
[not found] ` <1454057651-23959-1-git-send-email-serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2016-01-29 8:54 ` [PATCH 6/8] cgroup: mount cgroupns-root when inside non-init cgroupns serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2016-01-29 8:54 ` serge.hallyn
2016-01-29 8:54 ` serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2016-01-04 19:54 CGroup Namespaces (v9) serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
[not found] ` <1451937294-22589-1-git-send-email-serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2016-01-04 19:54 ` [PATCH 6/8] cgroup: mount cgroupns-root when inside non-init cgroupns serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2016-01-04 19:54 ` serge.hallyn
2015-12-09 19:28 CGroup Namespaces (v7) serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
[not found] ` <1449689341-28742-1-git-send-email-serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org>
2015-12-09 19:28 ` [PATCH 6/8] cgroup: mount cgroupns-root when inside non-init cgroupns serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA
2015-12-09 19:28 ` serge.hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160101011703.GA532@swordfish \
--to=sergey.senozhatsky-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-next-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lxc-devel-cunTk1MwBs9qMoObBWhMNEqPaTDuhLve2LY78lusg7I@public.gmane.org \
--cc=serge.hallyn-GeWIH/nMZzLQT0dZR+AlfA@public.gmane.org \
--cc=sfr-3FnU+UHB4dNDw9hX6IcOSA@public.gmane.org \
--cc=tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.