From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: William Hubbs <w.d.hubbs@gmail.com>,
Chris Brannon <chris@the-brannons.com>,
Kirk Reiser <kirk@reisers.ca>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
speakup@linux-speakup.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: speakup: Fix getting port information
Date: Sun, 3 Jan 2016 01:56:20 +0100 [thread overview]
Message-ID: <20160103005620.GM2860@var.home> (raw)
In-Reply-To: <15457.1451779836@ccs.covici.com>
covici@ccs.covici.com, on Sat 02 Jan 2016 19:10:36 -0500, wrote:
> I had a patch which also worked, but yours may be better -- I enclose it
> here for your information.
Well, it's not up to serialio.h to include things for serialio.c. That
however makes me realize that the culprit is actually
f79b0d9 (which actually doesn't make much sense since linux/serial.h is
getting included a couple of lines above...).
I don't know what this "use <linux/serial.h> instead <asm/serial.h>"
warning is about, but *no* header in include/ includes asm/serial.h, so
there is no way to get the SERIAL_PORT_DFNS definition just by including
linux/serial.h, we really need asm/serial.h, just like 8250*.c do.
So we really need serialio.c to include linux/serial_core.h then
asm/serial.h, as my patch does.
Samuel
next prev parent reply other threads:[~2016-01-03 1:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-02 23:25 [PATCH] Staging: speakup: Fix getting port information Samuel Thibault
2016-01-02 23:49 ` Samuel Thibault
2016-01-03 0:10 ` covici
2016-01-03 0:56 ` Samuel Thibault [this message]
2016-01-03 1:31 ` covici
2016-01-04 12:22 ` Dan Carpenter
2016-01-04 12:26 ` Dan Carpenter
2016-01-04 12:20 ` Dan Carpenter
2016-01-05 1:14 ` Samuel Thibault
-- strict thread matches above, loose matches on Subject: below --
2016-01-05 1:19 Samuel Thibault
2016-01-05 9:36 ` Dan Carpenter
2016-01-14 23:47 Samuel Thibault
2016-01-15 5:59 ` Dan Carpenter
2016-01-25 0:29 ` Samuel Thibault
2016-01-25 2:52 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160103005620.GM2860@var.home \
--to=samuel.thibault@ens-lyon.org \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.