From: Dan Carpenter <dan.carpenter@oracle.com>
To: Samuel Thibault <samuel.thibault@ens-lyon.org>,
William Hubbs <w.d.hubbs@gmail.com>,
Chris Brannon <chris@the-brannons.com>,
Kirk Reiser <kirk@reisers.ca>,
Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
speakup@linux-speakup.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: speakup: Fix getting port information
Date: Tue, 5 Jan 2016 12:36:39 +0300 [thread overview]
Message-ID: <20160105093638.GA23363@mwanda> (raw)
In-Reply-To: <20160105011912.GM3232@var.home>
On Tue, Jan 05, 2016 at 02:19:12AM +0100, Samuel Thibault wrote:
> --- a/drivers/staging/speakup/serialio.c
> +++ b/drivers/staging/speakup/serialio.c
> @@ -6,6 +6,9 @@
> #include "spk_priv.h"
> #include "serialio.h"
>
> +#include <linux/serial_core.h>
> +#include <asm/serial.h>
> +
I'm sorry to do this but can you add a comment here, otherwise someone
is going to just change it back because it causes a checkpatch.pl
warning. Make it a big ugly warning.
#include <linux/serial_core.h>
/* WARNING: Do not change this to <linux/serial.h> without testing. */
#include <asm/serial.h>
regards,
dan carpenter
next prev parent reply other threads:[~2016-01-05 9:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 1:19 [PATCH] Staging: speakup: Fix getting port information Samuel Thibault
2016-01-05 9:36 ` Dan Carpenter [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-01-14 23:47 Samuel Thibault
2016-01-15 5:59 ` Dan Carpenter
2016-01-25 0:29 ` Samuel Thibault
2016-01-25 2:52 ` Greg Kroah-Hartman
2016-01-02 23:25 Samuel Thibault
2016-01-02 23:49 ` Samuel Thibault
2016-01-03 0:10 ` covici
2016-01-03 0:56 ` Samuel Thibault
2016-01-03 1:31 ` covici
2016-01-04 12:22 ` Dan Carpenter
2016-01-04 12:26 ` Dan Carpenter
2016-01-04 12:20 ` Dan Carpenter
2016-01-05 1:14 ` Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105093638.GA23363@mwanda \
--to=dan.carpenter@oracle.com \
--cc=aysemelikeyurtoglu@gmail.com \
--cc=chris@the-brannons.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kirk@reisers.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=speakup@linux-speakup.org \
--cc=w.d.hubbs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.