All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] tests/kms-steal-crtc: Include sys/select.h
Date: Mon, 4 Jan 2016 09:38:30 +0100	[thread overview]
Message-ID: <20160104083830.GF23797@ulmo> (raw)
In-Reply-To: <1451461915-112672-1-git-send-email-raj.khem@gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 747 bytes --]

On Wed, Dec 30, 2015 at 07:51:55AM +0000, Khem Raj wrote:
> Fixes errors e.g.
> 
> error: implicit declaration of function 'select'
> 
> and missing definitions of FD_* defines
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  tests/kms/kms-steal-crtc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms/kms-steal-crtc.c b/tests/kms/kms-steal-crtc.c
> index 2f7f327..24d70ab 100644
> --- a/tests/kms/kms-steal-crtc.c
> +++ b/tests/kms/kms-steal-crtc.c
> @@ -31,6 +31,7 @@
>  #include <stdio.h>
>  #include <string.h>
>  #include <unistd.h>
> +#include <sys/select.h>

This must be pulled in some other way on my system, but this looks
correct:

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-01-04  8:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-30  7:51 [PATCH] tests/kms-steal-crtc: Include sys/select.h Khem Raj
2016-01-04  8:38 ` Thierry Reding [this message]
2016-01-04  9:15   ` Emil Velikov
  -- strict thread matches above, loose matches on Subject: below --
2015-12-29 22:21 Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160104083830.GF23797@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=raj.khem@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.