[PATCH] tests/kms-steal-crtc: Include sys/select.h

[PATCH] tests/kms-steal-crtc: Include sys/select.h

[Khem Raj]

Fixes errors e.g.

error: implicit declaration of function 'select'

and missing definitions of FD_* defines

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 tests/kms/kms-steal-crtc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms/kms-steal-crtc.c b/tests/kms/kms-steal-crtc.c
index 2f7f327..24d70ab 100644
--- a/tests/kms/kms-steal-crtc.c
+++ b/tests/kms/kms-steal-crtc.c
@@ -31,6 +31,7 @@
 #include <stdio.h>
 #include <string.h>
 #include <unistd.h>
+#include <sys/select.h>
 
 #include <drm_fourcc.h>
 
-- 
2.6.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH] tests/kms-steal-crtc: Include sys/select.h

[Khem Raj]

Fixes errors e.g.

error: implicit declaration of function 'select'

and missing definitions of FD_* defines

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 tests/kms/kms-steal-crtc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/kms/kms-steal-crtc.c b/tests/kms/kms-steal-crtc.c
index 2f7f327..24d70ab 100644
--- a/tests/kms/kms-steal-crtc.c
+++ b/tests/kms/kms-steal-crtc.c
@@ -31,6 +31,7 @@
 #include <stdio.h>
 #include <string.h>
 #include <unistd.h>
+#include <sys/select.h>
 
 #include <drm_fourcc.h>
 
-- 
2.6.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] tests/kms-steal-crtc: Include sys/select.h

[Thierry Reding]

[-- Attachment #1.1: Type: text/plain, Size: 747 bytes --]

On Wed, Dec 30, 2015 at 07:51:55AM +0000, Khem Raj wrote:
> Fixes errors e.g.
> 
> error: implicit declaration of function 'select'
> 
> and missing definitions of FD_* defines
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>  tests/kms/kms-steal-crtc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/kms/kms-steal-crtc.c b/tests/kms/kms-steal-crtc.c
> index 2f7f327..24d70ab 100644
> --- a/tests/kms/kms-steal-crtc.c
> +++ b/tests/kms/kms-steal-crtc.c
> @@ -31,6 +31,7 @@
>  #include <stdio.h>
>  #include <string.h>
>  #include <unistd.h>
> +#include <sys/select.h>

This must be pulled in some other way on my system, but this looks
correct:

Reviewed-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] tests/kms-steal-crtc: Include sys/select.h

[Emil Velikov]

On 4 January 2016 at 08:38, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Wed, Dec 30, 2015 at 07:51:55AM +0000, Khem Raj wrote:
>> Fixes errors e.g.
>>
>> error: implicit declaration of function 'select'
>>
>> and missing definitions of FD_* defines
>>
>> Signed-off-by: Khem Raj <raj.khem@gmail.com>
>> ---
>>  tests/kms/kms-steal-crtc.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/tests/kms/kms-steal-crtc.c b/tests/kms/kms-steal-crtc.c
>> index 2f7f327..24d70ab 100644
>> --- a/tests/kms/kms-steal-crtc.c
>> +++ b/tests/kms/kms-steal-crtc.c
>> @@ -31,6 +31,7 @@
>>  #include <stdio.h>
>>  #include <string.h>
>>  #include <unistd.h>
>> +#include <sys/select.h>
>
> This must be pulled in some other way on my system, but this looks
> correct:
>
The above header is required/used in compliance with POSIX 2001/2008.
Earlier standards use the below three.

#include <sys/time.h>
#include <sys/types.h>
#include <unistd.h>

I'm not sure how much we should care about platforms non-compliant to
POSIX 2001... although adding the header check seems pretty trivial.
Add the new one in the list at configure.ac:AC_CHECK_HEADERS and wrap
the include in a ifdef guard.

From a quick grep there are a few other users of select()

tests/kms/kms-steal-crtc.c
tests/kms/kms-universal-planes.c
tests/modetest/modetest.c
tests/vbltest/vbltest.c


Raj, can you update the patch to handle the lot (one patch should be ok imho) ?

Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel