All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luck, Tony" <tony.luck@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Will Deacon <will.deacon@arm.com>,
	"linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
	"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>,
	"schwidefsky@de.ibm.com" <schwidefsky@de.ibm.com>,
	"mattst88@gmail.com" <mattst88@gmail.com>,
	"ink@jurassic.park.msu.ru" <ink@jurassic.park.msu.ru>,
	"rth@twiddle.net" <rth@twiddle.net>,
	"Yu, Fenghua" <fenghua.yu@intel.com>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"akpm@linux-foundation.org" <akpm@linux-founda>
Subject: Re: [PATCH 6/6] arm64: switch to relative exception tables
Date: Mon, 4 Jan 2016 11:49:26 -0800	[thread overview]
Message-ID: <20160104194925.GA19213@agluck-desk.sc.intel.com> (raw)
In-Reply-To: <CAKv+Gu-n70=Kdf2NtygzYxEURO+Dnk1cmMX6D3gmXQ1E5-PHUA@mail.gmail.com>

On Mon, Jan 04, 2016 at 08:28:52PM +0100, Ard Biesheuvel wrote:
> On 4 January 2016 at 20:21, H. Peter Anvin <hpa@zytor.com> wrote:
> > I suspect that means we will also need to go back to arch-specific
> > sorting for x86.
> >
> 
> AFAICT, Tony's patches are not incompatible with mine. The fixup
> address is offset with a large constant, but this does not affect the
> sort order (since that is based on the other member), and the swap
> operation that adds/subtracts the delta should not care about the
> class bits. (I don't see any changes to sort_extable() in Tony's
> patch)

Correct. Sorting is by the "insn" field (which I did not change).
The "fixup" field is just modified by an offset value, so survives
the math when moved to a new slot by the sort.

> @Tony: any comments? And do you have any objections to the ia64 patch
> in this series?
The ia64 bits look OK. I haven't tested, but add my Acked-by: anyway.

-Tony

WARNING: multiple messages have this Message-ID (diff)
From: "Luck, Tony" <tony.luck@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Will Deacon <will.deacon@arm.com>,
	"linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
	"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>,
	"schwidefsky@de.ibm.com" <schwidefsky@de.ibm.com>,
	"mattst88@gmail.com" <mattst88@gmail.com>,
	"ink@jurassic.park.msu.ru" <ink@jurassic.park.msu.ru>,
	"rth@twiddle.net" <rth@twiddle.net>,
	"Yu, Fenghua" <fenghua.yu@intel.com>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"marc.zyngier@arm.com" <marc.zyngier@arm.com>
Subject: Re: [PATCH 6/6] arm64: switch to relative exception tables
Date: Mon, 04 Jan 2016 19:49:26 +0000	[thread overview]
Message-ID: <20160104194925.GA19213@agluck-desk.sc.intel.com> (raw)
In-Reply-To: <CAKv+Gu-n70=Kdf2NtygzYxEURO+Dnk1cmMX6D3gmXQ1E5-PHUA@mail.gmail.com>

On Mon, Jan 04, 2016 at 08:28:52PM +0100, Ard Biesheuvel wrote:
> On 4 January 2016 at 20:21, H. Peter Anvin <hpa@zytor.com> wrote:
> > I suspect that means we will also need to go back to arch-specific
> > sorting for x86.
> >
> 
> AFAICT, Tony's patches are not incompatible with mine. The fixup
> address is offset with a large constant, but this does not affect the
> sort order (since that is based on the other member), and the swap
> operation that adds/subtracts the delta should not care about the
> class bits. (I don't see any changes to sort_extable() in Tony's
> patch)

Correct. Sorting is by the "insn" field (which I did not change).
The "fixup" field is just modified by an offset value, so survives
the math when moved to a new slot by the sort.

> @Tony: any comments? And do you have any objections to the ia64 patch
> in this series?
The ia64 bits look OK. I haven't tested, but add my Acked-by: anyway.

-Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony.luck@intel.com (Luck, Tony)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/6] arm64: switch to relative exception tables
Date: Mon, 4 Jan 2016 11:49:26 -0800	[thread overview]
Message-ID: <20160104194925.GA19213@agluck-desk.sc.intel.com> (raw)
In-Reply-To: <CAKv+Gu-n70=Kdf2NtygzYxEURO+Dnk1cmMX6D3gmXQ1E5-PHUA@mail.gmail.com>

On Mon, Jan 04, 2016 at 08:28:52PM +0100, Ard Biesheuvel wrote:
> On 4 January 2016 at 20:21, H. Peter Anvin <hpa@zytor.com> wrote:
> > I suspect that means we will also need to go back to arch-specific
> > sorting for x86.
> >
> 
> AFAICT, Tony's patches are not incompatible with mine. The fixup
> address is offset with a large constant, but this does not affect the
> sort order (since that is based on the other member), and the swap
> operation that adds/subtracts the delta should not care about the
> class bits. (I don't see any changes to sort_extable() in Tony's
> patch)

Correct. Sorting is by the "insn" field (which I did not change).
The "fixup" field is just modified by an offset value, so survives
the math when moved to a new slot by the sort.

> @Tony: any comments? And do you have any objections to the ia64 patch
> in this series?
The ia64 bits look OK. I haven't tested, but add my Acked-by: anyway.

-Tony

WARNING: multiple messages have this Message-ID (diff)
From: "Luck, Tony" <tony.luck@intel.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Will Deacon <will.deacon@arm.com>,
	"linux-alpha@vger.kernel.org" <linux-alpha@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-ia64@vger.kernel.org" <linux-ia64@vger.kernel.org>,
	"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>,
	"schwidefsky@de.ibm.com" <schwidefsky@de.ibm.com>,
	"mattst88@gmail.com" <mattst88@gmail.com>,
	"ink@jurassic.park.msu.ru" <ink@jurassic.park.msu.ru>,
	"rth@twiddle.net" <rth@twiddle.net>,
	"Yu, Fenghua" <fenghua.yu@intel.com>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"arnd@arndb.de" <arnd@arndb.de>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"marc.zyngier@arm.com" <marc.zyngier@arm.com>
Subject: Re: [PATCH 6/6] arm64: switch to relative exception tables
Date: Mon, 4 Jan 2016 11:49:26 -0800	[thread overview]
Message-ID: <20160104194925.GA19213@agluck-desk.sc.intel.com> (raw)
In-Reply-To: <CAKv+Gu-n70=Kdf2NtygzYxEURO+Dnk1cmMX6D3gmXQ1E5-PHUA@mail.gmail.com>

On Mon, Jan 04, 2016 at 08:28:52PM +0100, Ard Biesheuvel wrote:
> On 4 January 2016 at 20:21, H. Peter Anvin <hpa@zytor.com> wrote:
> > I suspect that means we will also need to go back to arch-specific
> > sorting for x86.
> >
> 
> AFAICT, Tony's patches are not incompatible with mine. The fixup
> address is offset with a large constant, but this does not affect the
> sort order (since that is based on the other member), and the swap
> operation that adds/subtracts the delta should not care about the
> class bits. (I don't see any changes to sort_extable() in Tony's
> patch)

Correct. Sorting is by the "insn" field (which I did not change).
The "fixup" field is just modified by an offset value, so survives
the math when moved to a new slot by the sort.

> @Tony: any comments? And do you have any objections to the ia64 patch
> in this series?
The ia64 bits look OK. I haven't tested, but add my Acked-by: anyway.

-Tony

  reply	other threads:[~2016-01-04 19:49 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-03 16:05 [PATCH 0/6] generic relative extable support Ard Biesheuvel
2016-01-03 16:05 ` Ard Biesheuvel
2016-01-03 16:05 ` Ard Biesheuvel
2016-01-03 16:05 ` [PATCH 1/6] extable: add support for relative extables to search and sort routines Ard Biesheuvel
2016-01-03 16:05   ` Ard Biesheuvel
2016-01-03 16:05   ` Ard Biesheuvel
2016-01-04 21:05   ` Helge Deller
2016-01-04 21:05     ` Helge Deller
2016-01-04 21:05     ` Helge Deller
2016-01-03 16:05 ` [PATCH 2/6] alpha/extable: use generic " Ard Biesheuvel
2016-01-03 16:05   ` Ard Biesheuvel
2016-01-03 16:05   ` Ard Biesheuvel
2016-01-03 16:05 ` [PATCH 3/6] s390/extable: " Ard Biesheuvel
2016-01-03 16:05   ` Ard Biesheuvel
2016-01-03 16:05   ` Ard Biesheuvel
2016-01-03 16:05 ` [PATCH 4/6] x86/extable: " Ard Biesheuvel
2016-01-03 16:05   ` Ard Biesheuvel
2016-01-03 16:05   ` Ard Biesheuvel
2016-01-03 16:05 ` [PATCH 5/6] ia64/extable: " Ard Biesheuvel
2016-01-03 16:05   ` Ard Biesheuvel
2016-01-03 16:05   ` Ard Biesheuvel
2016-01-03 16:05 ` [PATCH 6/6] arm64: switch to relative exception tables Ard Biesheuvel
2016-01-03 16:05   ` Ard Biesheuvel
2016-01-03 16:05   ` Ard Biesheuvel
2016-01-04 14:46   ` Will Deacon
2016-01-04 14:46     ` Will Deacon
2016-01-04 14:46     ` Will Deacon
2016-01-04 18:13     ` H. Peter Anvin
2016-01-04 18:13       ` H. Peter Anvin
2016-01-04 18:13       ` H. Peter Anvin
2016-01-04 18:20       ` Luck, Tony
2016-01-04 18:20         ` Luck, Tony
2016-01-04 18:20         ` Luck, Tony
2016-01-04 18:20         ` Luck, Tony
2016-01-04 18:47         ` H. Peter Anvin
2016-01-04 18:47           ` H. Peter Anvin
2016-01-04 18:47           ` H. Peter Anvin
2016-01-04 18:47           ` H. Peter Anvin
2016-01-04 19:21         ` H. Peter Anvin
2016-01-04 19:21           ` H. Peter Anvin
2016-01-04 19:21           ` H. Peter Anvin
2016-01-04 19:21           ` H. Peter Anvin
2016-01-04 19:28           ` Ard Biesheuvel
2016-01-04 19:28             ` Ard Biesheuvel
2016-01-04 19:28             ` Ard Biesheuvel
2016-01-04 19:28             ` Ard Biesheuvel
2016-01-04 19:49             ` Luck, Tony [this message]
2016-01-04 19:49               ` Luck, Tony
2016-01-04 19:49               ` Luck, Tony
2016-01-04 19:49               ` Luck, Tony
2016-01-04 11:20 ` [PATCH 0/6] generic relative extable support Heiko Carstens
2016-01-04 11:20   ` Heiko Carstens
2016-01-04 11:20   ` Heiko Carstens
2016-01-04 18:15   ` H. Peter Anvin
2016-01-04 18:15     ` H. Peter Anvin
2016-01-04 18:15     ` H. Peter Anvin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160104194925.GA19213@agluck-desk.sc.intel.com \
    --to=tony.luck@intel.com \
    --cc=akpm@linux-founda \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=fenghua.yu@intel.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=hpa@zytor.com \
    --cc=ink@jurassic.park.msu.ru \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=mingo@redhat.com \
    --cc=rth@twiddle.net \
    --cc=schwidefsky@de.ibm.com \
    --cc=will.deacon@arm.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.