* [patch] drm/amdgpu/cgs: cleanup some indenting
@ 2016-01-04 20:43 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-01-04 20:43 UTC (permalink / raw)
To: David Airlie
Cc: Jammy Zhou, kernel-janitors, linux-kernel, dri-devel, Eric Huang,
Alex Deucher, Rex Zhu, Christian König
This code is indented too far. Also we normally use spaces to align if
statement conditions.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
index 6fa0fea..59485d0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
@@ -843,15 +843,15 @@ static int amdgpu_cgs_acpi_eval_object(void *cgs_device,
if (info->input_count > 0) {
if (info->pinput_argument = NULL)
return -EINVAL;
- argument = info->pinput_argument;
- func_no = argument->value;
- for (i = 0; i < info->input_count; i++) {
- if (((argument->type = ACPI_TYPE_STRING) ||
- (argument->type = ACPI_TYPE_BUFFER))
- && (argument->pointer = NULL))
- return -EINVAL;
- argument++;
- }
+ argument = info->pinput_argument;
+ func_no = argument->value;
+ for (i = 0; i < info->input_count; i++) {
+ if (((argument->type = ACPI_TYPE_STRING) ||
+ (argument->type = ACPI_TYPE_BUFFER)) &&
+ (argument->pointer = NULL))
+ return -EINVAL;
+ argument++;
+ }
}
if (info->output_count > 0) {
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] drm/amdgpu/cgs: cleanup some indenting
@ 2016-01-04 20:43 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-01-04 20:43 UTC (permalink / raw)
To: David Airlie
Cc: Alex Deucher, Jammy Zhou, Chunming Zhou, Rex Zhu,
Christian König, Eric Huang, dri-devel, linux-kernel,
kernel-janitors
This code is indented too far. Also we normally use spaces to align if
statement conditions.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
index 6fa0fea..59485d0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
@@ -843,15 +843,15 @@ static int amdgpu_cgs_acpi_eval_object(void *cgs_device,
if (info->input_count > 0) {
if (info->pinput_argument == NULL)
return -EINVAL;
- argument = info->pinput_argument;
- func_no = argument->value;
- for (i = 0; i < info->input_count; i++) {
- if (((argument->type == ACPI_TYPE_STRING) ||
- (argument->type == ACPI_TYPE_BUFFER))
- && (argument->pointer == NULL))
- return -EINVAL;
- argument++;
- }
+ argument = info->pinput_argument;
+ func_no = argument->value;
+ for (i = 0; i < info->input_count; i++) {
+ if (((argument->type == ACPI_TYPE_STRING) ||
+ (argument->type == ACPI_TYPE_BUFFER)) &&
+ (argument->pointer == NULL))
+ return -EINVAL;
+ argument++;
+ }
}
if (info->output_count > 0) {
^ permalink raw reply related [flat|nested] 6+ messages in thread* [patch] drm/amdgpu/cgs: cleanup some indenting
@ 2016-01-04 20:43 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-01-04 20:43 UTC (permalink / raw)
To: David Airlie
Cc: Jammy Zhou, kernel-janitors, linux-kernel, dri-devel, Eric Huang,
Alex Deucher, Rex Zhu, Christian König
This code is indented too far. Also we normally use spaces to align if
statement conditions.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
index 6fa0fea..59485d0 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
@@ -843,15 +843,15 @@ static int amdgpu_cgs_acpi_eval_object(void *cgs_device,
if (info->input_count > 0) {
if (info->pinput_argument == NULL)
return -EINVAL;
- argument = info->pinput_argument;
- func_no = argument->value;
- for (i = 0; i < info->input_count; i++) {
- if (((argument->type == ACPI_TYPE_STRING) ||
- (argument->type == ACPI_TYPE_BUFFER))
- && (argument->pointer == NULL))
- return -EINVAL;
- argument++;
- }
+ argument = info->pinput_argument;
+ func_no = argument->value;
+ for (i = 0; i < info->input_count; i++) {
+ if (((argument->type == ACPI_TYPE_STRING) ||
+ (argument->type == ACPI_TYPE_BUFFER)) &&
+ (argument->pointer == NULL))
+ return -EINVAL;
+ argument++;
+ }
}
if (info->output_count > 0) {
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [patch] drm/amdgpu/cgs: cleanup some indenting
2016-01-04 20:43 ` Dan Carpenter
(?)
@ 2016-01-04 21:19 ` Alex Deucher
-1 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2016-01-04 21:19 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jammy Zhou, kernel-janitors, LKML, Maling list - DRI developers,
Alex Deucher, Eric Huang, Rex Zhu, Christian König
On Mon, Jan 4, 2016 at 3:43 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This code is indented too far. Also we normally use spaces to align if
> statement conditions.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied. thanks!
Alex
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> index 6fa0fea..59485d0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> @@ -843,15 +843,15 @@ static int amdgpu_cgs_acpi_eval_object(void *cgs_device,
> if (info->input_count > 0) {
> if (info->pinput_argument = NULL)
> return -EINVAL;
> - argument = info->pinput_argument;
> - func_no = argument->value;
> - for (i = 0; i < info->input_count; i++) {
> - if (((argument->type = ACPI_TYPE_STRING) ||
> - (argument->type = ACPI_TYPE_BUFFER))
> - && (argument->pointer = NULL))
> - return -EINVAL;
> - argument++;
> - }
> + argument = info->pinput_argument;
> + func_no = argument->value;
> + for (i = 0; i < info->input_count; i++) {
> + if (((argument->type = ACPI_TYPE_STRING) ||
> + (argument->type = ACPI_TYPE_BUFFER)) &&
> + (argument->pointer = NULL))
> + return -EINVAL;
> + argument++;
> + }
> }
>
> if (info->output_count > 0) {
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] drm/amdgpu/cgs: cleanup some indenting
@ 2016-01-04 21:19 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2016-01-04 21:19 UTC (permalink / raw)
To: Dan Carpenter
Cc: David Airlie, Jammy Zhou, kernel-janitors, LKML,
Maling list - DRI developers, Eric Huang, Alex Deucher, Rex Zhu,
Christian König
On Mon, Jan 4, 2016 at 3:43 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This code is indented too far. Also we normally use spaces to align if
> statement conditions.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied. thanks!
Alex
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> index 6fa0fea..59485d0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> @@ -843,15 +843,15 @@ static int amdgpu_cgs_acpi_eval_object(void *cgs_device,
> if (info->input_count > 0) {
> if (info->pinput_argument == NULL)
> return -EINVAL;
> - argument = info->pinput_argument;
> - func_no = argument->value;
> - for (i = 0; i < info->input_count; i++) {
> - if (((argument->type == ACPI_TYPE_STRING) ||
> - (argument->type == ACPI_TYPE_BUFFER))
> - && (argument->pointer == NULL))
> - return -EINVAL;
> - argument++;
> - }
> + argument = info->pinput_argument;
> + func_no = argument->value;
> + for (i = 0; i < info->input_count; i++) {
> + if (((argument->type == ACPI_TYPE_STRING) ||
> + (argument->type == ACPI_TYPE_BUFFER)) &&
> + (argument->pointer == NULL))
> + return -EINVAL;
> + argument++;
> + }
> }
>
> if (info->output_count > 0) {
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [patch] drm/amdgpu/cgs: cleanup some indenting
@ 2016-01-04 21:19 ` Alex Deucher
0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2016-01-04 21:19 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jammy Zhou, kernel-janitors, LKML, Maling list - DRI developers,
Alex Deucher, Eric Huang, Rex Zhu, Christian König
On Mon, Jan 4, 2016 at 3:43 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> This code is indented too far. Also we normally use spaces to align if
> statement conditions.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied. thanks!
Alex
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> index 6fa0fea..59485d0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c
> @@ -843,15 +843,15 @@ static int amdgpu_cgs_acpi_eval_object(void *cgs_device,
> if (info->input_count > 0) {
> if (info->pinput_argument == NULL)
> return -EINVAL;
> - argument = info->pinput_argument;
> - func_no = argument->value;
> - for (i = 0; i < info->input_count; i++) {
> - if (((argument->type == ACPI_TYPE_STRING) ||
> - (argument->type == ACPI_TYPE_BUFFER))
> - && (argument->pointer == NULL))
> - return -EINVAL;
> - argument++;
> - }
> + argument = info->pinput_argument;
> + func_no = argument->value;
> + for (i = 0; i < info->input_count; i++) {
> + if (((argument->type == ACPI_TYPE_STRING) ||
> + (argument->type == ACPI_TYPE_BUFFER)) &&
> + (argument->pointer == NULL))
> + return -EINVAL;
> + argument++;
> + }
> }
>
> if (info->output_count > 0) {
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-04 21:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-04 20:43 [patch] drm/amdgpu/cgs: cleanup some indenting Dan Carpenter
2016-01-04 20:43 ` Dan Carpenter
2016-01-04 20:43 ` Dan Carpenter
2016-01-04 21:19 ` Alex Deucher
2016-01-04 21:19 ` Alex Deucher
2016-01-04 21:19 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.