From: Andrew Morton <akpm@linux-foundation.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Mark Brown <broonie@kernel.org>,
Taku Izumi <izumi.taku@jp.fujitsu.com>,
Tony Luck <tony.luck@intel.com>, Mel Gorman <mel@csn.ul.ie>,
Xishi Qiu <qiuxishi@huawei.com>,
Dave Hansen <dave.hansen@intel.com>,
Matt Fleming <matt@codeblueprint.co.uk>,
Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
kernel-build-reports@lists.linaro.org,
linux-next@vger.kernel.org, Kevin.Hilman@linaro.org,
Tyler.Baker@linaro.org, linux-arm-kernel@lists.infradead.org,
Russell King <linux@arm.linux.org.uk>
Subject: Re: Widespread boot failures on ARM due to "mm/page_alloc.c: calculate zone_start_pfn at zone_spanned_pages_in_node()"
Date: Mon, 4 Jan 2016 21:49:44 -0800 [thread overview]
Message-ID: <20160104214944.8cafbcef.akpm@linux-foundation.org> (raw)
In-Reply-To: <20160105164716.44b9db6d@canb.auug.org.au>
On Tue, 5 Jan 2016 16:47:16 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Andrew,
>
> On Tue, 5 Jan 2016 11:49:18 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Mon, 4 Jan 2016 16:35:28 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
> > >
> > > Stephen, can we please retain
> > >
> > > mm-calculate-zone_start_pfn-at-zone_spanned_pages_in_node.patch
> > > mm-introduce-kernelcore=mirror-option.patch
> > > mm-introduce-kernelcore=mirror-option-fix.patch
> > > mm-introduce-kernelcore=mirror-option-fix-2.patch
> > >
> > > and add the below?
> >
> > Sure, that is easier than dropping the above patches, anyway.
>
> I have done that *except* that
> mm-introduce-kernelcore=mirror-option-fix-2.patch is not in mmotm and I
> cannot find it anywhere.
oops sorry, I took it out so it isn't in today's
http://ozlabs.org/~akpm/mmots/broken-out/. Here:
From: Arnd Bergmann <arnd@arndb.de>
Subject: mm: avoid unused variables in memmap_init_zone
A quick fix on mm/page_alloc.c introduced a harmless warning:
mm/page_alloc.c: In function 'memmap_init_zone':
mm/page_alloc.c:4617:44: warning: unused variable 'tmp' [-Wunused-variable]
mm/page_alloc.c:4617:26: warning: unused variable 'r' [-Wunused-variable]
This uses another #ifdef to avoid declaring the two variables when the
code is not built.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Taku Izumi <izumi.taku@jp.fujitsu.com>
Cc: Tony Luck <tony.luck@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/page_alloc.c | 2 ++
1 file changed, 2 insertions(+)
diff -puN mm/page_alloc.c~mm-introduce-kernelcore=mirror-option-fix-2 mm/page_alloc.c
--- a/mm/page_alloc.c~mm-introduce-kernelcore=mirror-option-fix-2
+++ a/mm/page_alloc.c
@@ -4465,7 +4465,9 @@ void __meminit memmap_init_zone(unsigned
unsigned long pfn;
struct zone *z;
unsigned long nr_initialised = 0;
+#ifdef CONFIG_HAVE_MEMBLOCK_NODE_MAP
struct memblock_region *r = NULL, *tmp;
+#endif
if (highest_memmap_pfn < end_pfn - 1)
highest_memmap_pfn = end_pfn - 1;
_
WARNING: multiple messages have this Message-ID (diff)
From: akpm@linux-foundation.org (Andrew Morton)
To: linux-arm-kernel@lists.infradead.org
Subject: Widespread boot failures on ARM due to "mm/page_alloc.c: calculate zone_start_pfn at zone_spanned_pages_in_node()"
Date: Mon, 4 Jan 2016 21:49:44 -0800 [thread overview]
Message-ID: <20160104214944.8cafbcef.akpm@linux-foundation.org> (raw)
In-Reply-To: <20160105164716.44b9db6d@canb.auug.org.au>
On Tue, 5 Jan 2016 16:47:16 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> Hi Andrew,
>
> On Tue, 5 Jan 2016 11:49:18 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > On Mon, 4 Jan 2016 16:35:28 -0800 Andrew Morton <akpm@linux-foundation.org> wrote:
> > >
> > > Stephen, can we please retain
> > >
> > > mm-calculate-zone_start_pfn-at-zone_spanned_pages_in_node.patch
> > > mm-introduce-kernelcore=mirror-option.patch
> > > mm-introduce-kernelcore=mirror-option-fix.patch
> > > mm-introduce-kernelcore=mirror-option-fix-2.patch
> > >
> > > and add the below?
> >
> > Sure, that is easier than dropping the above patches, anyway.
>
> I have done that *except* that
> mm-introduce-kernelcore=mirror-option-fix-2.patch is not in mmotm and I
> cannot find it anywhere.
oops sorry, I took it out so it isn't in today's
http://ozlabs.org/~akpm/mmots/broken-out/. Here:
From: Arnd Bergmann <arnd@arndb.de>
Subject: mm: avoid unused variables in memmap_init_zone
A quick fix on mm/page_alloc.c introduced a harmless warning:
mm/page_alloc.c: In function 'memmap_init_zone':
mm/page_alloc.c:4617:44: warning: unused variable 'tmp' [-Wunused-variable]
mm/page_alloc.c:4617:26: warning: unused variable 'r' [-Wunused-variable]
This uses another #ifdef to avoid declaring the two variables when the
code is not built.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Taku Izumi <izumi.taku@jp.fujitsu.com>
Cc: Tony Luck <tony.luck@intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/page_alloc.c | 2 ++
1 file changed, 2 insertions(+)
diff -puN mm/page_alloc.c~mm-introduce-kernelcore=mirror-option-fix-2 mm/page_alloc.c
--- a/mm/page_alloc.c~mm-introduce-kernelcore=mirror-option-fix-2
+++ a/mm/page_alloc.c
@@ -4465,7 +4465,9 @@ void __meminit memmap_init_zone(unsigned
unsigned long pfn;
struct zone *z;
unsigned long nr_initialised = 0;
+#ifdef CONFIG_HAVE_MEMBLOCK_NODE_MAP
struct memblock_region *r = NULL, *tmp;
+#endif
if (highest_memmap_pfn < end_pfn - 1)
highest_memmap_pfn = end_pfn - 1;
_
next prev parent reply other threads:[~2016-01-05 5:49 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 22:42 Widespread boot failures on ARM due to "mm/page_alloc.c: calculate zone_start_pfn at zone_spanned_pages_in_node()" Mark Brown
2016-01-04 22:42 ` Mark Brown
2016-01-04 23:09 ` Andrew Morton
2016-01-04 23:09 ` Andrew Morton
2016-01-04 23:55 ` Mark Brown
2016-01-04 23:55 ` Mark Brown
2016-01-05 0:35 ` Andrew Morton
2016-01-05 0:35 ` Andrew Morton
2016-01-05 0:49 ` Stephen Rothwell
2016-01-05 0:49 ` Stephen Rothwell
2016-01-05 5:47 ` Stephen Rothwell
2016-01-05 5:47 ` Stephen Rothwell
2016-01-05 5:49 ` Andrew Morton [this message]
2016-01-05 5:49 ` Andrew Morton
2016-01-05 11:45 ` Mark Brown
2016-01-05 11:45 ` Mark Brown
2016-01-05 12:21 ` Sudeep Holla
2016-01-05 12:21 ` Sudeep Holla
2016-01-05 19:24 ` Mark Brown
2016-01-05 19:24 ` Mark Brown
2016-01-05 19:59 ` Steve Capper
2016-01-05 19:59 ` Steve Capper
2016-01-06 10:32 ` Sudeep Holla
2016-01-06 10:32 ` Sudeep Holla
2016-01-06 15:56 ` Steve Capper
2016-01-06 15:56 ` Steve Capper
2016-01-06 0:22 ` Guenter Roeck
2016-01-06 0:22 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160104214944.8cafbcef.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Kevin.Hilman@linaro.org \
--cc=Tyler.Baker@linaro.org \
--cc=broonie@kernel.org \
--cc=dave.hansen@intel.com \
--cc=izumi.taku@jp.fujitsu.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kernel-build-reports@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-next@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=matt@codeblueprint.co.uk \
--cc=mel@csn.ul.ie \
--cc=qiuxishi@huawei.com \
--cc=sfr@canb.auug.org.au \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.