From: Rabin Vincent <rabin@rab.in>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
daniel@iogearbox.net, ast@kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org,
linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X
Date: Tue, 5 Jan 2016 17:03:45 +0100 [thread overview]
Message-ID: <20160105160345.GA3951@debian> (raw)
In-Reply-To: <1452009645.8255.96.camel@edumazet-glaptop2.roam.corp.google.com>
On Tue, Jan 05, 2016 at 08:00:45AM -0800, Eric Dumazet wrote:
> On Tue, 2016-01-05 at 16:23 +0100, Rabin Vincent wrote:
> > The SKF_AD_ALU_XOR_X ancillary is not like the other ancillary data
> > instructions since it XORs A with X while all the others replace A with
> > some loaded value. All the BPF JITs fail to clear A if this is used as
> > the first instruction in a filter.
>
> Is x86_64 part of this 'All' subset ? ;)
No, because it's an eBPF JIT.
WARNING: multiple messages have this Message-ID (diff)
From: Rabin Vincent <rabin@rab.in>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X
Date: Tue, 05 Jan 2016 16:03:45 +0000 [thread overview]
Message-ID: <20160105160345.GA3951@debian> (raw)
In-Reply-To: <1452009645.8255.96.camel@edumazet-glaptop2.roam.corp.google.com>
On Tue, Jan 05, 2016 at 08:00:45AM -0800, Eric Dumazet wrote:
> On Tue, 2016-01-05 at 16:23 +0100, Rabin Vincent wrote:
> > The SKF_AD_ALU_XOR_X ancillary is not like the other ancillary data
> > instructions since it XORs A with X while all the others replace A with
> > some loaded value. All the BPF JITs fail to clear A if this is used as
> > the first instruction in a filter.
>
> Is x86_64 part of this 'All' subset ? ;)
No, because it's an eBPF JIT.
WARNING: multiple messages have this Message-ID (diff)
From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X
Date: Tue, 5 Jan 2016 17:03:45 +0100 [thread overview]
Message-ID: <20160105160345.GA3951@debian> (raw)
In-Reply-To: <1452009645.8255.96.camel@edumazet-glaptop2.roam.corp.google.com>
On Tue, Jan 05, 2016 at 08:00:45AM -0800, Eric Dumazet wrote:
> On Tue, 2016-01-05 at 16:23 +0100, Rabin Vincent wrote:
> > The SKF_AD_ALU_XOR_X ancillary is not like the other ancillary data
> > instructions since it XORs A with X while all the others replace A with
> > some loaded value. All the BPF JITs fail to clear A if this is used as
> > the first instruction in a filter.
>
> Is x86_64 part of this 'All' subset ? ;)
No, because it's an eBPF JIT.
next prev parent reply other threads:[~2016-01-05 16:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 15:23 [PATCH] net: filter: make JITs zero A for SKF_AD_ALU_XOR_X Rabin Vincent
2016-01-05 15:23 ` Rabin Vincent
2016-01-05 15:23 ` Rabin Vincent
2016-01-05 16:00 ` Eric Dumazet
2016-01-05 16:00 ` Eric Dumazet
2016-01-05 16:00 ` Eric Dumazet
2016-01-05 16:03 ` Rabin Vincent [this message]
2016-01-05 16:03 ` Rabin Vincent
2016-01-05 16:03 ` Rabin Vincent
2016-01-05 16:37 ` Daniel Borkmann
2016-01-05 16:37 ` Daniel Borkmann
2016-01-05 16:37 ` Daniel Borkmann
2016-01-05 16:36 ` Daniel Borkmann
2016-01-05 16:36 ` Daniel Borkmann
2016-01-05 16:36 ` Daniel Borkmann
2016-01-05 17:43 ` Alexei Starovoitov
2016-01-05 17:43 ` Alexei Starovoitov
2016-01-05 17:43 ` Alexei Starovoitov
2016-01-06 5:44 ` David Miller
2016-01-06 5:44 ` David Miller
2016-01-06 5:44 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105160345.GA3951@debian \
--to=rabin@rab.in \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.