From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] perf, tools, stat: Force C numeric locale for CSV mode
Date: Tue, 5 Jan 2016 22:05:01 +0100 [thread overview]
Message-ID: <20160105210501.GA23394@krava.local> (raw)
In-Reply-To: <1452021465-17831-1-git-send-email-andi@firstfloor.org>
On Tue, Jan 05, 2016 at 11:17:45AM -0800, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
>
> Some locales print floating point numbers with a comma instead of a dot.
> This causes problems with CSV mode because it causes extra false CSV
> fields. Force the numeric locale to be always C in CSV mode.
>
> Before:
>
> $ LC_ALL=pl_PL.utf8 perf stat -x, true
> 0,399472,,task-clock,399472,100,00 <---- extra bogus field
> ...
>
> After:
> $ LC_ALL=pl_PL.utf8 ./obj-perf/perf stat -x, true
> 0.338422,,task-clock,338422,100.00
>
> Originally reported in https://github.com/andikleen/pmu-tools/issues/43
>
> Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2016-01-05 21:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 19:17 [PATCH] perf, tools, stat: Force C numeric locale for CSV mode Andi Kleen
2016-01-05 21:05 ` Jiri Olsa [this message]
2016-01-05 21:17 ` Arnaldo Carvalho de Melo
2016-01-05 21:28 ` Andi Kleen
2016-01-05 23:27 ` Arnaldo Carvalho de Melo
2016-01-06 1:37 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160105210501.GA23394@krava.local \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.