From: Greg Kurz <gkurz@linux.vnet.ibm.com>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: amit.shah@redhat.com, pbonzini@redhat.com,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] virtio serial port: fix to incomplete QOMify
Date: Wed, 6 Jan 2016 09:33:48 +0100 [thread overview]
Message-ID: <20160106093348.1c7146bb@bahia.local> (raw)
In-Reply-To: <1452068575-21543-1-git-send-email-caoj.fnst@cn.fujitsu.com>
On Wed, 6 Jan 2016 16:22:55 +0800
Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
Reviewed-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> hw/char/virtio-serial-bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
> index 497b0af..2d2a659 100644
> --- a/hw/char/virtio-serial-bus.c
> +++ b/hw/char/virtio-serial-bus.c
> @@ -798,7 +798,7 @@ static const TypeInfo virtser_bus_info = {
>
> static void virtser_bus_dev_print(Monitor *mon, DeviceState *qdev, int indent)
> {
> - VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev, qdev);
> + VirtIOSerialPort *port = VIRTIO_SERIAL_PORT(qdev);
>
> monitor_printf(mon, "%*sport %d, guest %s, host %s, throttle %s\n",
> indent, "", port->id,
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kurz <gkurz@linux.vnet.ibm.com>
To: Cao jin <caoj.fnst@cn.fujitsu.com>
Cc: amit.shah@redhat.com, pbonzini@redhat.com,
qemu-trivial@nongnu.org, qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH] virtio serial port: fix to incomplete QOMify
Date: Wed, 6 Jan 2016 09:33:48 +0100 [thread overview]
Message-ID: <20160106093348.1c7146bb@bahia.local> (raw)
In-Reply-To: <1452068575-21543-1-git-send-email-caoj.fnst@cn.fujitsu.com>
On Wed, 6 Jan 2016 16:22:55 +0800
Cao jin <caoj.fnst@cn.fujitsu.com> wrote:
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
Reviewed-by: Greg Kurz <gkurz@linux.vnet.ibm.com>
> hw/char/virtio-serial-bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c
> index 497b0af..2d2a659 100644
> --- a/hw/char/virtio-serial-bus.c
> +++ b/hw/char/virtio-serial-bus.c
> @@ -798,7 +798,7 @@ static const TypeInfo virtser_bus_info = {
>
> static void virtser_bus_dev_print(Monitor *mon, DeviceState *qdev, int indent)
> {
> - VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev, qdev);
> + VirtIOSerialPort *port = VIRTIO_SERIAL_PORT(qdev);
>
> monitor_printf(mon, "%*sport %d, guest %s, host %s, throttle %s\n",
> indent, "", port->id,
next prev parent reply other threads:[~2016-01-06 8:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 8:22 [Qemu-trivial] [PATCH] virtio serial port: fix to incomplete QOMify Cao jin
2016-01-06 8:22 ` [Qemu-devel] " Cao jin
2016-01-06 8:33 ` Greg Kurz [this message]
2016-01-06 8:33 ` Greg Kurz
2016-01-07 9:57 ` [Qemu-trivial] " Amit Shah
2016-01-07 9:57 ` [Qemu-devel] " Amit Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106093348.1c7146bb@bahia.local \
--to=gkurz@linux.vnet.ibm.com \
--cc=amit.shah@redhat.com \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.