* [patch -next] mlxsw: core: remove an unnecessary condition
@ 2016-01-06 9:56 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-01-06 9:56 UTC (permalink / raw)
To: Jiri Pirko; +Cc: Ido Schimmel, netdev, kernel-janitors
We checked "err" on the lines before so we know it's zero here.
These cause a static checker warning because checking known things can
indicate a bug. Maybe there is a missing assignment or we are checking
the wrong variable.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c b/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c
index 5b9364f..1ac8bf1 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c
@@ -130,7 +130,7 @@ static ssize_t mlxsw_hwmon_temp_rst_store(struct device *dev,
dev_err(mlxsw_hwmon->bus_info->dev, "Failed to reset temp sensor history\n");
return err;
}
- return err ? err : len;
+ return len;
}
static ssize_t mlxsw_hwmon_fan_rpm_show(struct device *dev,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [patch -next] mlxsw: core: remove an unnecessary condition
@ 2016-01-06 9:56 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-01-06 9:56 UTC (permalink / raw)
To: Jiri Pirko; +Cc: Ido Schimmel, netdev, kernel-janitors
We checked "err" on the lines before so we know it's zero here.
These cause a static checker warning because checking known things can
indicate a bug. Maybe there is a missing assignment or we are checking
the wrong variable.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c b/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c
index 5b9364f..1ac8bf1 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c
@@ -130,7 +130,7 @@ static ssize_t mlxsw_hwmon_temp_rst_store(struct device *dev,
dev_err(mlxsw_hwmon->bus_info->dev, "Failed to reset temp sensor history\n");
return err;
}
- return err ? err : len;
+ return len;
}
static ssize_t mlxsw_hwmon_fan_rpm_show(struct device *dev,
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [patch -next] mlxsw: core: remove an unnecessary condition
2016-01-06 9:56 ` Dan Carpenter
@ 2016-01-06 10:15 ` Jiri Pirko
-1 siblings, 0 replies; 6+ messages in thread
From: Jiri Pirko @ 2016-01-06 10:15 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jiri Pirko, Ido Schimmel, netdev, kernel-janitors
Wed, Jan 06, 2016 at 10:56:30AM CET, dan.carpenter@oracle.com wrote:
>We checked "err" on the lines before so we know it's zero here.
>
>These cause a static checker warning because checking known things can
>indicate a bug. Maybe there is a missing assignment or we are checking
>the wrong variable.
>
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch -next] mlxsw: core: remove an unnecessary condition
@ 2016-01-06 10:15 ` Jiri Pirko
0 siblings, 0 replies; 6+ messages in thread
From: Jiri Pirko @ 2016-01-06 10:15 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Jiri Pirko, Ido Schimmel, netdev, kernel-janitors
Wed, Jan 06, 2016 at 10:56:30AM CET, dan.carpenter@oracle.com wrote:
>We checked "err" on the lines before so we know it's zero here.
>
>These cause a static checker warning because checking known things can
>indicate a bug. Maybe there is a missing assignment or we are checking
>the wrong variable.
>
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch -next] mlxsw: core: remove an unnecessary condition
2016-01-06 9:56 ` Dan Carpenter
@ 2016-01-06 20:08 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-01-06 20:08 UTC (permalink / raw)
To: dan.carpenter; +Cc: jiri, idosch, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 6 Jan 2016 12:56:30 +0300
> We checked "err" on the lines before so we know it's zero here.
>
> These cause a static checker warning because checking known things can
> indicate a bug. Maybe there is a missing assignment or we are checking
> the wrong variable.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [patch -next] mlxsw: core: remove an unnecessary condition
@ 2016-01-06 20:08 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2016-01-06 20:08 UTC (permalink / raw)
To: dan.carpenter; +Cc: jiri, idosch, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 6 Jan 2016 12:56:30 +0300
> We checked "err" on the lines before so we know it's zero here.
>
> These cause a static checker warning because checking known things can
> indicate a bug. Maybe there is a missing assignment or we are checking
> the wrong variable.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-06 20:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-06 9:56 [patch -next] mlxsw: core: remove an unnecessary condition Dan Carpenter
2016-01-06 9:56 ` Dan Carpenter
2016-01-06 10:15 ` Jiri Pirko
2016-01-06 10:15 ` Jiri Pirko
2016-01-06 20:08 ` David Miller
2016-01-06 20:08 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.