From: Dan Carpenter <dan.carpenter@oracle.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Jens Axboe <axboe@fb.com>,
Asai Thambi SP <asamymuthupa@micron.com>,
Selvan Mani <smani@micron.com>, Jeff Moyer <jmoyer@redhat.com>,
Michal Hocko <mhocko@suse.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mtip32xx: calling kfree() on an error pointer
Date: Wed, 06 Jan 2016 13:16:50 +0000 [thread overview]
Message-ID: <20160106131650.GH23363@mwanda> (raw)
In-Reply-To: <20160106130800.GS9938@ZenIV.linux.org.uk>
On Wed, Jan 06, 2016 at 01:08:00PM +0000, Al Viro wrote:
> On Wed, Jan 06, 2016 at 01:05:03PM +0300, Dan Carpenter wrote:
> > If memdup_user() fails then we end up passing an ERR_PTR to kfree()
> > which is a bug.
>
> Mind if I fold it (with credit, obviously)?
No problem, that's fine.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Jens Axboe <axboe@fb.com>,
Asai Thambi SP <asamymuthupa@micron.com>,
Selvan Mani <smani@micron.com>, Jeff Moyer <jmoyer@redhat.com>,
Michal Hocko <mhocko@suse.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mtip32xx: calling kfree() on an error pointer
Date: Wed, 6 Jan 2016 16:16:50 +0300 [thread overview]
Message-ID: <20160106131650.GH23363@mwanda> (raw)
In-Reply-To: <20160106130800.GS9938@ZenIV.linux.org.uk>
On Wed, Jan 06, 2016 at 01:08:00PM +0000, Al Viro wrote:
> On Wed, Jan 06, 2016 at 01:05:03PM +0300, Dan Carpenter wrote:
> > If memdup_user() fails then we end up passing an ERR_PTR to kfree()
> > which is a bug.
>
> Mind if I fold it (with credit, obviously)?
No problem, that's fine.
regards,
dan carpenter
next prev parent reply other threads:[~2016-01-06 13:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 10:05 [patch] mtip32xx: calling kfree() on an error pointer Dan Carpenter
2016-01-06 10:05 ` Dan Carpenter
2016-01-06 13:08 ` Al Viro
2016-01-06 13:08 ` Al Viro
2016-01-06 13:16 ` Dan Carpenter [this message]
2016-01-06 13:16 ` Dan Carpenter
2016-01-06 13:26 ` Al Viro
2016-01-06 13:26 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106131650.GH23363@mwanda \
--to=dan.carpenter@oracle.com \
--cc=asamymuthupa@micron.com \
--cc=axboe@fb.com \
--cc=jmoyer@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mhocko@suse.com \
--cc=smani@micron.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.