From: Mark Rutland <mark.rutland@arm.com>
To: Vishnu Patekar <vishnupatekar0510@gmail.com>
Cc: robh+dt@kernel.org, corbet@lwn.net, pawel.moll@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
maxime.ripard@free-electrons.com, linux@arm.linux.org.uk,
emilio@elopez.com.ar, linus.walleij@linaro.org,
jenskuske@gmail.com, hdegoede@redhat.com, wens@csie.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v4 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi
Date: Wed, 6 Jan 2016 13:25:05 +0000 [thread overview]
Message-ID: <20160106132505.GJ563@leverpostej> (raw)
In-Reply-To: <1452085914-29340-3-git-send-email-vishnupatekar0510@gmail.com>
Hi,
> + chosen {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> + };
What is the ranges property doing here?
[...]
> + clocks {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + osc24M: osc24M_clk {
> + #clock-cells = <0>;
> + compatible = "fixed-clock";
> + clock-frequency = <24000000>;
> + clock-output-names = "osc24M";
> + };
> +
> + osc32k: osc32k_clk {
> + #clock-cells = <0>;
> + compatible = "fixed-clock";
> + clock-frequency = <32768>;
> + clock-output-names = "osc32k";
> + };
> + };
Just put the clocks under the root node. 'clocks' is not a special node.
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi
Date: Wed, 6 Jan 2016 13:25:05 +0000 [thread overview]
Message-ID: <20160106132505.GJ563@leverpostej> (raw)
In-Reply-To: <1452085914-29340-3-git-send-email-vishnupatekar0510@gmail.com>
Hi,
> + chosen {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> + };
What is the ranges property doing here?
[...]
> + clocks {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + osc24M: osc24M_clk {
> + #clock-cells = <0>;
> + compatible = "fixed-clock";
> + clock-frequency = <24000000>;
> + clock-output-names = "osc24M";
> + };
> +
> + osc32k: osc32k_clk {
> + #clock-cells = <0>;
> + compatible = "fixed-clock";
> + clock-frequency = <32768>;
> + clock-output-names = "osc32k";
> + };
> + };
Just put the clocks under the root node. 'clocks' is not a special node.
Thanks,
Mark.
next prev parent reply other threads:[~2016-01-06 13:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 13:11 [PATCH v4 0/3] Add basic support for Allwinner A83T SOC Vishnu Patekar
2016-01-06 13:11 ` Vishnu Patekar
2016-01-06 13:11 ` Vishnu Patekar
[not found] ` <1452085914-29340-1-git-send-email-vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-06 13:11 ` [PATCH v4 1/3] ARM: sunxi: Introduce Allwinner for A83T support Vishnu Patekar
2016-01-06 13:11 ` Vishnu Patekar
2016-01-06 13:11 ` Vishnu Patekar
[not found] ` <1452085914-29340-2-git-send-email-vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-11 7:48 ` Maxime Ripard
2016-01-11 7:48 ` Maxime Ripard
2016-01-11 7:48 ` Maxime Ripard
2016-01-06 13:11 ` [PATCH v4 2/3] ARM: dts: sun8i: Add Allwinner A83T dtsi Vishnu Patekar
2016-01-06 13:11 ` Vishnu Patekar
2016-01-06 13:11 ` Vishnu Patekar
2016-01-06 13:25 ` Mark Rutland [this message]
2016-01-06 13:25 ` Mark Rutland
2016-01-06 14:05 ` Maxime Ripard
2016-01-06 14:05 ` Maxime Ripard
2016-01-06 14:05 ` Maxime Ripard
[not found] ` <1452085914-29340-3-git-send-email-vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-01-11 7:53 ` Maxime Ripard
2016-01-11 7:53 ` Maxime Ripard
2016-01-11 7:53 ` Maxime Ripard
2016-01-06 13:11 ` [PATCH v4 3/3] ARM: dts: sun8i: Add A83T HomletV2 Board by Allwinner Vishnu Patekar
2016-01-06 13:11 ` Vishnu Patekar
2016-01-06 13:11 ` Vishnu Patekar
2016-01-11 7:54 ` Maxime Ripard
2016-01-11 7:54 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106132505.GJ563@leverpostej \
--to=mark.rutland@arm.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=emilio@elopez.com.ar \
--cc=galak@codeaurora.org \
--cc=hdegoede@redhat.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jenskuske@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@arm.linux.org.uk \
--cc=maxime.ripard@free-electrons.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=vishnupatekar0510@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.