All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: James Liao <jamesjj.liao@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Mike Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@codeaurora.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Daniel Kurtz <djkurtz@chromium.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 2/6] dt-bindings: ARM: Mediatek: Document bindings for MT2701
Date: Wed, 6 Jan 2016 09:08:00 -0600	[thread overview]
Message-ID: <20160106150800.GA941@rob-hp-laptop> (raw)
In-Reply-To: <1451975422-31174-3-git-send-email-jamesjj.liao@mediatek.com>

On Tue, Jan 05, 2016 at 02:30:18PM +0800, James Liao wrote:
> This patch adds the binding documentation for apmixedsys, bdpsys,
> ethsys, hifsys, imgsys, infracfg, mmsys, pericfg, topckgen and
> vdecsys for Mediatek MT2701.
> 
> Signed-off-by: James Liao <jamesjj.liao@mediatek.com>

[...]

> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,bdpsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,bdpsys.txt
> new file mode 100644
> index 0000000..4137196
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,bdpsys.txt
> @@ -0,0 +1,22 @@
> +Mediatek bdpsys controller
> +============================
> +
> +The Mediatek bdpsys controller provides various clocks to the system.
> +
> +Required Properties:
> +
> +- compatible: Should be:
> +	- "mediatek,mt2701-bdpsys", "syscon"

If this block and others only provide clocks, then why do you need 
syscon here? If it is more that clocks, then the description is wrong.

Rob

WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/6] dt-bindings: ARM: Mediatek: Document bindings for MT2701
Date: Wed, 6 Jan 2016 09:08:00 -0600	[thread overview]
Message-ID: <20160106150800.GA941@rob-hp-laptop> (raw)
In-Reply-To: <1451975422-31174-3-git-send-email-jamesjj.liao@mediatek.com>

On Tue, Jan 05, 2016 at 02:30:18PM +0800, James Liao wrote:
> This patch adds the binding documentation for apmixedsys, bdpsys,
> ethsys, hifsys, imgsys, infracfg, mmsys, pericfg, topckgen and
> vdecsys for Mediatek MT2701.
> 
> Signed-off-by: James Liao <jamesjj.liao@mediatek.com>

[...]

> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,bdpsys.txt b/Documentation/devicetree/bindings/arm/mediatek/mediatek,bdpsys.txt
> new file mode 100644
> index 0000000..4137196
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,bdpsys.txt
> @@ -0,0 +1,22 @@
> +Mediatek bdpsys controller
> +============================
> +
> +The Mediatek bdpsys controller provides various clocks to the system.
> +
> +Required Properties:
> +
> +- compatible: Should be:
> +	- "mediatek,mt2701-bdpsys", "syscon"

If this block and others only provide clocks, then why do you need 
syscon here? If it is more that clocks, then the description is wrong.

Rob

  reply	other threads:[~2016-01-06 15:08 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05  6:30 [PATCH v2 0/6] Add clock support for Mediatek MT2701 James Liao
2016-01-05  6:30 ` James Liao
2016-01-05  6:30 ` James Liao
2016-01-05  6:30 ` [PATCH v2 1/6] clk: mediatek: Refine the makefile to support multiple clock drivers James Liao
2016-01-05  6:30   ` James Liao
2016-01-05  6:30   ` James Liao
2016-01-05  6:30 ` [PATCH v2 2/6] dt-bindings: ARM: Mediatek: Document bindings for MT2701 James Liao
2016-01-05  6:30   ` James Liao
2016-01-05  6:30   ` James Liao
2016-01-06 15:08   ` Rob Herring [this message]
2016-01-06 15:08     ` Rob Herring
2016-01-13  3:39     ` James Liao
2016-01-13  3:39       ` James Liao
2016-01-13  3:39       ` James Liao
2016-01-05  6:30 ` [PATCH v2 3/6] clk: mediatek: Add dt-bindings for MT2701 clocks James Liao
2016-01-05  6:30   ` James Liao
2016-01-05  6:30   ` James Liao
2016-01-05  6:30 ` [PATCH v2 4/6] clk: mediatek: Add MT2701 clock support James Liao
2016-01-05  6:30   ` James Liao
2016-01-05  6:30   ` James Liao
2016-01-05  9:30   ` Philipp Zabel
2016-01-05  9:30     ` Philipp Zabel
2016-01-05  9:30     ` Philipp Zabel
2016-01-05  9:59     ` James Liao
2016-01-05  9:59       ` James Liao
2016-01-05  9:59       ` James Liao
2016-01-05  6:30 ` [PATCH v2 5/6] reset: mediatek: mt2701 reset controller dt-binding file James Liao
2016-01-05  6:30   ` James Liao
2016-01-05  6:30   ` James Liao
2016-01-05  9:31   ` Philipp Zabel
2016-01-05  9:31     ` Philipp Zabel
2016-01-05  9:31     ` Philipp Zabel
2016-01-05 10:00     ` James Liao
2016-01-05 10:00       ` James Liao
2016-01-05 10:00       ` James Liao
2016-01-05  6:30 ` [PATCH v2 6/6] reset: mediatek: mt2701 reset driver James Liao
2016-01-05  6:30   ` James Liao
2016-01-05  6:30   ` James Liao
2016-01-05  9:31   ` Philipp Zabel
2016-01-05  9:31     ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160106150800.GA941@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=djkurtz@chromium.org \
    --cc=jamesjj.liao@mediatek.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=sboyd@codeaurora.org \
    --cc=srv_heupstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.