From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH for-4.4] block: split bios to max possible length
Date: Wed, 6 Jan 2016 15:18:36 +0000 [thread overview]
Message-ID: <20160106151836.GB15113@localhost.localdomain> (raw)
In-Reply-To: <CACVXFVPifqQP_LdLv79Lv_EF-evfh9LFT2nfVvDKMuLJ-OCH5g@mail.gmail.com>
On Wed, Jan 06, 2016@02:53:22PM +0800, Ming Lei wrote:
> On Wed, Jan 6, 2016@2:29 PM, Ming Lei <tom.leiming@gmail.com> wrote:
> >
> > bvec_iter_advance() can split anywhere, but the splitted bios may
> > cross one same bvec, which may cause trouble,
Cross? One starts where the other starts. Could you please explain what's
wrong?
> > for example,
> > BIOVEC_PHYS_MERGEABLE() may not work well and
> > blk_phys_contig_segment() too.
Could you please explain why it may not work well? I have no idea what
concern you have with BIOVEC_PHYS_MERGEABLE in this case.
The only place blk_phys_contig_segment is called from is
ll_merge_requests, and the first req of the split bio wouldn't even go
through here because it's marked REQ_NOMERGE.
> blk_rq_map_sg() isn't ready for splitting in the middle of bvec too.
Could you please explain? It just uses the bio iterator, which I'm pretty
sure is not broken.
next prev parent reply other threads:[~2016-01-06 15:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 18:24 [PATCH for-4.4] block: split bios to max possible length Keith Busch
2016-01-05 4:54 ` Ming Lei
2016-01-05 15:09 ` Keith Busch
2016-01-06 2:17 ` Ming Lei
2016-01-06 5:51 ` Keith Busch
2016-01-06 6:29 ` Ming Lei
2016-01-06 6:53 ` Ming Lei
2016-01-06 15:18 ` Keith Busch [this message]
2016-01-06 15:43 ` Ming Lei
2016-01-06 16:21 ` Keith Busch
2016-01-07 0:14 ` Ming Lei
2016-01-07 10:46 ` Kent Overstreet
2016-01-09 11:10 ` Ming Lei
2016-01-06 15:29 ` Keith Busch
2016-01-06 9:46 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106151836.GB15113@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.