From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH for-4.4] block: split bios to max possible length
Date: Wed, 6 Jan 2016 15:29:17 +0000 [thread overview]
Message-ID: <20160106152917.GC15113@localhost.localdomain> (raw)
In-Reply-To: <CACVXFVNWTSD9Few9KLT6r+yvgynfMduAoLEbP0t3Yo=ye5UDHA@mail.gmail.com>
On Wed, Jan 06, 2016@02:29:16PM +0800, Ming Lei wrote:
> Also not mention your patch doesn't update front_seg_size/back_seg_size/
> seg_size correctly.
>
> That is why I said we should be careful about splitting bvec because it
> is never used or supported before.
Ok, that's an easy fix, but it's not really a functional difference. The
request is not mergeable after this, which is the only use for back and
front seg sizes.
> > The nvme driver is okay to take physically merged pages. It splits them
> > into PRPs accordingly, and it's faster to DMA map physically contiguous
> > just because there are fewer segments to iterate, so NVMe would prefer
> > to let them coalesce.
>
> If so, NO_SG_MERGE should be removed now.
Sounds good.
> Could you share your test case? Last time I use null_blk to observe
> the performance difference between NO_SG_MERGE vs. non-NO_SG_MERGE,
> and basically no difference is observed.
null_blk doesn't do anything, so it's probably difficult to measure
that. Use a driver that DMA maps the data, uses MMIO to submit to h/w
and takes an interrupt. You can measure all these when you create 50%
more commands than necessary with unneeded splits.
next prev parent reply other threads:[~2016-01-06 15:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-04 18:24 [PATCH for-4.4] block: split bios to max possible length Keith Busch
2016-01-05 4:54 ` Ming Lei
2016-01-05 15:09 ` Keith Busch
2016-01-06 2:17 ` Ming Lei
2016-01-06 5:51 ` Keith Busch
2016-01-06 6:29 ` Ming Lei
2016-01-06 6:53 ` Ming Lei
2016-01-06 15:18 ` Keith Busch
2016-01-06 15:43 ` Ming Lei
2016-01-06 16:21 ` Keith Busch
2016-01-07 0:14 ` Ming Lei
2016-01-07 10:46 ` Kent Overstreet
2016-01-09 11:10 ` Ming Lei
2016-01-06 15:29 ` Keith Busch [this message]
2016-01-06 9:46 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106152917.GC15113@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.