From: rabin@rab.in (Rabin Vincent)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: net: bpf: don't BUG() on large shifts
Date: Wed, 6 Jan 2016 21:31:27 +0100 [thread overview]
Message-ID: <20160106203127.GA16059@debian> (raw)
In-Reply-To: <20160105175557.GC83548@ast-mbp.thefacebook.com>
On Tue, Jan 05, 2016 at 09:55:58AM -0800, Alexei Starovoitov wrote:
> this one is better to be addressed in verifier instead of eBPF JITs.
> Please reject it in check_alu_op() instead.
AFAICS the eBPF verifier is not called on the eBPF filters generated by
the BPF->eBPF conversion in net/core/filter.c, so performing this check
only in check_alu_op() will be insufficient. So I think we'd need to
add this check to bpf_check_classic() too. Or am I missing something?
WARNING: multiple messages have this Message-ID (diff)
From: Rabin Vincent <rabin@rab.in>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, zlim.lnx@gmail.com,
yang.shi@linaro.org, will.deacon@arm.com,
catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: net: bpf: don't BUG() on large shifts
Date: Wed, 6 Jan 2016 21:31:27 +0100 [thread overview]
Message-ID: <20160106203127.GA16059@debian> (raw)
In-Reply-To: <20160105175557.GC83548@ast-mbp.thefacebook.com>
On Tue, Jan 05, 2016 at 09:55:58AM -0800, Alexei Starovoitov wrote:
> this one is better to be addressed in verifier instead of eBPF JITs.
> Please reject it in check_alu_op() instead.
AFAICS the eBPF verifier is not called on the eBPF filters generated by
the BPF->eBPF conversion in net/core/filter.c, so performing this check
only in check_alu_op() will be insufficient. So I think we'd need to
add this check to bpf_check_classic() too. Or am I missing something?
next prev parent reply other threads:[~2016-01-06 20:31 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 17:39 [PATCH] arm64: net: bpf: don't BUG() on large shifts Rabin Vincent
2016-01-05 17:39 ` Rabin Vincent
2016-01-05 17:55 ` Alexei Starovoitov
2016-01-05 17:55 ` Alexei Starovoitov
2016-01-06 20:31 ` Rabin Vincent [this message]
2016-01-06 20:31 ` Rabin Vincent
2016-01-06 22:12 ` Alexei Starovoitov
2016-01-06 22:12 ` Alexei Starovoitov
2016-01-07 11:07 ` David Laight
2016-01-07 11:07 ` David Laight
2016-01-07 12:48 ` Daniel Borkmann
2016-01-07 12:48 ` Daniel Borkmann
2016-01-08 15:58 ` Rabin Vincent
2016-01-08 15:58 ` Rabin Vincent
2016-01-08 16:44 ` Daniel Borkmann
2016-01-08 16:44 ` Daniel Borkmann
2016-01-08 19:18 ` Alexei Starovoitov
2016-01-08 19:18 ` Alexei Starovoitov
2016-01-08 15:44 ` Will Deacon
2016-01-08 15:44 ` Will Deacon
2016-01-08 19:09 ` Alexei Starovoitov
2016-01-08 19:09 ` Alexei Starovoitov
2016-01-12 17:17 ` Will Deacon
2016-01-12 17:17 ` Will Deacon
2016-01-12 19:23 ` Alexei Starovoitov
2016-01-12 19:23 ` Alexei Starovoitov
2016-01-13 4:45 ` Z Lim
2016-01-13 4:45 ` Z Lim
2016-01-13 12:08 ` Will Deacon
2016-01-13 12:08 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106203127.GA16059@debian \
--to=rabin@rab.in \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.