From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, ak@linux.intel.com, kan.liang@intel.com,
jolsa@kernel.org
Subject: Re: [PATCH] perf pmu: fix alias->snapshot missing initialization bug
Date: Wed, 6 Jan 2016 18:53:27 -0200 [thread overview]
Message-ID: <20160106205327.GD2503@redhat.com> (raw)
In-Reply-To: <1452106201-13073-1-git-send-email-eranian@google.com>
Em Wed, Jan 06, 2016 at 07:50:01PM +0100, Stephane Eranian escreveu:
> This patch fixes a bug in __perf_pmu__new_alias() whereby
> the alias->snapshot field was not initialized to false. This
> led to random alias->snapshot value for an alias and
> was breaking some measurements such as:
>
> $ perf stat -a -e uncore_imc/data_reads/ -I 1000 sleep 100
>
> Because the event ended up being treated as snapshot mode, when
> it is not.
Thanks, applied.
- Arnaldo
next prev parent reply other threads:[~2016-01-06 20:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 18:50 [PATCH] perf pmu: fix alias->snapshot missing initialization bug Stephane Eranian
2016-01-06 20:53 ` Arnaldo Carvalho de Melo [this message]
2016-01-09 16:32 ` [tip:perf/core] perf pmu: fix alias-> snapshot " tip-bot for Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106205327.GD2503@redhat.com \
--to=acme@redhat.com \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.