From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Andy Gross <andy.gross@linaro.org>
Subject: Re: [PATCH 1/3] driver-core: platform: Add platform_irq_count()
Date: Wed, 6 Jan 2016 17:47:58 -0800 [thread overview]
Message-ID: <20160107014758.GB17796@kroah.com> (raw)
In-Reply-To: <1452129169-2014-2-git-send-email-sboyd@codeaurora.org>
On Wed, Jan 06, 2016 at 05:12:47PM -0800, Stephen Boyd wrote:
> A recent patch added calls to of_irq_count() in the qcom pinctrl
> drivers and that caused module build failures because
> of_irq_count() is not an exported symbol. We shouldn't export
> of_irq_count() to modules because it's an internal OF API that
> shouldn't be used by drivers. Platform drivers should use
> platform device APIs instead. Therefore, add a platform_irq_count()
> API that mirrors the of_irq_count() API so that platform drivers
> can stay DT agnostic.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Andy Gross <andy.gross@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/base/platform.c | 20 ++++++++++++++++++++
> include/linux/platform_device.h | 1 +
> 2 files changed, 21 insertions(+)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] driver-core: platform: Add platform_irq_count()
Date: Wed, 6 Jan 2016 17:47:58 -0800 [thread overview]
Message-ID: <20160107014758.GB17796@kroah.com> (raw)
In-Reply-To: <1452129169-2014-2-git-send-email-sboyd@codeaurora.org>
On Wed, Jan 06, 2016 at 05:12:47PM -0800, Stephen Boyd wrote:
> A recent patch added calls to of_irq_count() in the qcom pinctrl
> drivers and that caused module build failures because
> of_irq_count() is not an exported symbol. We shouldn't export
> of_irq_count() to modules because it's an internal OF API that
> shouldn't be used by drivers. Platform drivers should use
> platform device APIs instead. Therefore, add a platform_irq_count()
> API that mirrors the of_irq_count() API so that platform drivers
> can stay DT agnostic.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Andy Gross <andy.gross@linaro.org>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> ---
> drivers/base/platform.c | 20 ++++++++++++++++++++
> include/linux/platform_device.h | 1 +
> 2 files changed, 21 insertions(+)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org
next prev parent reply other threads:[~2016-01-07 1:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 1:12 [PATCH 0/3] Make qcom pinctrl drivers tristate again Stephen Boyd
2016-01-07 1:12 ` Stephen Boyd
2016-01-07 1:12 ` [PATCH 1/3] driver-core: platform: Add platform_irq_count() Stephen Boyd
2016-01-07 1:12 ` Stephen Boyd
2016-01-07 1:15 ` Rob Herring
2016-01-07 1:15 ` Rob Herring
2016-01-07 1:47 ` Greg Kroah-Hartman [this message]
2016-01-07 1:47 ` Greg Kroah-Hartman
2016-01-07 9:34 ` Linus Walleij
2016-01-07 9:34 ` Linus Walleij
2016-01-07 10:32 ` Arnd Bergmann
2016-01-07 10:32 ` Arnd Bergmann
2016-01-07 1:12 ` [PATCH 2/3] pinctrl: qcom: Use platform_irq_count() instead of of_irq_count() Stephen Boyd
2016-01-07 1:12 ` Stephen Boyd
2016-01-07 1:19 ` Bjorn Andersson
2016-01-07 1:19 ` Bjorn Andersson
2016-01-07 1:28 ` Stephen Boyd
2016-01-07 1:28 ` Stephen Boyd
2016-01-07 1:37 ` [PATCH v2 " Stephen Boyd
2016-01-07 1:37 ` Stephen Boyd
2016-01-07 9:36 ` Linus Walleij
2016-01-07 9:36 ` Linus Walleij
2016-01-07 1:12 ` [PATCH 3/3] Revert "pinctrl: qcom: make PMIC drivers bool" Stephen Boyd
2016-01-07 1:12 ` Stephen Boyd
2016-01-07 9:37 ` Linus Walleij
2016-01-07 9:37 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107014758.GB17796@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andy.gross@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.