All of lore.kernel.org
 help / color / mirror / Atom feed
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: versatile: fix MMC/SD interrupt assignment
Date: Thu, 7 Jan 2016 06:33:18 +0100	[thread overview]
Message-ID: <20160107053318.GH26875@localhost> (raw)
In-Reply-To: <1451984370-16932-1-git-send-email-linus.walleij@linaro.org>

On Tue, Jan 05, 2016 at 09:59:30AM +0100, Linus Walleij wrote:
> Commit 0976c946a610d06e907335b7a3afa6db046f8e1b
> "arm/versatile: Fix versatile irq specifications"
> has an off-by-one error on the Versatile AB that has
> been regressing the Versatile AB hardware for some time.
> 
> However it seems like the interrupt assignments have
> never been correct and I have now adjusted them according
> to the specification. The masks for the valid interrupts
> made it impossible to assign the right SIC interrupt
> for the MMCI, so I went in and fixed these to correspond
> to the specifications, and added references if anyone
> wants to double-check.
> 
> Due to the Versatile PB including the Versatile AB
> as a base DTS file, we need to override and correct
> some values to correspond to the actual changes in the
> hardware.
> 
> For the Versatile PB I don't think the IRQ line
> assignment for MMCI has ever been correct for either of
> the two MMCI blocks. It would be nice if someone with the
> physical PB board could test this.
> 
> Patch tested on the Versatile AB, QEMU for Versatile AB
> and QEMU for Versatile PB.
> 
> Cc: Rob Herring <robh@kernel.org>
> Cc: Grant Likely <grant.likely@linaro.org>
> Cc: stable at vger.kernel.org
> Fixes: 0976c946a610 ("arm/versatile: Fix versatile irq specifications")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ARM SoC people: please apply this directly for fixes if
> you find it OK.

Applied to fixes. Seems like Rob's comments were concerns but not
blockers, so picking up the fix seems to make sense.


-Olof

WARNING: multiple messages have this Message-ID (diff)
From: Olof Johansson <olof@lixom.net>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: arm@kernel.org, linux-arm-kernel@lists.infradead.org,
	Rob Herring <robh@kernel.org>,
	Grant Likely <grant.likely@linaro.org>,
	stable@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: versatile: fix MMC/SD interrupt assignment
Date: Thu, 7 Jan 2016 06:33:18 +0100	[thread overview]
Message-ID: <20160107053318.GH26875@localhost> (raw)
In-Reply-To: <1451984370-16932-1-git-send-email-linus.walleij@linaro.org>

On Tue, Jan 05, 2016 at 09:59:30AM +0100, Linus Walleij wrote:
> Commit 0976c946a610d06e907335b7a3afa6db046f8e1b
> "arm/versatile: Fix versatile irq specifications"
> has an off-by-one error on the Versatile AB that has
> been regressing the Versatile AB hardware for some time.
> 
> However it seems like the interrupt assignments have
> never been correct and I have now adjusted them according
> to the specification. The masks for the valid interrupts
> made it impossible to assign the right SIC interrupt
> for the MMCI, so I went in and fixed these to correspond
> to the specifications, and added references if anyone
> wants to double-check.
> 
> Due to the Versatile PB including the Versatile AB
> as a base DTS file, we need to override and correct
> some values to correspond to the actual changes in the
> hardware.
> 
> For the Versatile PB I don't think the IRQ line
> assignment for MMCI has ever been correct for either of
> the two MMCI blocks. It would be nice if someone with the
> physical PB board could test this.
> 
> Patch tested on the Versatile AB, QEMU for Versatile AB
> and QEMU for Versatile PB.
> 
> Cc: Rob Herring <robh@kernel.org>
> Cc: Grant Likely <grant.likely@linaro.org>
> Cc: stable@vger.kernel.org
> Fixes: 0976c946a610 ("arm/versatile: Fix versatile irq specifications")
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> ARM SoC people: please apply this directly for fixes if
> you find it OK.

Applied to fixes. Seems like Rob's comments were concerns but not
blockers, so picking up the fix seems to make sense.


-Olof


  parent reply	other threads:[~2016-01-07  5:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-05  8:59 [PATCH 2/2] ARM: versatile: fix MMC/SD interrupt assignment Linus Walleij
2016-01-05  8:59 ` Linus Walleij
2016-01-05 23:43 ` Rob Herring
2016-01-05 23:43   ` Rob Herring
2016-01-07  9:58   ` Linus Walleij
2016-01-07  9:58     ` Linus Walleij
2016-01-07 13:53     ` Rob Herring
2016-01-07 13:53       ` Rob Herring
2016-01-07  5:33 ` Olof Johansson [this message]
2016-01-07  5:33   ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160107053318.GH26875@localhost \
    --to=olof@lixom.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.