All of lore.kernel.org
 help / color / mirror / Atom feed
From: Juergen Borleis <jbe@pengutronix.de>
To: kernel@pengutronix.de
Cc: rtc-linux@googlegroups.com,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	linux-kernel@vger.kernel.org
Subject: [rtc-linux] Re: [PATCH 3/3] RTC/PCF85063: fix time/date setting
Date: Thu, 7 Jan 2016 11:13:00 +0100	[thread overview]
Message-ID: <201601071113.00076.jbe@pengutronix.de> (raw)
In-Reply-To: <1449496174-7813-4-git-send-email-jbe@pengutronix.de>

Hi Alexandre,

sorry, missed your comment. Please keep me on CC since I'm not subscribed t=
o=20
the list.

> > When setting a new time/date the RTC's clock must be stopped first, in
> > order to write the time/date registers in an atomic manner.
> > So, this change stops the clock first and then writes the time/date
> > registers and the clock control register (to re-enable the clock) in one
> > turn.
>
> I'd have the same comment for that patch. Using
> i2c_smbus_write_byte_data and i2c_smbus_write_block_data would make the
> code clearer and also more robust because it takes care of
> retransmissions for example.

Okay. Will have a look.

Regards,
Juergen

=2D-=20
Pengutronix e.K. =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0| Juergen Borleis =A0 =A0 =A0 =A0 =A0 =A0 |
Industrial Linux Solutions =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0| http://=
www.pengutronix.de/ =A0|

WARNING: multiple messages have this Message-ID (diff)
From: Juergen Borleis <jbe@pengutronix.de>
To: kernel@pengutronix.de
Cc: rtc-linux@googlegroups.com,
	Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@free-electrons.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] RTC/PCF85063: fix time/date setting
Date: Thu, 7 Jan 2016 11:13:00 +0100	[thread overview]
Message-ID: <201601071113.00076.jbe@pengutronix.de> (raw)
In-Reply-To: <1449496174-7813-4-git-send-email-jbe@pengutronix.de>

Hi Alexandre,

sorry, missed your comment. Please keep me on CC since I'm not subscribed to 
the list.

> > When setting a new time/date the RTC's clock must be stopped first, in
> > order to write the time/date registers in an atomic manner.
> > So, this change stops the clock first and then writes the time/date
> > registers and the clock control register (to re-enable the clock) in one
> > turn.
>
> I'd have the same comment for that patch. Using
> i2c_smbus_write_byte_data and i2c_smbus_write_block_data would make the
> code clearer and also more robust because it takes care of
> retransmissions for example.

Okay. Will have a look.

Regards,
Juergen

-- 
Pengutronix e.K.                              | Juergen Borleis             |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |

  parent reply	other threads:[~2016-01-07 10:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-07 13:49 [rtc-linux] [PATCH] RTC/PCF85063: fix reading/setting time/date Juergen Borleis
2015-12-07 13:49 ` Juergen Borleis
2015-12-07 13:49 ` [rtc-linux] [PATCH 1/3] RTC/PCF85063: fix time/date reading (part 1) Juergen Borleis
2015-12-07 13:49   ` Juergen Borleis
2015-12-07 13:49 ` [rtc-linux] [PATCH 2/3] RTC/PCF85063: fix time/date reading (part II) Juergen Borleis
2015-12-07 13:49   ` Juergen Borleis
2015-12-20 11:35   ` [rtc-linux] " Alexandre Belloni
2015-12-20 11:35     ` Alexandre Belloni
2016-01-07 10:12   ` [rtc-linux] " Juergen Borleis
2016-01-07 10:12     ` Juergen Borleis
2016-01-21  0:04     ` [rtc-linux] " Alexandre Belloni
2016-01-21  0:04       ` Alexandre Belloni
2015-12-07 13:49 ` [rtc-linux] [PATCH 3/3] RTC/PCF85063: fix time/date setting Juergen Borleis
2015-12-07 13:49   ` Juergen Borleis
2015-12-20 11:46   ` [rtc-linux] " Alexandre Belloni
2015-12-20 11:46     ` Alexandre Belloni
2016-01-07 10:13   ` Juergen Borleis [this message]
2016-01-07 10:13     ` Juergen Borleis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201601071113.00076.jbe@pengutronix.de \
    --to=jbe@pengutronix.de \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@free-electrons.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.