Re: [PATCH 4/5] usb-misc: sisusbvga: Remove kmalloc logs and fix error path

[Peter Senna Tschudin <peter.senna@collabora.com>]

On Wed, Jan 06, 2016 at 09:28:41PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 1/5/2016 7:54 PM, Peter Senna Tschudin wrote:
> 
> >From: Peter Senna Tschudin <peter.senna@gmail.com>
> >
> >This patch remove four calls to dev_err() from sisusb_probe() as
> >reporting memory allocation failures is redundant:
> >
> >  - Remove a call to dev_err() that was reporting unsuccesful call to
> >    kzalloc().
> >
> >  - Remove two calls to dev_err() that were reporting unsuccesful calls
> >    to kmalloc().
> >
> >  - Remove a call to dev_err() that was reporting unsuccesful call to
> >    kmalloc(), and replace it by code that clean up previously allocated
> >    resources and abort the probe with -ENOMEM. Before this modification
> >    sisusb->SiS_Pr could be dereferenced even it was null.
> 
>    I think the bug fix should be in its own patch. Don't intermix fixes with
> cleanups please.

Ok, I'll resend the series with the following changes:
 - split patch 1: vertical and horizontal changes
 - split patch 4: cleanups and fix