From: Johannes Weiner <hannes@cmpxchg.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: mhocko@kernel.org, akpm@linux-foundation.org, mgorman@suse.de,
rientjes@google.com, torvalds@linux-foundation.org,
oleg@redhat.com, hughd@google.com, andrea@kernel.org,
riel@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm,oom: Exclude TIF_MEMDIE processes from candidates.
Date: Thu, 7 Jan 2016 11:28:15 -0500 [thread overview]
Message-ID: <20160107162815.GA31729@cmpxchg.org> (raw)
In-Reply-To: <201512292258.ABF87505.OFOSJLHMFVOQFt@I-love.SAKURA.ne.jp>
On Tue, Dec 29, 2015 at 10:58:22PM +0900, Tetsuo Handa wrote:
> >From 8bb9e36891a803e82c589ef78077838026ce0f7d Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Date: Tue, 29 Dec 2015 22:20:58 +0900
> Subject: [PATCH] mm,oom: Exclude TIF_MEMDIE processes from candidates.
>
> The OOM reaper kernel thread can reclaim OOM victim's memory before the victim
> terminates. But since oom_kill_process() tries to kill children of the memory
> hog process first, the OOM reaper can not reclaim enough memory for terminating
> the victim if the victim is consuming little memory. The result is OOM livelock
> as usual, for timeout based next OOM victim selection is not implemented.
What we should be doing is have the OOM reaper clear TIF_MEMDIE after
it's done. There is no reason to wait for and prioritize the exit of a
task that doesn't even have memory anymore. Once a task's memory has
been reaped, subsequent OOM invocations should evaluate anew the most
desirable OOM victim.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: mhocko@kernel.org, akpm@linux-foundation.org, mgorman@suse.de,
rientjes@google.com, torvalds@linux-foundation.org,
oleg@redhat.com, hughd@google.com, andrea@kernel.org,
riel@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm,oom: Exclude TIF_MEMDIE processes from candidates.
Date: Thu, 7 Jan 2016 11:28:15 -0500 [thread overview]
Message-ID: <20160107162815.GA31729@cmpxchg.org> (raw)
In-Reply-To: <201512292258.ABF87505.OFOSJLHMFVOQFt@I-love.SAKURA.ne.jp>
On Tue, Dec 29, 2015 at 10:58:22PM +0900, Tetsuo Handa wrote:
> >From 8bb9e36891a803e82c589ef78077838026ce0f7d Mon Sep 17 00:00:00 2001
> From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Date: Tue, 29 Dec 2015 22:20:58 +0900
> Subject: [PATCH] mm,oom: Exclude TIF_MEMDIE processes from candidates.
>
> The OOM reaper kernel thread can reclaim OOM victim's memory before the victim
> terminates. But since oom_kill_process() tries to kill children of the memory
> hog process first, the OOM reaper can not reclaim enough memory for terminating
> the victim if the victim is consuming little memory. The result is OOM livelock
> as usual, for timeout based next OOM victim selection is not implemented.
What we should be doing is have the OOM reaper clear TIF_MEMDIE after
it's done. There is no reason to wait for and prioritize the exit of a
task that doesn't even have memory anymore. Once a task's memory has
been reaped, subsequent OOM invocations should evaluate anew the most
desirable OOM victim.
next prev parent reply other threads:[~2016-01-07 16:28 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-29 13:58 [PATCH] mm,oom: Exclude TIF_MEMDIE processes from candidates Tetsuo Handa
2015-12-29 13:58 ` Tetsuo Handa
2016-01-07 9:15 ` Michal Hocko
2016-01-07 9:15 ` Michal Hocko
2016-01-07 13:31 ` Tetsuo Handa
2016-01-07 13:31 ` Tetsuo Handa
2016-01-07 14:58 ` Michal Hocko
2016-01-07 14:58 ` Michal Hocko
2016-01-07 15:38 ` Tetsuo Handa
2016-01-07 15:38 ` Tetsuo Handa
2016-01-11 15:18 ` Michal Hocko
2016-01-11 15:18 ` Michal Hocko
2016-01-12 11:32 ` Tetsuo Handa
2016-01-12 11:32 ` Tetsuo Handa
2016-01-12 19:52 ` Michal Hocko
2016-01-12 19:52 ` Michal Hocko
2016-01-13 10:15 ` Tetsuo Handa
2016-01-13 10:15 ` Tetsuo Handa
2016-01-13 15:24 ` Michal Hocko
2016-01-13 15:24 ` Michal Hocko
2016-01-07 15:44 ` Michal Hocko
2016-01-07 15:44 ` Michal Hocko
2016-01-08 10:09 ` [PATCH v2] " Tetsuo Handa
2016-01-08 10:09 ` Tetsuo Handa
2016-01-13 0:32 ` David Rientjes
2016-01-13 0:32 ` David Rientjes
2016-01-13 10:52 ` Tetsuo Handa
2016-01-13 10:52 ` Tetsuo Handa
2016-01-14 0:57 ` David Rientjes
2016-01-14 0:57 ` David Rientjes
2016-01-14 10:26 ` Tetsuo Handa
2016-01-14 10:26 ` Tetsuo Handa
2016-01-14 21:53 ` David Rientjes
2016-01-14 21:53 ` David Rientjes
2016-01-14 22:21 ` Tetsuo Handa
2016-01-14 22:21 ` Tetsuo Handa
2016-01-07 16:28 ` Johannes Weiner [this message]
2016-01-07 16:28 ` [PATCH] " Johannes Weiner
2016-01-08 12:37 ` Michal Hocko
2016-01-08 12:37 ` Michal Hocko
2016-01-08 13:14 ` Tetsuo Handa
2016-01-08 13:14 ` Tetsuo Handa
2016-01-08 13:41 ` Michal Hocko
2016-01-08 13:41 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107162815.GA31729@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=andrea@kernel.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@kernel.org \
--cc=oleg@redhat.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.