From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Komal Shah <komal_shah802003@yahoo.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] Input: omap-keypad: set tasklet data earlier
Date: Thu, 07 Jan 2016 17:55:32 +0000 [thread overview]
Message-ID: <20160107175532.GA12332@dtor-ws> (raw)
In-Reply-To: <20160107093648.GC27186@mwanda>
On Thu, Jan 07, 2016 at 12:36:48PM +0300, Dan Carpenter wrote:
> It feels like we should set the tasklet data before enabling it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thank you.
>
> diff --git a/drivers/input/keyboard/omap-keypad.c b/drivers/input/keyboard/omap-keypad.c
> index 7502e46..75ad666 100644
> --- a/drivers/input/keyboard/omap-keypad.c
> +++ b/drivers/input/keyboard/omap-keypad.c
> @@ -292,8 +292,8 @@ static int omap_kp_probe(struct platform_device *pdev)
> setup_timer(&omap_kp->timer, omap_kp_timer, (unsigned long)omap_kp);
>
> /* get the irq and init timer*/
> - tasklet_enable(&kp_tasklet);
> kp_tasklet.data = (unsigned long) omap_kp;
> + tasklet_enable(&kp_tasklet);
>
> ret = device_create_file(&pdev->dev, &dev_attr_enable);
> if (ret < 0)
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Komal Shah <komal_shah802003@yahoo.com>,
linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] Input: omap-keypad: set tasklet data earlier
Date: Thu, 7 Jan 2016 09:55:32 -0800 [thread overview]
Message-ID: <20160107175532.GA12332@dtor-ws> (raw)
In-Reply-To: <20160107093648.GC27186@mwanda>
On Thu, Jan 07, 2016 at 12:36:48PM +0300, Dan Carpenter wrote:
> It feels like we should set the tasklet data before enabling it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thank you.
>
> diff --git a/drivers/input/keyboard/omap-keypad.c b/drivers/input/keyboard/omap-keypad.c
> index 7502e46..75ad666 100644
> --- a/drivers/input/keyboard/omap-keypad.c
> +++ b/drivers/input/keyboard/omap-keypad.c
> @@ -292,8 +292,8 @@ static int omap_kp_probe(struct platform_device *pdev)
> setup_timer(&omap_kp->timer, omap_kp_timer, (unsigned long)omap_kp);
>
> /* get the irq and init timer*/
> - tasklet_enable(&kp_tasklet);
> kp_tasklet.data = (unsigned long) omap_kp;
> + tasklet_enable(&kp_tasklet);
>
> ret = device_create_file(&pdev->dev, &dev_attr_enable);
> if (ret < 0)
--
Dmitry
next prev parent reply other threads:[~2016-01-07 17:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 9:36 [patch] Input: omap-keypad: set tasklet data earlier Dan Carpenter
2016-01-07 9:36 ` Dan Carpenter
2016-01-07 17:55 ` Dmitry Torokhov [this message]
2016-01-07 17:55 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160107175532.GA12332@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=komal_shah802003@yahoo.com \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.