From: ynezz@true.cz (Petr Štetiar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM
Date: Fri, 8 Jan 2016 09:57:34 +0100 [thread overview]
Message-ID: <20160108085734.GC27359@ibawizard.net> (raw)
In-Reply-To: <1452011942-11940-2-git-send-email-marcel.ziswiler@toradex.com>
> + i2cddc: i2c at 0 {
> + gpios = <&gpio3 16 GPIO_ACTIVE_HIGH /* sda */
> + &gpio2 30 GPIO_ACTIVE_HIGH /* scl */
> + >;
According to one of the comments, it should be changed to the following:
sda-gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
scl-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>;
-- ynezz
WARNING: multiple messages have this Message-ID (diff)
From: "Petr Štetiar" <ynezz-knWk7/PSn+s@public.gmane.org>
To: Marcel Ziswiler
<marcel.ziswiler-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
"Lucas Stach" <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"Russell King" <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
"Sascha Hauer" <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"Petr Štetiar" <ynezz-knWk7/PSn+s@public.gmane.org>,
"Shawn Guo" <shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"Fabio Estevam"
<festevam-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Kumar Gala" <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"Ian Campbell"
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
"Stefan Agner" <stefan-XLVq0VzYD2Y@public.gmane.org>,
"Joshua Clayton"
<stillcompiling-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Pawel Moll" <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"Shawn Guo" <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM
Date: Fri, 8 Jan 2016 09:57:34 +0100 [thread overview]
Message-ID: <20160108085734.GC27359@ibawizard.net> (raw)
In-Reply-To: <1452011942-11940-2-git-send-email-marcel.ziswiler-2KBjVHiyJgBBDgjK7y7TUQ@public.gmane.org>
> + i2cddc: i2c@0 {
> + gpios = <&gpio3 16 GPIO_ACTIVE_HIGH /* sda */
> + &gpio2 30 GPIO_ACTIVE_HIGH /* scl */
> + >;
According to one of the comments, it should be changed to the following:
sda-gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
scl-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>;
-- ynezz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "Petr Štetiar" <ynezz@true.cz>
To: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Cc: linux-arm-kernel@lists.infradead.org,
"Lucas Stach" <l.stach@pengutronix.de>,
"Russell King" <linux@arm.linux.org.uk>,
"Sascha Hauer" <kernel@pengutronix.de>,
"Petr Štetiar" <ynezz@true.cz>,
"Shawn Guo" <shawn.guo@linaro.org>,
"Fabio Estevam" <festevam@gmail.com>,
"Kumar Gala" <galak@codeaurora.org>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Stefan Agner" <stefan@agner.ch>,
"Joshua Clayton" <stillcompiling@gmail.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"Shawn Guo" <shawnguo@kernel.org>
Subject: Re: [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM
Date: Fri, 8 Jan 2016 09:57:34 +0100 [thread overview]
Message-ID: <20160108085734.GC27359@ibawizard.net> (raw)
In-Reply-To: <1452011942-11940-2-git-send-email-marcel.ziswiler@toradex.com>
> + i2cddc: i2c@0 {
> + gpios = <&gpio3 16 GPIO_ACTIVE_HIGH /* sda */
> + &gpio2 30 GPIO_ACTIVE_HIGH /* scl */
> + >;
According to one of the comments, it should be changed to the following:
sda-gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
scl-gpios = <&gpio2 30 GPIO_ACTIVE_HIGH>;
-- ynezz
next prev parent reply other threads:[~2016-01-08 8:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 16:39 [PATCH v2 0/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM/Ixora carrier board Marcel Ziswiler
2016-01-05 16:39 ` Marcel Ziswiler
2016-01-05 16:39 ` Marcel Ziswiler
2016-01-05 16:39 ` [PATCH v2 1/2] ARM: dts: imx6: Add support for Toradex Apalis iMX6Q/D SoM Marcel Ziswiler
2016-01-05 16:39 ` Marcel Ziswiler
2016-01-06 8:03 ` Petr Štetiar
2016-01-06 8:03 ` Petr Štetiar
2016-01-06 8:03 ` Petr Štetiar
2016-01-06 9:15 ` Marcel Ziswiler
2016-01-06 9:15 ` Marcel Ziswiler
2016-01-06 9:15 ` Marcel Ziswiler
2016-01-08 8:42 ` Petr Štetiar
2016-01-08 8:42 ` Petr Štetiar
2016-01-08 8:42 ` Petr Štetiar
2016-01-08 10:59 ` Marcel Ziswiler
2016-01-08 10:59 ` Marcel Ziswiler
2016-01-08 10:59 ` Marcel Ziswiler
2016-01-07 6:29 ` Stefan Agner
2016-01-07 6:29 ` Stefan Agner
2016-01-08 8:28 ` Marcel Ziswiler
2016-01-08 8:28 ` Marcel Ziswiler
2016-01-08 8:28 ` Marcel Ziswiler
2016-01-08 8:57 ` Petr Štetiar [this message]
2016-01-08 8:57 ` Petr Štetiar
2016-01-08 8:57 ` Petr Štetiar
2016-01-08 10:59 ` Marcel Ziswiler
2016-01-08 10:59 ` Marcel Ziswiler
2016-01-08 10:59 ` Marcel Ziswiler
2016-01-05 16:39 ` [PATCH v2 2/2] ARM: dts: imx6: Add support for Toradex Ixora carrier board Marcel Ziswiler
2016-01-05 16:39 ` Marcel Ziswiler
2016-01-07 6:38 ` Stefan Agner
2016-01-07 6:38 ` Stefan Agner
2016-01-07 6:38 ` Stefan Agner
2016-01-08 8:29 ` Marcel Ziswiler
2016-01-08 8:29 ` Marcel Ziswiler
2016-01-08 8:29 ` Marcel Ziswiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108085734.GC27359@ibawizard.net \
--to=ynezz@true.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.