* [patch] irda: toim3232-sir: delete some dead code
@ 2016-01-08 11:04 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-01-08 11:04 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: netdev, kernel-janitors
I noticed this code because it has a typo in the module_param(),
the "trs" at the end of "toim3232fliptrs" should be "rts". But it's
dead code so instead of fixing it, I just deleted it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/irda/toim3232-sir.c b/drivers/net/irda/toim3232-sir.c
index 6d2f559..b977d6d 100644
--- a/drivers/net/irda/toim3232-sir.c
+++ b/drivers/net/irda/toim3232-sir.c
@@ -130,16 +130,6 @@ static int toim3232delay = 150; /* default is 150 ms */
module_param(toim3232delay, int, 0);
MODULE_PARM_DESC(toim3232delay, "toim3232 dongle write complete delay");
-#if 0
-static int toim3232flipdtr = 0; /* default is DTR high to reset */
-module_param(toim3232flipdtr, int, 0);
-MODULE_PARM_DESC(toim3232flipdtr, "toim3232 dongle invert DTR (Reset)");
-
-static int toim3232fliprts = 0; /* default is RTS high for baud change */
-module_param(toim3232fliptrs, int, 0);
-MODULE_PARM_DESC(toim3232fliprts, "toim3232 dongle invert RTS (BR/D)");
-#endif
-
static int toim3232_open(struct sir_dev *);
static int toim3232_close(struct sir_dev *);
static int toim3232_change_speed(struct sir_dev *, unsigned);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch] irda: toim3232-sir: delete some dead code
@ 2016-01-08 11:04 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-01-08 11:04 UTC (permalink / raw)
To: Samuel Ortiz; +Cc: netdev, kernel-janitors
I noticed this code because it has a typo in the module_param(),
the "trs" at the end of "toim3232fliptrs" should be "rts". But it's
dead code so instead of fixing it, I just deleted it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/irda/toim3232-sir.c b/drivers/net/irda/toim3232-sir.c
index 6d2f559..b977d6d 100644
--- a/drivers/net/irda/toim3232-sir.c
+++ b/drivers/net/irda/toim3232-sir.c
@@ -130,16 +130,6 @@ static int toim3232delay = 150; /* default is 150 ms */
module_param(toim3232delay, int, 0);
MODULE_PARM_DESC(toim3232delay, "toim3232 dongle write complete delay");
-#if 0
-static int toim3232flipdtr = 0; /* default is DTR high to reset */
-module_param(toim3232flipdtr, int, 0);
-MODULE_PARM_DESC(toim3232flipdtr, "toim3232 dongle invert DTR (Reset)");
-
-static int toim3232fliprts = 0; /* default is RTS high for baud change */
-module_param(toim3232fliptrs, int, 0);
-MODULE_PARM_DESC(toim3232fliprts, "toim3232 dongle invert RTS (BR/D)");
-#endif
-
static int toim3232_open(struct sir_dev *);
static int toim3232_close(struct sir_dev *);
static int toim3232_change_speed(struct sir_dev *, unsigned);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch] irda: toim3232-sir: delete some dead code
2016-01-08 11:04 ` Dan Carpenter
@ 2016-01-08 18:27 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-01-08 18:27 UTC (permalink / raw)
To: dan.carpenter; +Cc: samuel, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 8 Jan 2016 14:04:04 +0300
> I noticed this code because it has a typo in the module_param(),
> the "trs" at the end of "toim3232fliptrs" should be "rts". But it's
> dead code so instead of fixing it, I just deleted it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Also applied, thanks Dan.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch] irda: toim3232-sir: delete some dead code
@ 2016-01-08 18:27 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2016-01-08 18:27 UTC (permalink / raw)
To: dan.carpenter; +Cc: samuel, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 8 Jan 2016 14:04:04 +0300
> I noticed this code because it has a typo in the module_param(),
> the "trs" at the end of "toim3232fliptrs" should be "rts". But it's
> dead code so instead of fixing it, I just deleted it.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Also applied, thanks Dan.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-01-08 18:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-08 11:04 [patch] irda: toim3232-sir: delete some dead code Dan Carpenter
2016-01-08 11:04 ` Dan Carpenter
2016-01-08 18:27 ` David Miller
2016-01-08 18:27 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.