From: Bjorn Helgaas <helgaas@kernel.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] shpchp: constify hpc_ops structure
Date: Fri, 08 Jan 2016 18:11:26 +0000 [thread overview]
Message-ID: <20160108181126.GD5354@localhost> (raw)
In-Reply-To: <1450902935-20302-1-git-send-email-Julia.Lawall@lip6.fr>
On Wed, Dec 23, 2015 at 09:35:35PM +0100, Julia Lawall wrote:
> The hpc_ops structure is never modified, so declare it as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied to pci/trivial for v4.5, thanks, Julia!
> ---
> drivers/pci/hotplug/shpchp.h | 4 ++--
> drivers/pci/hotplug/shpchp_hpc.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/hotplug/shpchp.h b/drivers/pci/hotplug/shpchp.h
> index 5897d51..3059c34 100644
> --- a/drivers/pci/hotplug/shpchp.h
> +++ b/drivers/pci/hotplug/shpchp.h
> @@ -84,7 +84,7 @@ struct slot {
> u8 presence_save;
> u8 pwr_save;
> struct controller *ctrl;
> - struct hpc_ops *hpc_ops;
> + const struct hpc_ops *hpc_ops;
> struct hotplug_slot *hotplug_slot;
> struct list_head slot_list;
> struct delayed_work work; /* work for button event */
> @@ -106,7 +106,7 @@ struct controller {
> int slot_num_inc; /* 1 or -1 */
> struct pci_dev *pci_dev;
> struct list_head slot_list;
> - struct hpc_ops *hpc_ops;
> + const struct hpc_ops *hpc_ops;
> wait_queue_head_t queue; /* sleep & wake process */
> u8 slot_device_offset;
> u32 pcix_misc2_reg; /* for amd pogo errata */
> diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c
> index 7d223e9..43e7906 100644
> --- a/drivers/pci/hotplug/shpchp_hpc.c
> +++ b/drivers/pci/hotplug/shpchp_hpc.c
> @@ -910,7 +910,7 @@ static int shpc_get_max_bus_speed(struct controller *ctrl)
> return retval;
> }
>
> -static struct hpc_ops shpchp_hpc_ops = {
> +static const struct hpc_ops shpchp_hpc_ops = {
> .power_on_slot = hpc_power_on_slot,
> .slot_enable = hpc_slot_enable,
> .slot_disable = hpc_slot_disable,
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH] shpchp: constify hpc_ops structure
Date: Fri, 8 Jan 2016 12:11:26 -0600 [thread overview]
Message-ID: <20160108181126.GD5354@localhost> (raw)
In-Reply-To: <1450902935-20302-1-git-send-email-Julia.Lawall@lip6.fr>
On Wed, Dec 23, 2015 at 09:35:35PM +0100, Julia Lawall wrote:
> The hpc_ops structure is never modified, so declare it as const.
>
> Done with the help of Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Applied to pci/trivial for v4.5, thanks, Julia!
> ---
> drivers/pci/hotplug/shpchp.h | 4 ++--
> drivers/pci/hotplug/shpchp_hpc.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pci/hotplug/shpchp.h b/drivers/pci/hotplug/shpchp.h
> index 5897d51..3059c34 100644
> --- a/drivers/pci/hotplug/shpchp.h
> +++ b/drivers/pci/hotplug/shpchp.h
> @@ -84,7 +84,7 @@ struct slot {
> u8 presence_save;
> u8 pwr_save;
> struct controller *ctrl;
> - struct hpc_ops *hpc_ops;
> + const struct hpc_ops *hpc_ops;
> struct hotplug_slot *hotplug_slot;
> struct list_head slot_list;
> struct delayed_work work; /* work for button event */
> @@ -106,7 +106,7 @@ struct controller {
> int slot_num_inc; /* 1 or -1 */
> struct pci_dev *pci_dev;
> struct list_head slot_list;
> - struct hpc_ops *hpc_ops;
> + const struct hpc_ops *hpc_ops;
> wait_queue_head_t queue; /* sleep & wake process */
> u8 slot_device_offset;
> u32 pcix_misc2_reg; /* for amd pogo errata */
> diff --git a/drivers/pci/hotplug/shpchp_hpc.c b/drivers/pci/hotplug/shpchp_hpc.c
> index 7d223e9..43e7906 100644
> --- a/drivers/pci/hotplug/shpchp_hpc.c
> +++ b/drivers/pci/hotplug/shpchp_hpc.c
> @@ -910,7 +910,7 @@ static int shpc_get_max_bus_speed(struct controller *ctrl)
> return retval;
> }
>
> -static struct hpc_ops shpchp_hpc_ops = {
> +static const struct hpc_ops shpchp_hpc_ops = {
> .power_on_slot = hpc_power_on_slot,
> .slot_enable = hpc_slot_enable,
> .slot_disable = hpc_slot_disable,
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-08 18:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 20:35 [PATCH] shpchp: constify hpc_ops structure Julia Lawall
2015-12-23 20:35 ` Julia Lawall
2016-01-08 18:11 ` Bjorn Helgaas [this message]
2016-01-08 18:11 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108181126.GD5354@localhost \
--to=helgaas@kernel.org \
--cc=Julia.Lawall@lip6.fr \
--cc=bhelgaas@google.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.