From: Theodore Ts'o <tytso@mit.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext4 crypto: unlock on error in ext4_set_encryption_metadata()
Date: Fri, 08 Jan 2016 20:36:26 +0000 [thread overview]
Message-ID: <20160108203626.GD28412@thunk.org> (raw)
In-Reply-To: <20160105095719.GF23619@mwanda>
On Tue, Jan 05, 2016 at 12:57:19PM +0300, Dan Carpenter wrote:
> There is a missing unlock if ext4_journal_start() fails.
>
> Fixes: 374431bae296 ('ext4 crypto: add ioctls to allow backup of encryption metadata')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for pointing this out! I've fixed this by folded this into the
appropriate commit.
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: Theodore Ts'o <tytso@mit.edu>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext4 crypto: unlock on error in ext4_set_encryption_metadata()
Date: Fri, 8 Jan 2016 15:36:26 -0500 [thread overview]
Message-ID: <20160108203626.GD28412@thunk.org> (raw)
In-Reply-To: <20160105095719.GF23619@mwanda>
On Tue, Jan 05, 2016 at 12:57:19PM +0300, Dan Carpenter wrote:
> There is a missing unlock if ext4_journal_start() fails.
>
> Fixes: 374431bae296 ('ext4 crypto: add ioctls to allow backup of encryption metadata')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks for pointing this out! I've fixed this by folded this into the
appropriate commit.
- Ted
next prev parent reply other threads:[~2016-01-08 20:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 9:57 [patch] ext4 crypto: unlock on error in ext4_set_encryption_metadata() Dan Carpenter
2016-01-05 9:57 ` Dan Carpenter
2016-01-08 20:36 ` Theodore Ts'o [this message]
2016-01-08 20:36 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160108203626.GD28412@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.