From: hzpeterchen@gmail.com (Peter Chen)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/2] USB: core: let USB device know device node
Date: Sat, 9 Jan 2016 16:56:53 +0800 [thread overview]
Message-ID: <20160109085653.GB27759@shlinux2> (raw)
In-Reply-To: <11330516.E3pzCBVn95@wuerfel>
On Fri, Jan 08, 2016 at 09:22:22AM +0100, Arnd Bergmann wrote:
> On Friday 08 January 2016 13:44:23 Peter Chen wrote:
> > +struct device_node *usb_of_find_node(struct device_node *parent, int portnum)
> > +{
> > + struct device_node *node;
> > + u32 port;
> > +
> > + for_each_child_of_node(parent, node) {
> > + if (!of_property_read_u32(node, "reg", &port)) {
> > + if (port == portnum)
> > + return node;
> > + }
> > + }
> > +
> > + return NULL;
> > +}
> > +EXPORT_SYMBOL_GPL(usb_of_find_node);
>
> The implementation looks good to me, but I find the function name slightly
> confusing. We use "*find_node" or similar names in other subsystems to
> scan the entire tree, when this one just looks at the immediate children
> of the device.
>
> Maybe something like "usb_of_get_child_node()" instead?
>
Ok, thanks.
--
Best Regards,
Peter Chen
WARNING: multiple messages have this Message-ID (diff)
From: Peter Chen <hzpeterchen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
Cc: Peter Chen <peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
balbi-l0cyMroinI0@public.gmane.org,
valentin.longchamp-SkAbAL50j+5BDgjK7y7TUQ@public.gmane.org
Subject: Re: [RFC PATCH 1/2] USB: core: let USB device know device node
Date: Sat, 9 Jan 2016 16:56:53 +0800 [thread overview]
Message-ID: <20160109085653.GB27759@shlinux2> (raw)
In-Reply-To: <11330516.E3pzCBVn95@wuerfel>
On Fri, Jan 08, 2016 at 09:22:22AM +0100, Arnd Bergmann wrote:
> On Friday 08 January 2016 13:44:23 Peter Chen wrote:
> > +struct device_node *usb_of_find_node(struct device_node *parent, int portnum)
> > +{
> > + struct device_node *node;
> > + u32 port;
> > +
> > + for_each_child_of_node(parent, node) {
> > + if (!of_property_read_u32(node, "reg", &port)) {
> > + if (port == portnum)
> > + return node;
> > + }
> > + }
> > +
> > + return NULL;
> > +}
> > +EXPORT_SYMBOL_GPL(usb_of_find_node);
>
> The implementation looks good to me, but I find the function name slightly
> confusing. We use "*find_node" or similar names in other subsystems to
> scan the entire tree, when this one just looks at the immediate children
> of the device.
>
> Maybe something like "usb_of_get_child_node()" instead?
>
Ok, thanks.
--
Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-09 8:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 5:44 [RFC PATCH 0/2] USB: let the USB device know device node Peter Chen
2016-01-08 5:44 ` Peter Chen
2016-01-08 5:44 ` [RFC PATCH 1/2] USB: core: let " Peter Chen
2016-01-08 5:44 ` Peter Chen
2016-01-08 8:22 ` Arnd Bergmann
2016-01-08 8:22 ` Arnd Bergmann
2016-01-09 8:56 ` Peter Chen [this message]
2016-01-09 8:56 ` Peter Chen
2016-01-08 14:32 ` Rob Herring
2016-01-08 14:32 ` Rob Herring
2016-01-09 9:05 ` Peter Chen
2016-01-09 9:05 ` Peter Chen
2016-01-09 15:20 ` Rob Herring
2016-01-09 15:20 ` Rob Herring
2016-01-08 22:50 ` Alan Stern
2016-01-08 22:50 ` Alan Stern
2016-01-09 9:32 ` Peter Chen
2016-01-09 9:32 ` Peter Chen
2016-01-08 5:44 ` [RFC PATCH 2/2] usb: Example for how to use device node at usb device driver Peter Chen
2016-01-08 5:44 ` Peter Chen
2016-01-08 8:26 ` Arnd Bergmann
2016-01-08 8:26 ` Arnd Bergmann
2016-01-09 8:57 ` Peter Chen
2016-01-09 8:57 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160109085653.GB27759@shlinux2 \
--to=hzpeterchen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.