All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: nimisolo <nimisolo@gmail.com>
Cc: josh@joshtriplett.org, rostedt@goodmis.org,
	mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu/tree: use true/false to set rdp->core_needs_qs
Date: Sat, 9 Jan 2016 08:42:37 -0800	[thread overview]
Message-ID: <20160109164237.GG3818@linux.vnet.ibm.com> (raw)
In-Reply-To: <1452338584-3373-1-git-send-email-nimisolo@gmail.com>

On Sat, Jan 09, 2016 at 06:23:04AM -0500, nimisolo wrote:
> Maybe it's better to set rdp->core_needs_qs with true/false
> 
> Signed-off-by: nimisolo <nimisolo@gmail.com>

Good catch, but someone beat you by about a month.

To check for future changes, please see branch rcu/dev of:

git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git

							Thanx, Paul

> ---
>  kernel/rcu/tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index f07343b..0c0d09d 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -2377,7 +2377,7 @@ rcu_report_qs_rdp(int cpu, struct rcu_state *rsp, struct rcu_data *rdp)
>  	if ((rnp->qsmask & mask) == 0) {
>  		raw_spin_unlock_irqrestore(&rnp->lock, flags);
>  	} else {
> -		rdp->core_needs_qs = 0;
> +		rdp->core_needs_qs = false;
> 
>  		/*
>  		 * This GP can't end until cpu checks in, so all of our
> -- 
> 2.5.0
> 

      reply	other threads:[~2016-01-09 16:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-09 11:23 [PATCH] rcu/tree: use true/false to set rdp->core_needs_qs nimisolo
2016-01-09 16:42 ` Paul E. McKenney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160109164237.GG3818@linux.vnet.ibm.com \
    --to=paulmck@linux.vnet.ibm.com \
    --cc=jiangshanlai@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=nimisolo@gmail.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.