From: "Michael S. Tsirkin" <mst@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>,
Peter Zijlstra <peterz@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org,
Andrew Cooper <andrew.cooper3@citrix.com>,
virtualization@lists.linux-foundation.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
David Miller <davem@davemloft.net>,
linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-metag@vger.kernel.org, linux-mips@linux-mips.org,
x86@kernel.org, user-mode-linux-devel@lists.sourceforge.net,
adi-buildroot-devel@lists.sourceforge.net,
linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org,
xen-devel@lists.xenproject.org, Ingo Molnar <mingo@kernel.org>,
Tony
Subject: Re: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers
Date: Sun, 10 Jan 2016 21:29:06 +0200 [thread overview]
Message-ID: <20160110212531-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1452439051.7773.27.camel@perches.com>
On Sun, Jan 10, 2016 at 07:17:31AM -0800, Joe Perches wrote:
> On Sun, 2016-01-10 at 07:07 -0800, Joe Perches wrote:
> > On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote:
> > > SMP-only barriers were missing in checkpatch.pl
> > >
> > > Refactor code slightly to make adding more variants easier.
> > []
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > If I use a variable called $smp_barriers, I'd expect
> > it to actually be the smp_barriers, not to have to
> > prefix it with smp_ before using it.
> >
> > my $smp_barriers = qr{
> > smp_store_release|
> > smp_load_acquire|
> > smp_store_mb|
> > smp_read_barrier_depends
>
> That's missing (?:barriers) too.
My version has it but need to add ?: to avoid
a capture group.
> btw: shouldn't this also have
> smp_mb__(?:before|after)_atomic
> ?
Good catch, included in the next version.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>,
Peter Zijlstra <peterz@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org,
Andrew Cooper <andrew.cooper3@citrix.com>,
virtualization@lists.linux-foundation.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
David Miller <davem@davemloft.net>,
linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-metag@vger.kernel.org, linux-mips@linux-mips.org,
x86@kernel.org, user-mode-linux-devel@lists.sourceforge.net,
adi-buildroot-devel@lists.sourceforge.net,
linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org,
xen-devel@lists.xenproject.org, Ingo Molnar <mingo@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Andrey Konovalov <andreyknvl@google.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Subject: Re: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers
Date: Sun, 10 Jan 2016 21:29:06 +0200 [thread overview]
Message-ID: <20160110212531-mutt-send-email-mst@redhat.com> (raw)
Message-ID: <20160110192906.inuj38llmwNJ4ZWq4OHxilqdKlM3ig8HzLFs02WtIvY@z> (raw)
In-Reply-To: <1452439051.7773.27.camel@perches.com>
On Sun, Jan 10, 2016 at 07:17:31AM -0800, Joe Perches wrote:
> On Sun, 2016-01-10 at 07:07 -0800, Joe Perches wrote:
> > On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote:
> > > SMP-only barriers were missing in checkpatch.pl
> > >
> > > Refactor code slightly to make adding more variants easier.
> > []
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > If I use a variable called $smp_barriers, I'd expect
> > it to actually be the smp_barriers, not to have to
> > prefix it with smp_ before using it.
> >
> > my $smp_barriers = qr{
> > smp_store_release|
> > smp_load_acquire|
> > smp_store_mb|
> > smp_read_barrier_depends
>
> That's missing (?:barriers) too.
My version has it but need to add ?: to avoid
a capture group.
> btw: shouldn't this also have
> smp_mb__(?:before|after)_atomic
> ?
Good catch, included in the next version.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, Andy Whitcroft <apw@canonical.com>,
Peter Zijlstra <peterz@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org,
Andrew Cooper <andrew.cooper3@citrix.com>,
virtualization@lists.linux-foundation.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
David Miller <davem@davemloft.net>,
linux-ia64@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-s390@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-metag@vger.kernel.org, linux-mips@linux-mips.org,
x86@kernel.org, user-mode-linux-devel@lists.sourceforge.net,
adi-buildroot-devel@lists.sourceforge.net,
linux-sh@vger.kernel.org, linux-xtensa@linux-xtensa.org,
xen-devel@lists.xenproject.org, Ingo Molnar <mingo@kernel.org>,
Tony
Subject: Re: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers
Date: Sun, 10 Jan 2016 19:29:06 +0000 [thread overview]
Message-ID: <20160110212531-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1452439051.7773.27.camel@perches.com>
On Sun, Jan 10, 2016 at 07:17:31AM -0800, Joe Perches wrote:
> On Sun, 2016-01-10 at 07:07 -0800, Joe Perches wrote:
> > On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote:
> > > SMP-only barriers were missing in checkpatch.pl
> > >
> > > Refactor code slightly to make adding more variants easier.
> > []
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > If I use a variable called $smp_barriers, I'd expect
> > it to actually be the smp_barriers, not to have to
> > prefix it with smp_ before using it.
> >
> > my $smp_barriers = qr{
> > smp_store_release|
> > smp_load_acquire|
> > smp_store_mb|
> > smp_read_barrier_depends
>
> That's missing (?:barriers) too.
My version has it but need to add ?: to avoid
a capture group.
> btw: shouldn't this also have
> smp_mb__(?:before|after)_atomic
> ?
Good catch, included in the next version.
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: mst@redhat.com (Michael S. Tsirkin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/3] checkpatch.pl: add missing memory barriers
Date: Sun, 10 Jan 2016 21:29:06 +0200 [thread overview]
Message-ID: <20160110212531-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1452439051.7773.27.camel@perches.com>
On Sun, Jan 10, 2016 at 07:17:31AM -0800, Joe Perches wrote:
> On Sun, 2016-01-10 at 07:07 -0800, Joe Perches wrote:
> > On Sun, 2016-01-10 at 13:56 +0200, Michael S. Tsirkin wrote:
> > > SMP-only barriers were missing in checkpatch.pl
> > >
> > > Refactor code slightly to make adding more variants easier.
> > []
> > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> []
> > If I use a variable called $smp_barriers, I'd expect
> > it to actually be the smp_barriers, not to have to
> > prefix it with smp_ before using it.
> >
> > my $smp_barriers = qr{
> > smp_store_release|
> > smp_load_acquire|
> > smp_store_mb|
> > smp_read_barrier_depends
>
> That's missing (?:barriers) too.
My version has it but need to add ?: to avoid
a capture group.
> btw: shouldn't this also have
> smp_mb__(?:before|after)_atomic
> ?
Good catch, included in the next version.
--
MST
next prev parent reply other threads:[~2016-01-10 19:29 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 11:56 [PATCH v2 0/3] checkpatch: handling of memory barriers Michael S. Tsirkin
2016-01-10 11:56 ` Michael S. Tsirkin
2016-01-10 11:56 ` Michael S. Tsirkin
2016-01-10 11:56 ` Michael S. Tsirkin
2016-01-10 11:56 ` [PATCH v2 1/3] checkpatch.pl: add missing " Michael S. Tsirkin
2016-01-10 11:56 ` Michael S. Tsirkin
2016-01-10 11:56 ` Michael S. Tsirkin
2016-01-10 11:56 ` Michael S. Tsirkin
2016-01-10 11:56 ` Michael S. Tsirkin
2016-01-10 15:07 ` Joe Perches
2016-01-10 15:07 ` Joe Perches
2016-01-10 15:07 ` Joe Perches
2016-01-10 15:07 ` Joe Perches
2016-01-10 15:07 ` Joe Perches
2016-01-10 15:07 ` Joe Perches
2016-01-10 15:07 ` Joe Perches
2016-01-10 15:17 ` Joe Perches
2016-01-10 15:17 ` Joe Perches
[not found] ` <1452438425.7773.21.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2016-01-10 15:17 ` Joe Perches
2016-01-10 15:17 ` Joe Perches
2016-01-10 15:17 ` Joe Perches
2016-01-10 15:17 ` Joe Perches
2016-01-10 19:29 ` Michael S. Tsirkin
2016-01-10 19:29 ` Michael S. Tsirkin
2016-01-10 19:29 ` Michael S. Tsirkin [this message]
2016-01-10 19:29 ` Michael S. Tsirkin
2016-01-10 19:29 ` Michael S. Tsirkin
2016-01-10 19:29 ` Michael S. Tsirkin
2016-01-10 19:13 ` Michael S. Tsirkin
2016-01-10 19:13 ` Michael S. Tsirkin
2016-01-10 19:13 ` Michael S. Tsirkin
2016-01-10 19:13 ` Michael S. Tsirkin
2016-01-10 19:13 ` Michael S. Tsirkin
2016-01-10 19:13 ` Michael S. Tsirkin
2016-01-10 19:13 ` Michael S. Tsirkin
2016-01-10 11:56 ` Michael S. Tsirkin
2016-01-10 11:57 ` [PATCH v2 2/3] checkpatch: check for __smp outside barrier.h Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 15:08 ` Joe Perches
2016-01-10 15:08 ` Joe Perches
2016-01-10 15:08 ` Joe Perches
2016-01-10 15:08 ` Joe Perches
2016-01-10 15:08 ` Joe Perches
2016-01-10 15:08 ` Joe Perches
2016-01-10 15:08 ` Joe Perches
2016-01-10 11:57 ` [PATCH v2 3/3] checkpatch: add virt barriers Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
2016-01-10 11:57 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160110212531-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=andrew.cooper3@citrix.com \
--cc=apw@canonical.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-metag@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mingo@elte.hu \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=sparclinux@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tglx@linutronix.de \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.