From: Minchan Kim <minchan@kernel.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Konstantin Khlebnikov <koct9i@gmail.com>,
Rafael Aquini <aquini@redhat.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] virtio_balloon: fix race between migration and ballooning
Date: Mon, 11 Jan 2016 08:54:09 +0900 [thread overview]
Message-ID: <20160110235409.GA7452@bbox> (raw)
In-Reply-To: <20160110233310-mutt-send-email-mst@redhat.com>
On Sun, Jan 10, 2016 at 11:40:17PM +0200, Michael S. Tsirkin wrote:
> On Mon, Jan 04, 2016 at 09:27:47AM +0900, Minchan Kim wrote:
> > > I think this will cause deadlocks.
> > >
> > > pages_lock now nests within page lock, balloon_page_putback
> > > nests them in the reverse order.
> >
> > In balloon_page_dequeu, we used trylock so I don't think it's
> > deadlock.
>
> I went over this again and I don't see the issue anymore.
> I think I was mistaken, so I dropped my patch and picked
> up yours. Sorry about the noise.
No problem. Thanks for the review.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Konstantin Khlebnikov <koct9i@gmail.com>,
Rafael Aquini <aquini@redhat.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 2/2] virtio_balloon: fix race between migration and ballooning
Date: Mon, 11 Jan 2016 08:54:09 +0900 [thread overview]
Message-ID: <20160110235409.GA7452@bbox> (raw)
In-Reply-To: <20160110233310-mutt-send-email-mst@redhat.com>
On Sun, Jan 10, 2016 at 11:40:17PM +0200, Michael S. Tsirkin wrote:
> On Mon, Jan 04, 2016 at 09:27:47AM +0900, Minchan Kim wrote:
> > > I think this will cause deadlocks.
> > >
> > > pages_lock now nests within page lock, balloon_page_putback
> > > nests them in the reverse order.
> >
> > In balloon_page_dequeu, we used trylock so I don't think it's
> > deadlock.
>
> I went over this again and I don't see the issue anymore.
> I think I was mistaken, so I dropped my patch and picked
> up yours. Sorry about the noise.
No problem. Thanks for the review.
next prev parent reply other threads:[~2016-01-10 23:52 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-27 23:35 [PATCH 1/2] virtio_balloon: fix race by fill and leak Minchan Kim
2015-12-27 23:35 ` Minchan Kim
2015-12-27 23:35 ` Minchan Kim
2015-12-27 23:35 ` [PATCH 2/2] virtio_balloon: fix race between migration and ballooning Minchan Kim
2015-12-27 23:35 ` Minchan Kim
2015-12-27 23:35 ` Minchan Kim
2015-12-27 23:36 ` Rafael Aquini
2015-12-27 23:36 ` Rafael Aquini
2015-12-27 23:36 ` Rafael Aquini
2016-01-01 9:36 ` Michael S. Tsirkin
2016-01-01 9:36 ` Michael S. Tsirkin
2016-01-04 0:27 ` Minchan Kim
2016-01-04 0:27 ` Minchan Kim
2016-01-04 0:27 ` Minchan Kim
2016-01-10 21:40 ` Michael S. Tsirkin
2016-01-10 21:40 ` Michael S. Tsirkin
2016-01-10 23:54 ` Minchan Kim [this message]
2016-01-10 23:54 ` Minchan Kim
2016-01-10 23:54 ` Minchan Kim
2016-01-10 21:40 ` Michael S. Tsirkin
2016-01-08 19:56 ` Rafael Aquini
2016-01-08 19:56 ` Rafael Aquini
2016-01-08 23:43 ` Minchan Kim
2016-01-08 23:43 ` Minchan Kim
2016-01-08 23:43 ` Minchan Kim
2016-01-09 21:43 ` Michael S. Tsirkin
2016-01-09 21:43 ` Michael S. Tsirkin
2016-01-09 21:43 ` Michael S. Tsirkin
2016-01-09 23:03 ` Rafael Aquini
2016-01-09 23:03 ` Rafael Aquini
2016-01-09 23:03 ` Rafael Aquini
2016-01-08 19:56 ` Rafael Aquini
2016-01-01 9:36 ` Michael S. Tsirkin
2015-12-27 23:35 ` Minchan Kim
2015-12-27 23:36 ` [PATCH 1/2] virtio_balloon: fix race by fill and leak Rafael Aquini
2015-12-27 23:36 ` Rafael Aquini
2015-12-27 23:36 ` Rafael Aquini
2016-01-01 8:26 ` Michael S. Tsirkin
2016-01-01 8:26 ` Michael S. Tsirkin
2016-01-01 8:26 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160110235409.GA7452@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=koct9i@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=stable@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.