All of lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 5/9] mfd: axp20x: Whitespace, open parenthesis alignment code style fixes
Date: Mon, 11 Jan 2016 09:24:54 +0000	[thread overview]
Message-ID: <20160111092454.GJ14104@x1> (raw)
In-Reply-To: <1450283538-25067-6-git-send-email-wens@csie.org>

On Thu, 17 Dec 2015, Chen-Yu Tsai wrote:

> This fixes some leftover code style issues in the axp20x core.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>  drivers/mfd/axp20x.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>

> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 631ad64ddf69..54a00168da26 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -591,14 +591,14 @@ int axp20x_match_device(struct axp20x_dev *axp20x)
>  			dev_err(dev, "Unable to match OF ID\n");
>  			return -ENODEV;
>  		}
> -		axp20x->variant = (long) of_id->data;
> +		axp20x->variant = (long)of_id->data;
>  	} else {
>  		acpi_id = acpi_match_device(dev->driver->acpi_match_table, dev);
>  		if (!acpi_id || !acpi_id->driver_data) {
>  			dev_err(dev, "Unable to match ACPI ID and data\n");
>  			return -ENODEV;
>  		}
> -		axp20x->variant = (long) acpi_id->driver_data;
> +		axp20x->variant = (long)acpi_id->driver_data;
>  	}
>  
>  	switch (axp20x->variant) {
> @@ -632,7 +632,7 @@ int axp20x_match_device(struct axp20x_dev *axp20x)
>  		return -EINVAL;
>  	}
>  	dev_info(dev, "AXP20x variant %s found\n",
> -		axp20x_model_names[axp20x->variant]);
> +		 axp20x_model_names[axp20x->variant]);
>  
>  	return 0;
>  }
> @@ -652,7 +652,7 @@ int axp20x_device_probe(struct axp20x_dev *axp20x)
>  	}
>  
>  	ret = mfd_add_devices(axp20x->dev, -1, axp20x->cells,
> -			axp20x->nr_cells, NULL, 0, NULL);
> +			      axp20x->nr_cells, NULL, 0, NULL);
>  
>  	if (ret) {
>  		dev_err(axp20x->dev, "failed to add MFD devices: %d\n", ret);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
Cc: Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Chen-Yu Tsai <wens-9oqZluOz41k@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Andy Shevchenko
	<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v6 5/9] mfd: axp20x: Whitespace, open parenthesis alignment code style fixes
Date: Mon, 11 Jan 2016 09:24:54 +0000	[thread overview]
Message-ID: <20160111092454.GJ14104@x1> (raw)
In-Reply-To: <1450283538-25067-6-git-send-email-wens-jdAy2FN1RRM@public.gmane.org>

On Thu, 17 Dec 2015, Chen-Yu Tsai wrote:

> This fixes some leftover code style issues in the axp20x core.
> 
> Signed-off-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
> ---
>  drivers/mfd/axp20x.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Acked-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 631ad64ddf69..54a00168da26 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -591,14 +591,14 @@ int axp20x_match_device(struct axp20x_dev *axp20x)
>  			dev_err(dev, "Unable to match OF ID\n");
>  			return -ENODEV;
>  		}
> -		axp20x->variant = (long) of_id->data;
> +		axp20x->variant = (long)of_id->data;
>  	} else {
>  		acpi_id = acpi_match_device(dev->driver->acpi_match_table, dev);
>  		if (!acpi_id || !acpi_id->driver_data) {
>  			dev_err(dev, "Unable to match ACPI ID and data\n");
>  			return -ENODEV;
>  		}
> -		axp20x->variant = (long) acpi_id->driver_data;
> +		axp20x->variant = (long)acpi_id->driver_data;
>  	}
>  
>  	switch (axp20x->variant) {
> @@ -632,7 +632,7 @@ int axp20x_match_device(struct axp20x_dev *axp20x)
>  		return -EINVAL;
>  	}
>  	dev_info(dev, "AXP20x variant %s found\n",
> -		axp20x_model_names[axp20x->variant]);
> +		 axp20x_model_names[axp20x->variant]);
>  
>  	return 0;
>  }
> @@ -652,7 +652,7 @@ int axp20x_device_probe(struct axp20x_dev *axp20x)
>  	}
>  
>  	ret = mfd_add_devices(axp20x->dev, -1, axp20x->cells,
> -			axp20x->nr_cells, NULL, 0, NULL);
> +			      axp20x->nr_cells, NULL, 0, NULL);
>  
>  	if (ret) {
>  		dev_err(axp20x->dev, "failed to add MFD devices: %d\n", ret);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
	Chen-Yu Tsai <wens@wens.tw>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
	Hans de Goede <hdegoede@redhat.com>,
	Mark Brown <broonie@kernel.org>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v6 5/9] mfd: axp20x: Whitespace, open parenthesis alignment code style fixes
Date: Mon, 11 Jan 2016 09:24:54 +0000	[thread overview]
Message-ID: <20160111092454.GJ14104@x1> (raw)
In-Reply-To: <1450283538-25067-6-git-send-email-wens@csie.org>

On Thu, 17 Dec 2015, Chen-Yu Tsai wrote:

> This fixes some leftover code style issues in the axp20x core.
> 
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>  drivers/mfd/axp20x.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Acked-by: Lee Jones <lee.jones@linaro.org>

> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 631ad64ddf69..54a00168da26 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -591,14 +591,14 @@ int axp20x_match_device(struct axp20x_dev *axp20x)
>  			dev_err(dev, "Unable to match OF ID\n");
>  			return -ENODEV;
>  		}
> -		axp20x->variant = (long) of_id->data;
> +		axp20x->variant = (long)of_id->data;
>  	} else {
>  		acpi_id = acpi_match_device(dev->driver->acpi_match_table, dev);
>  		if (!acpi_id || !acpi_id->driver_data) {
>  			dev_err(dev, "Unable to match ACPI ID and data\n");
>  			return -ENODEV;
>  		}
> -		axp20x->variant = (long) acpi_id->driver_data;
> +		axp20x->variant = (long)acpi_id->driver_data;
>  	}
>  
>  	switch (axp20x->variant) {
> @@ -632,7 +632,7 @@ int axp20x_match_device(struct axp20x_dev *axp20x)
>  		return -EINVAL;
>  	}
>  	dev_info(dev, "AXP20x variant %s found\n",
> -		axp20x_model_names[axp20x->variant]);
> +		 axp20x_model_names[axp20x->variant]);
>  
>  	return 0;
>  }
> @@ -652,7 +652,7 @@ int axp20x_device_probe(struct axp20x_dev *axp20x)
>  	}
>  
>  	ret = mfd_add_devices(axp20x->dev, -1, axp20x->cells,
> -			axp20x->nr_cells, NULL, 0, NULL);
> +			      axp20x->nr_cells, NULL, 0, NULL);
>  
>  	if (ret) {
>  		dev_err(axp20x->dev, "failed to add MFD devices: %d\n", ret);

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2016-01-11  9:24 UTC|newest]

Thread overview: 65+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-16 16:32 [PATCH v6 0/9] mfd: axp20x: Add support for RSB based AXP223 Chen-Yu Tsai
2015-12-16 16:32 ` Chen-Yu Tsai
2015-12-16 16:32 ` Chen-Yu Tsai
2015-12-16 16:32 ` [PATCH v6 1/9] mfd: axp20x: Add AXP223 to list of supported PMICs in DT bindings Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2015-12-16 16:32 ` [PATCH v6 2/9] mfd: axp20x: Remove second struct device * parameter for axp20x_match_device() Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2016-01-11  9:25   ` Lee Jones
2016-01-11  9:25     ` Lee Jones
2016-01-11  9:25     ` Lee Jones
2015-12-16 16:32 ` [PATCH v6 3/9] mfd: axp20x: use dev->driver->of_match_table in axp20x_match_device() Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2016-01-11  9:25   ` Lee Jones
2016-01-11  9:25     ` Lee Jones
2016-01-11  9:25     ` Lee Jones
2015-12-16 16:32 ` [PATCH v6 4/9] mfd: axp20x: Split the driver into core and i2c bits Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2016-01-11  9:25   ` Lee Jones
2016-01-11  9:25     ` Lee Jones
2016-01-11  9:25     ` Lee Jones
2016-01-12  2:06     ` Chen-Yu Tsai
2016-01-12  2:06       ` Chen-Yu Tsai
2016-01-12  2:06       ` Chen-Yu Tsai
2016-01-12  7:39       ` Lee Jones
2016-01-12  7:39         ` Lee Jones
2016-01-12  7:39         ` Lee Jones
2015-12-16 16:32 ` [PATCH v6 5/9] mfd: axp20x: Whitespace, open parenthesis alignment code style fixes Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2016-01-11  9:24   ` Lee Jones [this message]
2016-01-11  9:24     ` Lee Jones
2016-01-11  9:24     ` Lee Jones
2015-12-16 16:32 ` [PATCH v6 6/9] mfd: axp20x: Add support for RSB based AXP223 PMIC Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2016-01-11  9:24   ` Lee Jones
2016-01-11  9:24     ` Lee Jones
2016-01-11  9:24     ` Lee Jones
2016-01-11 11:58     ` Chen-Yu Tsai
2016-01-11 11:58       ` Chen-Yu Tsai
2016-01-11 12:09       ` Lee Jones
2016-01-11 12:09         ` Lee Jones
2016-01-11 12:09         ` Lee Jones
2016-01-11 12:49         ` Chen-Yu Tsai
2016-01-11 12:49           ` Chen-Yu Tsai
2016-01-11 12:49           ` Chen-Yu Tsai
2016-01-11 13:35           ` Lee Jones
2016-01-11 13:35             ` Lee Jones
2016-01-11 13:35             ` Lee Jones
2015-12-16 16:32 ` [PATCH v6 7/9] regulator: axp20x: Support new " Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2015-12-16 16:32 ` [PATCH v6 8/9] ARM: dts: sun8i: sinlinx-sina33: Add AXP223 PMIC device and regulator nodes Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2015-12-16 16:32 ` [PATCH v6 9/9] ARM: dts: sun8i: q8-common: " Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2015-12-16 16:32   ` Chen-Yu Tsai
2016-01-04  8:40 ` [PATCH v6 0/9] mfd: axp20x: Add support for RSB based AXP223 Chen-Yu Tsai
2016-01-04  8:40   ` Chen-Yu Tsai
2016-01-04  8:40   ` Chen-Yu Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160111092454.GJ14104@x1 \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.