From: Peter Zijlstra <peterz@infradead.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Ameen <ameenali023@gmail.com>,
mingo@kernel.org, mhocko@suse.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Use num_possible_cpus() instead of direct use of NR_CPUS.
Date: Mon, 11 Jan 2016 23:14:36 +0100 [thread overview]
Message-ID: <20160111221436.GL6344@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <5693B22E.3070409@suse.cz>
On Mon, Jan 11, 2016 at 02:46:22PM +0100, Vlastimil Babka wrote:
> On 01/10/2016 04:13 PM, Ameen wrote:
> > WARNING: usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus()..
>
> Is that a checkpatch warning? Notice the word "often". You need to provide info
> why it's the case here (and I doubt the change will be corect in this case).
Yeah, this is terminally broken.
prev parent reply other threads:[~2016-01-11 22:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-10 15:13 [PATCH 2/2] Use num_possible_cpus() instead of direct use of NR_CPUS Ameen
2016-01-11 13:46 ` Vlastimil Babka
2016-01-11 22:14 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160111221436.GL6344@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ameenali023@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.