From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Santosh Shukla <sshukla@mvista.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 09/12] virtio: vfio: Enable RTE_PCI_DRV_NEED_MAPPING flag in driver
Date: Tue, 12 Jan 2016 15:14:17 +0800 [thread overview]
Message-ID: <20160112071417.GO26062@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <CAAyOgsbAkD=FEecYJ7jCcB5JBc8x34i9uX4e2yiabgvZsY+S3g@mail.gmail.com>
On Sat, Jan 09, 2016 at 06:08:46PM +0530, Santosh Shukla wrote:
> On Thu, Jan 7, 2016 at 11:50 PM, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> > On Thu, 7 Jan 2016 22:03:06 +0530
> > Santosh Shukla <sshukla@mvista.com> wrote:
> >
> >> +#ifdef RTE_EAL_VFIO
> >> + .drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_DETACHABLE,
> >> +#else
> >> .drv_flags = RTE_PCI_DRV_DETACHABLE,
> >> +#endif
> >
> > Since VFIO is determined at runtime not compile time, the flags should
> > be updated at runtime not compile time.
> >
> >
> In general, Yes, Its a wrong approach i..e. Wrapping __need_mapping
> flag only for vfio case. I am thinking to add vfio parser routine
> something similar to virtio_xxx_xx_uio_xx() / virtio_xx_xx_ioport()
> currently exist. This will remove RTE_EAL_VFIO ifdef clutter for this
> patch and [08/12] patch and also virtio pmd driver can then initialize
> device for vfio mode..
>
> _but_ I still need _MAPPING flag enabled for in virtio driver as
> because for vfio case - I want vfio_xx_mmap() routine to create vfio
> container/group_id and then create vfio_dev_fd for each virtio-net-pci
> interface.
I'm thinking my following patch will help:
http://dpdk.org/dev/patchwork/patch/9814/
--yliu
> Let me know my approach aligned to your suggestion.
next prev parent reply other threads:[~2016-01-12 7:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 16:32 [PATCH v3 00/12] Add virtio support for arm/arm64 Santosh Shukla
2016-01-07 16:32 ` [PATCH v3 01/12] virtio: Introduce config RTE_VIRTIO_INC_VECTOR Santosh Shukla
2016-01-07 16:32 ` [PATCH v3 02/12] config: i686: set RTE_VIRTIO_INC_VECTOR=n Santosh Shukla
2016-01-07 16:33 ` [PATCH v3 03/12] linuxapp: eal: arm: Always return 0 for rte_eal_iopl_init() Santosh Shukla
2016-01-07 18:14 ` Stephen Hemminger
2016-01-09 13:18 ` Santosh Shukla
2016-01-07 16:33 ` [PATCH v3 04/12] linuxapp/vfio: ignore mapping for ioport region Santosh Shukla
2016-01-07 18:16 ` Stephen Hemminger
2016-01-07 18:53 ` Santosh Shukla
2016-01-08 7:29 ` Yuanhan Liu
2016-01-07 16:33 ` [PATCH v3 05/12] virtio_pci.h: build fix for sys/io.h for non-x86 arch Santosh Shukla
2016-01-07 16:33 ` [PATCH v3 06/12] eal: pci: vfio: add rd/wr func for pci bar space Santosh Shukla
2016-01-07 18:19 ` Stephen Hemminger
2016-01-07 18:26 ` Wiles, Keith
2016-01-07 18:39 ` Stephen Hemminger
2016-01-07 18:48 ` Santosh Shukla
2016-01-07 18:46 ` Santosh Shukla
2016-01-13 14:47 ` Bruce Richardson
2016-01-07 16:33 ` [PATCH v3 07/12] virtio: vfio: add api support to rd/wr ioport bar Santosh Shukla
2016-01-07 16:33 ` [PATCH v3 08/12] virtio: Add capability to initialize driver for vfio interface Santosh Shukla
2016-01-07 16:33 ` [PATCH v3 09/12] virtio: vfio: Enable RTE_PCI_DRV_NEED_MAPPING flag in driver Santosh Shukla
2016-01-07 18:20 ` Stephen Hemminger
2016-01-09 12:38 ` Santosh Shukla
2016-01-12 7:14 ` Yuanhan Liu [this message]
2016-01-13 12:18 ` Santosh Shukla
2016-01-07 16:33 ` [PATCH v3 10/12] config: armv7/v8: Enable RTE_LIBRTE_VIRTIO_PMD Santosh Shukla
2016-01-07 16:33 ` [PATCH v3 11/12] vfio: Support for no-IOMMU mode Santosh Shukla
2016-01-07 16:33 ` [PATCH v3 12/12] eal: pci: vfio: fix build error Santosh Shukla
2016-01-07 17:02 ` Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160112071417.GO26062@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=dev@dpdk.org \
--cc=sshukla@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.