All of lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mfd: asic3: remove extraneous ')'
Date: Tue, 12 Jan 2016 09:16:43 +0000	[thread overview]
Message-ID: <20160112091643.GA27358@x1> (raw)
In-Reply-To: <20160112091606.GV19803@x1>

On Tue, 12 Jan 2016, Lee Jones wrote:

> On Tue, 12 Jan 2016, Arnd Bergmann wrote:
> > A cleanup patch introduced an extra closing ')' that leads to a
> > build error:
> > 
> > drivers/mfd/asic3.c: In function 'asic3_gpio_get':
> > drivers/mfd/asic3.c:505:12: error: expected ';' before ')' token
> > 
> > This removes the extra character to get it to build again.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: fd5b4d01a638 ("mfd: asic3: Be sure to clamp return value")
> > ---
> > This came up today on linux-next. I took the liberty to adjust formatting
> > of that line as well, if you prefer the original line wrapping please
> > undo that part when applying.
> 
> Please ignore MFD in next, as it's not quite ready.  I've been on
> vacation for 4 weeks and only returned to work yesterday.  I am
> currently running MFD through AIAIAI and will fix-up any issues I
> find.

As for you Linus.  Tut tut.  ;)

> > diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
> > index c8d46e51faf1..4dca6bc61f5b 100644
> > --- a/drivers/mfd/asic3.c
> > +++ b/drivers/mfd/asic3.c
> > @@ -501,8 +501,8 @@ static int asic3_gpio_get(struct gpio_chip *chip,
> >  		return -EINVAL;
> >  	}
> >  
> > -	return !!(asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS)
> > -		  & mask));
> > +	return !!(asic3_read_register(asic,
> > +				      gpio_base + ASIC3_GPIO_STATUS) & mask);
> >  }
> >  
> >  static void asic3_gpio_set(struct gpio_chip *chip,
> > 
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Paul Parsons <lost.distance@yahoo.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mfd: asic3: remove extraneous ')'
Date: Tue, 12 Jan 2016 09:16:43 +0000	[thread overview]
Message-ID: <20160112091643.GA27358@x1> (raw)
In-Reply-To: <20160112091606.GV19803@x1>

On Tue, 12 Jan 2016, Lee Jones wrote:

> On Tue, 12 Jan 2016, Arnd Bergmann wrote:
> > A cleanup patch introduced an extra closing ')' that leads to a
> > build error:
> > 
> > drivers/mfd/asic3.c: In function 'asic3_gpio_get':
> > drivers/mfd/asic3.c:505:12: error: expected ';' before ')' token
> > 
> > This removes the extra character to get it to build again.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: fd5b4d01a638 ("mfd: asic3: Be sure to clamp return value")
> > ---
> > This came up today on linux-next. I took the liberty to adjust formatting
> > of that line as well, if you prefer the original line wrapping please
> > undo that part when applying.
> 
> Please ignore MFD in next, as it's not quite ready.  I've been on
> vacation for 4 weeks and only returned to work yesterday.  I am
> currently running MFD through AIAIAI and will fix-up any issues I
> find.

As for you Linus.  Tut tut.  ;)

> > diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c
> > index c8d46e51faf1..4dca6bc61f5b 100644
> > --- a/drivers/mfd/asic3.c
> > +++ b/drivers/mfd/asic3.c
> > @@ -501,8 +501,8 @@ static int asic3_gpio_get(struct gpio_chip *chip,
> >  		return -EINVAL;
> >  	}
> >  
> > -	return !!(asic3_read_register(asic, gpio_base + ASIC3_GPIO_STATUS)
> > -		  & mask));
> > +	return !!(asic3_read_register(asic,
> > +				      gpio_base + ASIC3_GPIO_STATUS) & mask);
> >  }
> >  
> >  static void asic3_gpio_set(struct gpio_chip *chip,
> > 
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2016-01-12  9:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-12  9:02 [PATCH] mfd: asic3: remove extraneous ')' Arnd Bergmann
2016-01-12  9:02 ` Arnd Bergmann
2016-01-12  9:16 ` Lee Jones
2016-01-12  9:16   ` Lee Jones
2016-01-12  9:16   ` Lee Jones [this message]
2016-01-12  9:16     ` Lee Jones
2016-01-14  9:09 ` Linus Walleij
2016-01-14  9:09   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160112091643.GA27358@x1 \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.