From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org
Subject: Re: [PATCH V3 1/1] input: gpio-keys: add support for disable button from DT
Date: Wed, 13 Jan 2016 00:16:24 -0800 [thread overview]
Message-ID: <20160113081624.GA21845@dtor-ws> (raw)
In-Reply-To: <1452669980-16460-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
On Wed, Jan 13, 2016 at 12:56:20PM +0530, Laxman Dewangan wrote:
> Add support to disable the button from DT via status property
> if given button is not supporting on given platforms.
>
> This will help to re-use the existing dtsi file with status
> enable/disable across platforms.
>
> Signed-off-by: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Applied, thank you.
> ---
> Changes from V1:
> - Converted print to dev_dbg.
> Changes from V2:
> - use of_get_available_child_count() and for_each_available_child_of_node()
>
> drivers/input/keyboard/gpio_keys.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
> index bef317f..ef6ca1c 100644
> --- a/drivers/input/keyboard/gpio_keys.c
> +++ b/drivers/input/keyboard/gpio_keys.c
> @@ -613,7 +613,7 @@ gpio_keys_get_devtree_pdata(struct device *dev)
> if (!node)
> return ERR_PTR(-ENODEV);
>
> - nbuttons = of_get_child_count(node);
> + nbuttons = of_get_available_child_count(node);
> if (nbuttons == 0)
> return ERR_PTR(-ENODEV);
>
> @@ -629,7 +629,7 @@ gpio_keys_get_devtree_pdata(struct device *dev)
> pdata->rep = !!of_get_property(node, "autorepeat", NULL);
>
> i = 0;
> - for_each_child_of_node(node, pp) {
> + for_each_available_child_of_node(node, pp) {
> enum of_gpio_flags flags;
>
> button = &pdata->buttons[i++];
> --
> 2.1.4
>
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
galak@codeaurora.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linus.walleij@linaro.org, bjorn.andersson@sonymobile.com
Subject: Re: [PATCH V3 1/1] input: gpio-keys: add support for disable button from DT
Date: Wed, 13 Jan 2016 00:16:24 -0800 [thread overview]
Message-ID: <20160113081624.GA21845@dtor-ws> (raw)
In-Reply-To: <1452669980-16460-1-git-send-email-ldewangan@nvidia.com>
On Wed, Jan 13, 2016 at 12:56:20PM +0530, Laxman Dewangan wrote:
> Add support to disable the button from DT via status property
> if given button is not supporting on given platforms.
>
> This will help to re-use the existing dtsi file with status
> enable/disable across platforms.
>
> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
Applied, thank you.
> ---
> Changes from V1:
> - Converted print to dev_dbg.
> Changes from V2:
> - use of_get_available_child_count() and for_each_available_child_of_node()
>
> drivers/input/keyboard/gpio_keys.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
> index bef317f..ef6ca1c 100644
> --- a/drivers/input/keyboard/gpio_keys.c
> +++ b/drivers/input/keyboard/gpio_keys.c
> @@ -613,7 +613,7 @@ gpio_keys_get_devtree_pdata(struct device *dev)
> if (!node)
> return ERR_PTR(-ENODEV);
>
> - nbuttons = of_get_child_count(node);
> + nbuttons = of_get_available_child_count(node);
> if (nbuttons == 0)
> return ERR_PTR(-ENODEV);
>
> @@ -629,7 +629,7 @@ gpio_keys_get_devtree_pdata(struct device *dev)
> pdata->rep = !!of_get_property(node, "autorepeat", NULL);
>
> i = 0;
> - for_each_child_of_node(node, pp) {
> + for_each_available_child_of_node(node, pp) {
> enum of_gpio_flags flags;
>
> button = &pdata->buttons[i++];
> --
> 2.1.4
>
--
Dmitry
next prev parent reply other threads:[~2016-01-13 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 7:26 [PATCH V3 1/1] input: gpio-keys: add support for disable button from DT Laxman Dewangan
2016-01-13 7:26 ` Laxman Dewangan
[not found] ` <1452669980-16460-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-01-13 8:16 ` Dmitry Torokhov [this message]
2016-01-13 8:16 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113081624.GA21845@dtor-ws \
--to=dmitry.torokhov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.