From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Jan Luebbe <jlu@pengutronix.de>
Subject: Re: [RFC v2 3/4] i2c: mux: demux-pinctrl: add driver
Date: Wed, 13 Jan 2016 13:55:14 +0100 [thread overview]
Message-ID: <20160113125514.GE1540@katana> (raw)
In-Reply-To: <CAMuHMdUuiuXPFJQpUB+Y3xF34KnqhzdZ+x-E7zL1ywp=sAQWXg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 326 bytes --]
> > +struct i2c_demux_pinctrl_priv {
> > + int cur_chan;
> > + int num_chan;
>
> This is always positive, so you can make num_chan and a few loop counters
> unsigned.
Nope, sadly not. cur_chan can get a -ERRNO, and the type of num_chan is
defined by the return type of of_count_phandle_with_args().
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Linux-sh list <linux-sh@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
Jan Luebbe <jlu@pengutronix.de>
Subject: Re: [RFC v2 3/4] i2c: mux: demux-pinctrl: add driver
Date: Wed, 13 Jan 2016 12:55:14 +0000 [thread overview]
Message-ID: <20160113125514.GE1540@katana> (raw)
In-Reply-To: <CAMuHMdUuiuXPFJQpUB+Y3xF34KnqhzdZ+x-E7zL1ywp=sAQWXg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 326 bytes --]
> > +struct i2c_demux_pinctrl_priv {
> > + int cur_chan;
> > + int num_chan;
>
> This is always positive, so you can make num_chan and a few loop counters
> unsigned.
Nope, sadly not. cur_chan can get a -ERRNO, and the type of num_chan is
defined by the return type of of_count_phandle_with_args().
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-01-13 12:55 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 13:51 [RFC v2 0/4] i2c/of: switch I2C IP cores at runtime via OF_DYNAMIC Wolfram Sang
2016-01-06 13:51 ` Wolfram Sang
2016-01-06 13:51 ` [RFC v2 1/4] of: make of_mutex public Wolfram Sang
2016-01-06 13:51 ` Wolfram Sang
2016-01-06 14:26 ` Geert Uytterhoeven
2016-01-06 14:26 ` Geert Uytterhoeven
2016-01-06 13:51 ` [RFC v2 2/4] dt-bindings: i2c: mux: demux-pinctrl: add bindings Wolfram Sang
2016-01-06 13:51 ` Wolfram Sang
2016-01-06 14:30 ` Geert Uytterhoeven
2016-01-06 14:30 ` Geert Uytterhoeven
2016-01-13 12:52 ` Wolfram Sang
2016-01-13 12:52 ` Wolfram Sang
2016-01-13 14:07 ` Sergei Shtylyov
2016-01-13 14:07 ` Sergei Shtylyov
2016-01-07 16:56 ` Jan Lübbe
2016-01-07 16:56 ` Jan Lübbe
2016-01-13 13:02 ` Wolfram Sang
2016-01-13 13:02 ` Wolfram Sang
2016-01-11 2:52 ` Rob Herring
2016-01-11 2:52 ` Rob Herring
2016-01-11 8:01 ` Geert Uytterhoeven
2016-01-11 8:01 ` Geert Uytterhoeven
2016-01-06 13:51 ` [RFC v2 3/4] i2c: mux: demux-pinctrl: add driver Wolfram Sang
2016-01-06 13:51 ` Wolfram Sang
[not found] ` <1452088285-6427-4-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2016-01-06 14:20 ` Geert Uytterhoeven
2016-01-06 14:20 ` Geert Uytterhoeven
2016-01-06 14:20 ` Geert Uytterhoeven
2016-01-13 12:55 ` Wolfram Sang [this message]
2016-01-13 12:55 ` Wolfram Sang
2016-01-13 16:16 ` Geert Uytterhoeven
2016-01-13 16:16 ` Geert Uytterhoeven
2016-01-13 16:16 ` Geert Uytterhoeven
2016-01-06 17:08 ` Rob Herring
2016-01-06 17:08 ` Rob Herring
2016-01-13 12:55 ` Wolfram Sang
2016-01-13 12:55 ` Wolfram Sang
2016-01-06 13:51 ` [RFC v2 4/4] ARM: shmobile: r8a7790: rework dts to use i2c demuxer Wolfram Sang
2016-01-06 13:51 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113125514.GE1540@katana \
--to=wsa@the-dreams.de \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=jlu@pengutronix.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=pantelis.antoniou@konsulko.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.