From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Fabio Estevam <fabio.estevam@freescale.com>,
Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Timur Tabi <timur@tabi.org>,
Xiubo Li <Xiubo.Lee@gmail.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: fsl: select SND_SOC_FSL_SAI or SND_SOC_FSL_SSI depending on SoC type
Date: Wed, 13 Jan 2016 15:02:08 +0100 [thread overview]
Message-ID: <20160113150208.408864ea@ipc1.ka-ro> (raw)
In-Reply-To: <CAOMZO5BifUkzSkPCf08TSQ3B8AHiXuVhBzy+tMsnMtA8t-AvJg@mail.gmail.com>
Hi,
> On Tue, Jan 12, 2016 at 4:13 PM, Lothar Waßmann <LW@karo-electronics.de> wrote:
>
> > diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> > index 14dfdee..c128823 100644
> > --- a/sound/soc/fsl/Kconfig
> > +++ b/sound/soc/fsl/Kconfig
> > @@ -258,7 +258,8 @@ config SND_SOC_IMX_SGTL5000
> > select SND_SOC_SGTL5000
> > select SND_SOC_IMX_PCM_DMA
> > select SND_SOC_IMX_AUDMUX
> > - select SND_SOC_FSL_SSI
> > + select SND_SOC_FSL_SAI if SOC_IMX6UL
> > + select SND_SOC_FSL_SSI if SOC_IMX6Q || SOC_IMX6SL || SOC_IMX6SX
>
> MX6SX has SSI and SAI interfaces.
>
I chose the settings, so that the default behaviour before this patch is
not changed. The other interface can still be enabled by the user.
[Yes, I know this is a case of the frowned-upon use of 'select' with
user-visible symbols, but this is as things currently are]
Lothar Waßmann
WARNING: multiple messages have this Message-ID (diff)
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Fabio Estevam <fabio.estevam@freescale.com>,
Jaroslav Kysela <perex@perex.cz>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Timur Tabi <timur@tabi.org>,
Xiubo Li <Xiubo.Lee@gmail.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: fsl: select SND_SOC_FSL_SAI or SND_SOC_FSL_SSI depending on SoC type
Date: Wed, 13 Jan 2016 15:02:08 +0100 [thread overview]
Message-ID: <20160113150208.408864ea@ipc1.ka-ro> (raw)
In-Reply-To: <CAOMZO5BifUkzSkPCf08TSQ3B8AHiXuVhBzy+tMsnMtA8t-AvJg@mail.gmail.com>
Hi,
> On Tue, Jan 12, 2016 at 4:13 PM, Lothar Wa=C3=9Fmann <LW@karo-electronics=
.de> wrote:
>=20
> > diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
> > index 14dfdee..c128823 100644
> > --- a/sound/soc/fsl/Kconfig
> > +++ b/sound/soc/fsl/Kconfig
> > @@ -258,7 +258,8 @@ config SND_SOC_IMX_SGTL5000
> > select SND_SOC_SGTL5000
> > select SND_SOC_IMX_PCM_DMA
> > select SND_SOC_IMX_AUDMUX
> > - select SND_SOC_FSL_SSI
> > + select SND_SOC_FSL_SAI if SOC_IMX6UL
> > + select SND_SOC_FSL_SSI if SOC_IMX6Q || SOC_IMX6SL || SOC_IMX6SX
>=20
> MX6SX has SSI and SAI interfaces.
>
I chose the settings, so that the default behaviour before this patch is
not changed. The other interface can still be enabled by the user.
[Yes, I know this is a case of the frowned-upon use of 'select' with
user-visible symbols, but this is as things currently are]
Lothar Wa=C3=9Fmann
next prev parent reply other threads:[~2016-01-13 14:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-12 18:13 [PATCH 0/2] ASoC: fsl: make snd-soc-imx-sgtl5000 driver useable on i.MX6UL Lothar Waßmann
2016-01-12 18:13 ` [PATCH 1/2] ASoC: fsl: imx-sgtl5000: make audmux optional for imx sound driver Lothar Waßmann
2016-01-12 18:13 ` [PATCH 2/2] ASoC: fsl: select SND_SOC_FSL_SAI or SND_SOC_FSL_SSI depending on SoC type Lothar Waßmann
2016-01-12 18:28 ` Timur Tabi
2016-01-13 12:38 ` Lothar Waßmann
2016-01-13 12:38 ` Lothar Waßmann
2016-01-13 12:38 ` Lothar Waßmann
2016-01-13 14:10 ` Timur Tabi
2016-01-13 13:08 ` [alsa-devel] " Fabio Estevam
2016-01-13 13:08 ` Fabio Estevam
2016-01-13 14:02 ` Lothar Waßmann [this message]
2016-01-13 14:02 ` Lothar Waßmann
2016-01-12 18:22 ` [PATCH 1/2] ASoC: fsl: imx-sgtl5000: make audmux optional for imx sound driver Mark Brown
2016-01-13 11:11 ` Lothar Waßmann
2016-01-13 11:11 ` Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113150208.408864ea@ipc1.ka-ro \
--to=lw@karo-electronics.de \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=timur@tabi.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.