From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH] netfilter: nft_ct: mark nft_ct_get_eval_counter __maybe_unused
Date: Wed, 13 Jan 2016 16:54:24 +0100 [thread overview]
Message-ID: <20160113155424.GA1581@salvia> (raw)
In-Reply-To: <6200241.eeH6DHXzHj@wuerfel>
On Wed, Jan 13, 2016 at 02:58:11PM +0100, Arnd Bergmann wrote:
> The newly added nft_ct_get_eval_counter() function is only used when
> CONFIG_NF_CONNTRACK_LABELS is set, otherwise gcc warns about the
> unused definition:
>
> netfilter/nft_ct.c:34:12: warning: 'nft_ct_get_eval_counter' defined but not used [-Wunused-function]
> static u64 nft_ct_get_eval_counter(const struct nf_conn_counter *c,
>
> This marks the function __maybe_unused to shut up the warning.
It seems that function doesn't below to CONFIG_NF_CONNTRACK_LABELS as
it is part of the new counter support. Will be sending an alternate
patch instead.
Thanks anyway for your patch Arnd.
WARNING: multiple messages have this Message-ID (diff)
From: pablo@netfilter.org (Pablo Neira Ayuso)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] netfilter: nft_ct: mark nft_ct_get_eval_counter __maybe_unused
Date: Wed, 13 Jan 2016 16:54:24 +0100 [thread overview]
Message-ID: <20160113155424.GA1581@salvia> (raw)
In-Reply-To: <6200241.eeH6DHXzHj@wuerfel>
On Wed, Jan 13, 2016 at 02:58:11PM +0100, Arnd Bergmann wrote:
> The newly added nft_ct_get_eval_counter() function is only used when
> CONFIG_NF_CONNTRACK_LABELS is set, otherwise gcc warns about the
> unused definition:
>
> netfilter/nft_ct.c:34:12: warning: 'nft_ct_get_eval_counter' defined but not used [-Wunused-function]
> static u64 nft_ct_get_eval_counter(const struct nf_conn_counter *c,
>
> This marks the function __maybe_unused to shut up the warning.
It seems that function doesn't below to CONFIG_NF_CONNTRACK_LABELS as
it is part of the new counter support. Will be sending an alternate
patch instead.
Thanks anyway for your patch Arnd.
next prev parent reply other threads:[~2016-01-13 15:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 13:58 [PATCH] netfilter: nft_ct: mark nft_ct_get_eval_counter __maybe_unused Arnd Bergmann
2016-01-13 13:58 ` Arnd Bergmann
2016-01-13 15:54 ` Pablo Neira Ayuso [this message]
2016-01-13 15:54 ` Pablo Neira Ayuso
2016-01-13 16:49 ` Pablo Neira Ayuso
2016-01-13 16:49 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113155424.GA1581@salvia \
--to=pablo@netfilter.org \
--cc=arnd@arndb.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.