From: Bjorn Helgaas <helgaas@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "Grygorii Strashko" <grygorii.strashko@ti.com>,
linux-pci@vger.kernel.org, "Bjorn Helgaas" <bhelgaas@google.com>,
tony@atomide.com, nsekhar@ti.com,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-sh@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Kishon Vijay Abraham I" <kishon@ti.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Kukjin Kim" <kgene@kernel.org>,
"Krzysztof Kozlowski" <k.kozlowski@samsung.com>,
"Richard Zhu" <Richard.Zhu@freescale.com>,
"Lucas Stach" <l.stach@pengutronix.de>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Stephen Warren" <swarren@wwwdotorg.org>,
"Alexandre Courbot" <gnurou@gmail.com>,
"Simon Horman" <horms@verge.net.au>,
"Pratyush Anand" <pratyush.anand@gmail.com>,
"Michal Simek" <michal.simek@xilinx.com>,
"Sören Brinkmann" <soren.brinkmann@xilinx.com>
Subject: Re: [PATCH v3] PCI: hosts: mark pcie/pci (msi) irq cascade handler as IRQF_NO_THREAD
Date: Wed, 13 Jan 2016 11:50:16 -0600 [thread overview]
Message-ID: <20160113175016.GB28453@localhost> (raw)
In-Reply-To: <20160113133904.GD29964@linutronix.de>
On Wed, Jan 13, 2016 at 02:39:04PM +0100, Sebastian Andrzej Siewior wrote:
> * Bjorn Helgaas | 2016-01-06 16:18:27 [-0600]:
>
> >Hi Bjorn,
>
> >> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
> >> index 8c36880..0415192 100644
> >> --- a/drivers/pci/host/pci-dra7xx.c
> >> +++ b/drivers/pci/host/pci-dra7xx.c
> >> @@ -301,8 +301,19 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
> >> return -EINVAL;
> >> }
> >>
> >> + /*
> >> + * Mark dra7xx_pcie_msi IRQ as IRQF_NO_THREAD
> >> + * On -RT and if kernel is booting with "threadirqs" cmd line parameter
> >> + * the dra7xx_pcie_msi_irq_handler() will be forced threaded but,
> >> + * in the same time, it's IRQ dispatcher and calls generic_handle_irq(),
> >> + * which, in turn, will be resolved to handle_simple_irq() call.
> >> + * The handle_simple_irq() expected to be called with IRQ disabled, as
> >> + * result kernle will display warning:
> >> + * "irq XXX handler YYY+0x0/0x14 enabled interrupts".
> >> + */
>
> could you _please_ remove this coment? This kind of comment (if at all)
> should be part of the commit message (which is the case more or less).
IIRC, Grygorii specifically wanted to keep this comment in dra7xx, but
I do agree that this level of detail is more appropriate for a changelog.
If Grygorii and Kishon don't object, I can update the patch to remove it.
> >> ret = devm_request_irq(&pdev->dev, pp->irq,
> >> - dra7xx_pcie_msi_irq_handler, IRQF_SHARED,
> >> + dra7xx_pcie_msi_irq_handler,
> >> + IRQF_SHARED | IRQF_NO_THREAD,
> >> "dra7-pcie-msi", pp);
> >> if (ret) {
> >> dev_err(&pdev->dev, "failed to request irq\n");
> >> diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c
>
> Sebastian
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] PCI: hosts: mark pcie/pci (msi) irq cascade handler as IRQF_NO_THREAD
Date: Wed, 13 Jan 2016 17:50:16 +0000 [thread overview]
Message-ID: <20160113175016.GB28453@localhost> (raw)
In-Reply-To: <20160113133904.GD29964@linutronix.de>
On Wed, Jan 13, 2016 at 02:39:04PM +0100, Sebastian Andrzej Siewior wrote:
> * Bjorn Helgaas | 2016-01-06 16:18:27 [-0600]:
>
> >Hi Bjorn,
>
> >> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
> >> index 8c36880..0415192 100644
> >> --- a/drivers/pci/host/pci-dra7xx.c
> >> +++ b/drivers/pci/host/pci-dra7xx.c
> >> @@ -301,8 +301,19 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
> >> return -EINVAL;
> >> }
> >>
> >> + /*
> >> + * Mark dra7xx_pcie_msi IRQ as IRQF_NO_THREAD
> >> + * On -RT and if kernel is booting with "threadirqs" cmd line parameter
> >> + * the dra7xx_pcie_msi_irq_handler() will be forced threaded but,
> >> + * in the same time, it's IRQ dispatcher and calls generic_handle_irq(),
> >> + * which, in turn, will be resolved to handle_simple_irq() call.
> >> + * The handle_simple_irq() expected to be called with IRQ disabled, as
> >> + * result kernle will display warning:
> >> + * "irq XXX handler YYY+0x0/0x14 enabled interrupts".
> >> + */
>
> could you _please_ remove this coment? This kind of comment (if at all)
> should be part of the commit message (which is the case more or less).
IIRC, Grygorii specifically wanted to keep this comment in dra7xx, but
I do agree that this level of detail is more appropriate for a changelog.
If Grygorii and Kishon don't object, I can update the patch to remove it.
> >> ret = devm_request_irq(&pdev->dev, pp->irq,
> >> - dra7xx_pcie_msi_irq_handler, IRQF_SHARED,
> >> + dra7xx_pcie_msi_irq_handler,
> >> + IRQF_SHARED | IRQF_NO_THREAD,
> >> "dra7-pcie-msi", pp);
> >> if (ret) {
> >> dev_err(&pdev->dev, "failed to request irq\n");
> >> diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c
>
> Sebastian
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: helgaas@kernel.org (Bjorn Helgaas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] PCI: hosts: mark pcie/pci (msi) irq cascade handler as IRQF_NO_THREAD
Date: Wed, 13 Jan 2016 11:50:16 -0600 [thread overview]
Message-ID: <20160113175016.GB28453@localhost> (raw)
In-Reply-To: <20160113133904.GD29964@linutronix.de>
On Wed, Jan 13, 2016 at 02:39:04PM +0100, Sebastian Andrzej Siewior wrote:
> * Bjorn Helgaas | 2016-01-06 16:18:27 [-0600]:
>
> >Hi Bjorn,
>
> >> diff --git a/drivers/pci/host/pci-dra7xx.c b/drivers/pci/host/pci-dra7xx.c
> >> index 8c36880..0415192 100644
> >> --- a/drivers/pci/host/pci-dra7xx.c
> >> +++ b/drivers/pci/host/pci-dra7xx.c
> >> @@ -301,8 +301,19 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx,
> >> return -EINVAL;
> >> }
> >>
> >> + /*
> >> + * Mark dra7xx_pcie_msi IRQ as IRQF_NO_THREAD
> >> + * On -RT and if kernel is booting with "threadirqs" cmd line parameter
> >> + * the dra7xx_pcie_msi_irq_handler() will be forced threaded but,
> >> + * in the same time, it's IRQ dispatcher and calls generic_handle_irq(),
> >> + * which, in turn, will be resolved to handle_simple_irq() call.
> >> + * The handle_simple_irq() expected to be called with IRQ disabled, as
> >> + * result kernle will display warning:
> >> + * "irq XXX handler YYY+0x0/0x14 enabled interrupts".
> >> + */
>
> could you _please_ remove this coment? This kind of comment (if at all)
> should be part of the commit message (which is the case more or less).
IIRC, Grygorii specifically wanted to keep this comment in dra7xx, but
I do agree that this level of detail is more appropriate for a changelog.
If Grygorii and Kishon don't object, I can update the patch to remove it.
> >> ret = devm_request_irq(&pdev->dev, pp->irq,
> >> - dra7xx_pcie_msi_irq_handler, IRQF_SHARED,
> >> + dra7xx_pcie_msi_irq_handler,
> >> + IRQF_SHARED | IRQF_NO_THREAD,
> >> "dra7-pcie-msi", pp);
> >> if (ret) {
> >> dev_err(&pdev->dev, "failed to request irq\n");
> >> diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c
>
> Sebastian
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-13 17:50 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 19:18 [PATCH v3] PCI: hosts: mark pcie/pci (msi) irq cascade handler as IRQF_NO_THREAD Grygorii Strashko
2015-12-10 19:18 ` Grygorii Strashko
2015-12-10 19:18 ` Grygorii Strashko
2015-12-10 19:18 ` Grygorii Strashko
2016-01-06 22:18 ` Bjorn Helgaas
2016-01-06 22:18 ` Bjorn Helgaas
2016-01-06 22:18 ` Bjorn Helgaas
2016-01-13 13:39 ` Sebastian Andrzej Siewior
2016-01-13 13:39 ` Sebastian Andrzej Siewior
2016-01-13 13:39 ` Sebastian Andrzej Siewior
2016-01-13 17:50 ` Bjorn Helgaas [this message]
2016-01-13 17:50 ` Bjorn Helgaas
2016-01-13 17:50 ` Bjorn Helgaas
2016-01-13 18:48 ` Grygorii Strashko
2016-01-13 18:48 ` Grygorii Strashko
2016-01-13 18:48 ` Grygorii Strashko
2016-01-13 18:48 ` Grygorii Strashko
2016-01-14 6:19 ` Kishon Vijay Abraham I
2016-01-14 6:31 ` Kishon Vijay Abraham I
2016-01-14 6:19 ` Kishon Vijay Abraham I
2016-01-15 18:31 ` Bjorn Helgaas
2016-01-15 18:31 ` Bjorn Helgaas
2016-01-15 18:31 ` Bjorn Helgaas
2016-01-07 9:18 ` Lucas Stach
2016-01-07 9:18 ` Lucas Stach
2016-01-07 9:18 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113175016.GB28453@localhost \
--to=helgaas@kernel.org \
--cc=Richard.Zhu@freescale.com \
--cc=bhelgaas@google.com \
--cc=bigeasy@linutronix.de \
--cc=gnurou@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=horms@verge.net.au \
--cc=jingoohan1@gmail.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=kishon@ti.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=nsekhar@ti.com \
--cc=pratyush.anand@gmail.com \
--cc=soren.brinkmann@xilinx.com \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.