From: Pavel Machek <pavel@ucw.cz>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
tony@atomide.com, sre@debian.org, sre@ring0.de,
"kernel list" <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, khilman@kernel.org,
aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
patrikbachan@gmail.com
Subject: Re: Nokia N900: u-SD card in v4.2+
Date: Wed, 13 Jan 2016 20:12:40 +0100 [thread overview]
Message-ID: <20160113191240.GA10717@amd> (raw)
In-Reply-To: <56936A77.9070803@ti.com>
On Mon 2016-01-11 14:10:23, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Sunday 10 January 2016 04:14 AM, Pali Rohár wrote:
> > On Thursday 07 January 2016 12:34:09 Pavel Machek wrote:
> >> Hi!
> >>
> >>> On Thursday 07 January 2016 02:16 AM, Pavel Machek wrote:
> >>>> Hi!
> >>>>
> >>>> In v4.1, both internal MMC and u-SD cards work ok.
> >>>>
> >>>> In v4.2, only the internal MMC is detected. In v4.3, not even
> >>>> internal MMC works. In v4.4, only the internal MMC is detected.
> >>>>
> >>>> Does it work for you? Any patches?
> >>>
> >>> I don't have Nokia N900 to check this, but can you share your
> >>> config and kernel logs? Check if CONFIG_REGULATOR_PBIAS is present
> >>> in your config. CONFIG_REGULATOR_PBIAS is now mandatory for all
> >>> omap3+ SoCs to work.
> >>
> >> I enabled CONFIG_REGULATOR_PBIAS and both MMCs now work.
> >>
> >> I wonder if we should add some selects, so that users updating from
> >> old kernels don't break their system?
> >
> > Please add these selects. I had CONFIG_REGULATOR_PBIAS disabled too,
> > because I just updated defconfig from older kernel version.
>
> 'select' is generally not recommended since it selects a config without
> caring for the dependency. With adding 'depends on', MMC won't be enabled and
> will end up in the same problem.
Well... it really should "depend on". Not ideal, but you'll likely
realize what went on.
Silently compiling known-bad kernel is ... well.. bad.
> Tony has already added a Documentation noting that CONFIG_REGULATOR_PBIAS
> should be enabled for MMCs to work.
> commit d8e1f5ed11a39a68da00f05000466c4f6db4456e
> Author: Tony Lindgren <tony@atomide.com>
> Date: Mon Oct 12 16:19:54 2015 -0700
>
> Documentation: ARM: List new omap MMC requirements
>
> Maybe we should also make the error message a little more verbose to tell the
> user that CONFIG_REGULATOR_PBIAS be selected?
That would help.
As would #error if we recognize broken config.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: Nokia N900: u-SD card in v4.2+
Date: Wed, 13 Jan 2016 20:12:40 +0100 [thread overview]
Message-ID: <20160113191240.GA10717@amd> (raw)
In-Reply-To: <56936A77.9070803@ti.com>
On Mon 2016-01-11 14:10:23, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Sunday 10 January 2016 04:14 AM, Pali Roh?r wrote:
> > On Thursday 07 January 2016 12:34:09 Pavel Machek wrote:
> >> Hi!
> >>
> >>> On Thursday 07 January 2016 02:16 AM, Pavel Machek wrote:
> >>>> Hi!
> >>>>
> >>>> In v4.1, both internal MMC and u-SD cards work ok.
> >>>>
> >>>> In v4.2, only the internal MMC is detected. In v4.3, not even
> >>>> internal MMC works. In v4.4, only the internal MMC is detected.
> >>>>
> >>>> Does it work for you? Any patches?
> >>>
> >>> I don't have Nokia N900 to check this, but can you share your
> >>> config and kernel logs? Check if CONFIG_REGULATOR_PBIAS is present
> >>> in your config. CONFIG_REGULATOR_PBIAS is now mandatory for all
> >>> omap3+ SoCs to work.
> >>
> >> I enabled CONFIG_REGULATOR_PBIAS and both MMCs now work.
> >>
> >> I wonder if we should add some selects, so that users updating from
> >> old kernels don't break their system?
> >
> > Please add these selects. I had CONFIG_REGULATOR_PBIAS disabled too,
> > because I just updated defconfig from older kernel version.
>
> 'select' is generally not recommended since it selects a config without
> caring for the dependency. With adding 'depends on', MMC won't be enabled and
> will end up in the same problem.
Well... it really should "depend on". Not ideal, but you'll likely
realize what went on.
Silently compiling known-bad kernel is ... well.. bad.
> Tony has already added a Documentation noting that CONFIG_REGULATOR_PBIAS
> should be enabled for MMCs to work.
> commit d8e1f5ed11a39a68da00f05000466c4f6db4456e
> Author: Tony Lindgren <tony@atomide.com>
> Date: Mon Oct 12 16:19:54 2015 -0700
>
> Documentation: ARM: List new omap MMC requirements
>
> Maybe we should also make the error message a little more verbose to tell the
> user that CONFIG_REGULATOR_PBIAS be selected?
That would help.
As would #error if we recognize broken config.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2016-01-13 19:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 20:46 Nokia N900: u-SD card in v4.2+ Pavel Machek
2016-01-06 20:46 ` Pavel Machek
2016-01-07 5:40 ` Kishon Vijay Abraham I
2016-01-07 5:40 ` Kishon Vijay Abraham I
2016-01-07 5:40 ` Kishon Vijay Abraham I
2016-01-07 11:34 ` Pavel Machek
2016-01-07 11:34 ` Pavel Machek
2016-01-09 22:44 ` Pali Rohár
2016-01-09 22:44 ` Pali Rohár
2016-01-11 8:40 ` Kishon Vijay Abraham I
2016-01-11 8:40 ` Kishon Vijay Abraham I
2016-01-11 8:40 ` Kishon Vijay Abraham I
2016-01-13 19:12 ` Pavel Machek [this message]
2016-01-13 19:12 ` Pavel Machek
2016-01-13 19:20 ` Tony Lindgren
2016-01-13 19:20 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113191240.GA10717@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=pali.rohar@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=sre@debian.org \
--cc=sre@ring0.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.