From: Andrew Lunn <andrew@lunn.ch>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Igal Liberman <igal.liberman@freescale.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: fsl/fman: Clarification for implementation details in dtsec_config()
Date: Wed, 13 Jan 2016 22:09:23 +0000 [thread overview]
Message-ID: <20160113220923.GE5527@lunn.ch> (raw)
In-Reply-To: <20160113213537.GD4399@mwanda>
On Thu, Jan 14, 2016 at 12:35:37AM +0300, Dan Carpenter wrote:
> I think you can remove the put_device() line.
Agreed.
of_phy_find_device() only does a get_device() when it finds a matching
device.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Igal Liberman <igal.liberman@freescale.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: fsl/fman: Clarification for implementation details in dtsec_config()
Date: Wed, 13 Jan 2016 23:09:23 +0100 [thread overview]
Message-ID: <20160113220923.GE5527@lunn.ch> (raw)
In-Reply-To: <20160113213537.GD4399@mwanda>
On Thu, Jan 14, 2016 at 12:35:37AM +0300, Dan Carpenter wrote:
> I think you can remove the put_device() line.
Agreed.
of_phy_find_device() only does a get_device() when it finds a matching
device.
Andrew
next prev parent reply other threads:[~2016-01-13 22:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 21:20 fsl/fman: Clarification for implementation details in dtsec_config() SF Markus Elfring
2016-01-13 21:20 ` SF Markus Elfring
2016-01-13 21:35 ` Dan Carpenter
2016-01-13 21:35 ` Dan Carpenter
2016-01-13 22:09 ` Andrew Lunn [this message]
2016-01-13 22:09 ` Andrew Lunn
2016-01-14 15:00 ` [PATCH] fsl/fman: Delete one function call "put_device" " SF Markus Elfring
2016-01-14 15:00 ` SF Markus Elfring
2016-01-14 16:27 ` Andrew Lunn
2016-01-14 16:27 ` Andrew Lunn
2016-01-14 21:51 ` David Miller
2016-01-14 21:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160113220923.GE5527@lunn.ch \
--to=andrew@lunn.ch \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=elfring@users.sourceforge.net \
--cc=igal.liberman@freescale.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.