From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: Disable "DISCARD" for secure section if CONFIG_ARMV7_SECURE_BASE isn't defined
Date: Thu, 14 Jan 2016 12:56:42 -0500 [thread overview]
Message-ID: <20160114175642.GG3359@bill-the-cat> (raw)
In-Reply-To: <DB3PR04MB169BF18D81F0FDBC7F4680497C90@DB3PR04MB169.eurprd04.prod.outlook.com>
On Mon, Jan 11, 2016 at 02:51:39AM +0000, Dongsheng Wang wrote:
> Hi Tom,
>
> Sorry for my late reply, and thanks for your reply.
>
> How about the following comments, following your suggestion I remove some redundant comments?
>
> If my understanding is wrong, please correct me, thanks:
> #if defined(CONFIG_ARMV7_SECURE_BASE) && defined(CONFIG_ARMV7_NONSEC)
> /*
> * If CONFIG_ARMV7_SECURE_BASE is true, secure code will not
> * bundle with u-boot, and codes offset are fixed. Secure zone
code offsets
> * only needs to be copied from loading address to
from the loading address
> * CONFIG_ARMV7_SECURE_BASE, which is the linking and running
> * address for secure code.
> *
> * If undefine CONFIG_ARMV7_SECURE_BASE secure zone will be
If CONFIG_ARMV7_SECURE_BASE is undefined, the secure zone will be
> * included in u-boot space, and some absolute address were used
u-boot address space
> * in secure code. Accompanied by u-boot relocation secure code
> * also need to relocate the absolute address.
in secure code. The absolute addresses of the secure code also needs to
be relocated along with the accompanying u-boot code.
> *
> * So DISCARD is only for CONFIG_ARMV7_SECURE_BASE.
> */
> /DISCARD/ : { *(.rel._secure*) }
> #endif
Otherwise looks good, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160114/f8ac713e/attachment.sig>
next prev parent reply other threads:[~2016-01-14 17:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 2:49 [U-Boot] [PATCH] ARM: Disable "DISCARD" for secure section if CONFIG_ARMV7_SECURE_BASE isn't defined Dongsheng Wang
2015-12-10 12:25 ` Tom Rini
2015-12-11 10:15 ` Dongsheng Wang
2015-12-11 12:29 ` Tom Rini
2015-12-11 15:30 ` Dongsheng Wang
2016-01-04 15:50 ` Tom Rini
2016-01-05 1:07 ` Peng Fan
2016-01-11 2:51 ` Dongsheng Wang
2016-01-14 17:56 ` Tom Rini [this message]
2016-01-18 3:02 ` Dongsheng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160114175642.GG3359@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.